linux-stable.git/drivers/net/sfc, branch v2.6.30

sfc: Use correct macro to set event bitfield

2009-04-15T02:48:34+00:00

falcon_sim_phy_event() used EFX_OWORD_FIELD, which operates on
bitfields in 128-bit values, on an event, which is a 64-bit value.
This should be harmless - these macros always use little-endian
ordering, so it would read and write back the following 8 bytes
unchanged - but it is obviously wrong.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

sfc: Match calls to netif_napi_add() and netif_napi_del()

2009-04-15T02:47:46+00:00

sfc could call netif_napi_add() multiple times for the same
napi_struct, corrupting the list of napi_structs for the associated
device and leading to a busy-loop on device removal.  Move the call to
netif_napi_add() and add a call to netif_napi_del() in the obvious
places.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

sfc: Call netif_napi_add() before registering our interrupt handler

2009-03-31T22:07:21+00:00

If we use a shared legacy IRQ then our interrupt handler may be called
as soon as it is registered even though IRQs are disabled on the NIC.
Now that the legacy interrupt handler also checks for event delivery,
it may decide to schedule polling in this case.  Ensure that the NAPI
context is valid but disabled at this point.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

Merge branch 'core/percpu' into percpu-cpumask-x86-for-linus-2

2009-03-27T16:28:43+00:00

Conflicts:
	arch/parisc/kernel/irq.c
	arch/x86/include/asm/fixmap_64.h
	arch/x86/include/asm/setup.h
	kernel/irq/handle.c

Semantic merge:
        arch/x86/include/asm/fixmap.h

Signed-off-by: Ingo Molnar

sfc: Implement adaptive IRQ moderation

2009-03-22T02:06:58+00:00

Calculate a score for each 1000 IRQs:
- TX completions are worth 1 point
- RX completions are worth 4 if merged using LRO or 2 otherwise

Reduce moderation if the score is less than 10000, down to a minimum
of 5 us.  Increase moderation if the score is more than 20000, up to
the specified maximum.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

sfc: Optimise falcon_writel_page_locked() for page > 0

2009-03-22T02:06:56+00:00

The bug this function works around only applies to the first set of
page-mapped registers; other pages can be written without locking.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

sfc: Remove unused private PCI register definitions

2009-03-22T02:06:56+00:00

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

sfc: Work around unreliable legacy interrupt status

2009-03-22T02:06:55+00:00

In rare cases, reading the legacy interrupt status register can
acknowledge an event queue whose attention flag has not yet been set
in the register.  Until we service this event queue it will not
generate any more interrupts.  Therefore, as a secondary check, poll
the next slot in each active event queue whose flag is not set.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

sfc: Pad packets to 33 bytes to prevent TX packet parser lockup

2009-03-22T02:06:55+00:00

The packet parser used in the TX data path for locating checksum
fields can lose synchronisation with the TX queue manager when
handling packets that look like IPv4 but are too short (17-32 bytes).
Work around this by padding to 33 bytes.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

sfc: Improve NIC internal error recovery

2009-03-05T01:40:25+00:00

Make the error count a per-NIC variable.
Reset this the count after an hour if it has not reached the critical value.
Set the critical value back to 5.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller