linux-stable.git/drivers/net/pse-pd, branch v6.14

net: pse-pd: pd692x0: Fix power limit retrieval

2025-02-19T02:30:27+00:00

Fix incorrect data offset read in the pd692x0_pi_get_pw_limit callback.
The issue was previously unnoticed as it was only used by the regulator
API and not thoroughly tested, since the PSE is mainly controlled via
ethtool.

The function became actively used by ethtool after commit 3e9dbfec4998
("net: pse-pd: Split ethtool_get_status into multiple callbacks"),
which led to the discovery of this issue.

Fix it by using the correct data offset.

Fixes: a87e699c9d33 ("net: pse-pd: pd692x0: Enhance with new current limit and voltage read callbacks")
Signed-off-by: Kory Maincent 
Link: https://patch.msgid.link/20250217134812.1925345-1-kory.maincent@bootlin.com
Signed-off-by: Jakub Kicinski

net: pse-pd: Fix deadlock in current limit functions

2025-02-13T18:00:39+00:00

Fix a deadlock in pse_pi_get_current_limit and pse_pi_set_current_limit
caused by consecutive mutex_lock calls. One in the function itself and
another in pse_pi_get_voltage.

Resolve the issue by using the unlocked version of pse_pi_get_voltage
instead.

Fixes: e0a5e2bba38a ("net: pse-pd: Use power limit at driver side instead of current limit")
Signed-off-by: Kory Maincent 
Link: https://patch.msgid.link/20250212151751.1515008-1-kory.maincent@bootlin.com
Signed-off-by: Jakub Kicinski

net: pse-pd: Clean ethtool header of PSE structures

2025-01-14T12:56:33+00:00

Remove PSE-specific structures from the ethtool header to improve code
modularity, maintain independent headers, and reduce incremental build
time.

Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Fix missing PI of_node description

2025-01-14T12:56:33+00:00

The PI of_node was not assigned in the regulator_config structure, leading
to failures in resolving the correct supply when different power supplies
are assigned to multiple PIs of a PSE controller. This fix ensures that the
of_node is properly set in the regulator_config, allowing accurate supply
resolution for each PI.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: tps23881: Add support for power limit and measurement features

2025-01-14T12:56:33+00:00

Expand PSE callbacks to support the newly introduced
pi_get/set_pw_limit() and pi_get_voltage() functions. These callbacks
allow for power limit configuration in the TPS23881 controller.

Additionally, the patch includes the pi_get_pw_class() the
pi_get_actual_pw(), and the pi_get_pw_limit_ranges') callbacks providing
more comprehensive PoE status reporting.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Remove is_enabled callback from drivers

2025-01-14T12:56:32+00:00

The is_enabled callback is now redundant as the admin_state can be obtained
directly from the driver and provides the same information.

To simplify functionality, the core will handle this internally, making
the is_enabled callback unnecessary at the driver level. Remove the
callback from all drivers.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Split ethtool_get_status into multiple callbacks

2025-01-14T12:56:32+00:00

The ethtool_get_status callback currently handles all status and PSE
information within a single function. This approach has two key
drawbacks:

1. If the core requires some information for purposes other than
   ethtool_get_status, redundant code will be needed to fetch the same
   data from the driver (like is_enabled).

2. Drivers currently have access to all information passed to ethtool.
   New variables will soon be added to ethtool status, such as PSE ID,
   power domain IDs, and budget evaluation strategies, which are meant
   to be managed solely by the core. Drivers should not have the ability
   to modify these variables.

To resolve these issues, ethtool_get_status has been split into multiple
callbacks, with each handling a specific piece of information required
by ethtool or the core.

Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Use power limit at driver side instead of current limit

2025-01-14T12:56:32+00:00

The regulator framework uses current limits, but the PSE standard and
known PSE controllers rely on power limits. Instead of converting
current to power within each driver, perform the conversion in the PSE
core. This avoids redundancy in driver implementation and aligns better
with the standard, simplifying driver development.

Remove at the same time the _pse_ethtool_get_status() function which is
not needed anymore.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: tps23881: Add missing configuration register after disable

2025-01-14T12:56:32+00:00

When setting the PWOFF register, the controller resets multiple
configuration registers. This patch ensures these registers are
reconfigured as needed following a disable operation.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: tps23881: Use helpers to calculate bit offset for a channel

2025-01-14T12:56:32+00:00

This driver frequently follows a pattern where two registers are read or
written in a single operation, followed by calculating the bit offset for
a specific channel.

Introduce helpers to streamline this process and reduce code redundancy,
making the codebase cleaner and more maintainable.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni