linux-stable.git/drivers/net/phy/phy_device.c, branch v5.14.2

net: phy: fix formatting issues with braces

2021-06-16T19:34:07+00:00

Fix following format issues:
1. open brace '{' following function definitions should go to the next
   line.
2. braces {} are not necessary for single line statements.
3. else should follow close brace '}'.

Signed-off-by: Wenpeng Liang 
Signed-off-by: Weihang Li 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: mii_timestamper: check NULL in unregister_mii_timestamper()

2021-06-11T20:08:52+00:00

Callers of unregister_mii_timestamper() currently check for NULL
value of mii_ts before calling it.

Place the NULL check inside unregister_mii_timestamper() and update
the callers accordingly.

Signed-off-by: Calvin Johnson 
Reviewed-by: Andy Shevchenko 
Suggested-by: Andy Shevchenko 
Signed-off-by: Ioana Ciornei 
Acked-by: Grant Likely 
Signed-off-by: David S. Miller

net: phy: Introduce fwnode_get_phy_id()

2021-06-11T20:08:52+00:00

Extract phy_id from compatible string. This will be used by
fwnode_mdiobus_register_phy() to create phy device using the
phy_id.

Signed-off-by: Calvin Johnson 
Signed-off-by: Ioana Ciornei 
Acked-by: Grant Likely 
Signed-off-by: David S. Miller

net: phy: Introduce phy related fwnode functions

2021-06-11T20:08:52+00:00

Define fwnode_phy_find_device() to iterate an mdiobus and find the
phy device of the provided phy fwnode. Additionally define
device_phy_find_device() to find phy device of provided device.

Define fwnode_get_phy_node() to get phy_node using named reference.

Signed-off-by: Calvin Johnson 
Signed-off-by: Ioana Ciornei 
Acked-by: Grant Likely 
Signed-off-by: David S. Miller

net: phy: Introduce fwnode_mdio_find_device()

2021-06-11T20:08:52+00:00

Define fwnode_mdio_find_device() to get a pointer to the
mdio_device from fwnode passed to the function.

Refactor of_mdio_find_device() to use fwnode_mdio_find_device().

Signed-off-by: Calvin Johnson 
Signed-off-by: Ioana Ciornei 
Acked-by: Grant Likely 
Signed-off-by: David S. Miller

net: phy: probe for C45 PHYs that return PHY ID of zero in C22 space

2021-06-10T19:52:16+00:00

PHY devices such as the Marvell Alaska 88E2110 does not return a valid
PHY ID when probed using Clause-22. The current implementation treats
PHY ID of zero as a non-error and valid PHY ID, and causing the PHY
device failed to bind to the Marvell driver.

For such devices, we do an additional probe in the Clause-45 space,
if a valid PHY ID is returned, we then proceed to attach the PHY
device to the matching PHY ID driver.

Signed-off-by: Wong Vee Khee 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: Fix inconsistent indenting

2021-05-21T20:54:16+00:00

Eliminate the follow smatch warning:

drivers/net/phy/phy_device.c:2886 phy_probe() warn: inconsistent
indenting.

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: genphy_loopback: add link speed configuration

2021-04-20T23:08:02+00:00

In case of loopback, in most cases we need to disable autoneg support
and force some speed configuration. Otherwise, depending on currently
active auto negotiated link speed, the loopback may or may not work.

This patch was tested with following PHYs: TJA1102, KSZ8081, KSZ9031,
AT8035, AR9331.

Signed-off-by: Oleksij Rempel 
Signed-off-by: David S. Miller

net: phy: execute genphy_loopback() per default on all PHYs

2021-04-20T23:08:02+00:00

The generic loopback is really generic and is defined by the 802.3
standard, we should just mandate that drivers implement a custom
loopback if the generic one cannot work.

Suggested-by: Florian Fainelli 
Signed-off-by: Oleksij Rempel 
Signed-off-by: David S. Miller

net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM

2021-04-09T23:37:04+00:00

Resume callback of the PHY driver is called after the one for the MAC
driver. The PHY driver resume callback calls phy_init_hw(), and this is
potentially problematic if the MAC driver calls phy_start() in its resume
callback. One issue was reported with the fec driver and a KSZ8081 PHY
which seems to become unstable if a soft reset is triggered during aneg.

The new flag allows MAC drivers to indicate that they take care of
suspending/resuming the PHY. Then the MAC PM callbacks can handle
any dependency between MAC and PHY PM.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Jakub Kicinski