linux-stable.git/drivers/net/phy/phy_device.c, branch v5.1.2

net: phy: don't clear BMCR in genphy_soft_reset

2019-03-26T00:08:21+00:00

So far we effectively clear the BMCR register. Some PHY's can deal
with this (e.g. because they reset BMCR to a default as part of a
soft-reset) whilst on others this causes issues because e.g. the
autoneg bit is cleared. Marvell is an example, see also thread [0].
So let's be a little bit more gentle and leave all bits we're not
interested in as-is. This change is needed for PHY drivers to
properly deal with the original patch.

[0] https://marc.info/?t=155264050700001&r=1&w=2

Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
Tested-by: Phil Reid 
Tested-by: liweihang 
Signed-off-by: Heiner Kallweit 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: export genphy_config_eee_advert

2019-02-21T21:03:06+00:00

We want to use this function in phy-c45.c too, therefore export it.

Signed-off-by: Heiner Kallweit 
Signed-off-by: David S. Miller

net: phy: don't use 10BaseT/half as default in genphy_read_status

2019-02-21T20:57:25+00:00

If link partner and we can't agree on any mode, then it doesn't make
sense to pretend we would have agreed on 10/half. Therefore set a
proper default.

Signed-off-by: Heiner Kallweit 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: remove orphaned register read in genphy_read_status

2019-02-21T20:57:25+00:00

After recent changes to genphy_read_status() this orphaned register
read remained as leftover. So remove it.

Signed-off-by: Heiner Kallweit 
Signed-off-by: David S. Miller

net: phy: use phy_resolve_aneg_linkmode in genphy_read_status

2019-02-17T23:21:38+00:00

Now that we have phy_resolve_aneg_linkmode() we can make
genphy_read_status() much simpler.

Signed-off-by: Heiner Kallweit 
Signed-off-by: David S. Miller

net: phy: Move of_set_phy_eee_broken to phy-core.c

2019-02-14T00:17:53+00:00

Since of_set_phy_supported was moved to phy-core.c, we can also move
of_set_phy_eee_broken to the same location, so that we have all OF
functions in the same place.

This patch doesn't intend to introduce any change in behaviour.

Signed-off-by: Maxime Chevallier 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: Mask-out non-compatible modes when setting the max-speed

2019-02-14T00:17:53+00:00

When setting a PHY's max speed using either the max-speed DT property
or ethtool, we should mask-out all non-compatible modes according to the
settings table, instead of just the 10/100BASET modes.

Signed-off-by: Maxime Chevallier 
Suggested-by: Russell King 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: simplify genphy_config_eee_advert

2019-02-12T17:40:36+00:00

Use new function phy_modify_mmd_changed(), the result speaks for itself.

Signed-off-by: Heiner Kallweit 
Signed-off-by: David S. Miller

net: phy: use phy_modify_changed in genphy_config_advert

2019-02-10T20:53:18+00:00

Use phy_modify_changed() to simplify the code.

Signed-off-by: Heiner Kallweit 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: Add support for asking the PHY its abilities

2019-02-09T17:32:04+00:00

Add support for runtime determination of what the PHY supports, by
adding a new function to the phy driver. The get_features call should
set the phydev->supported member with the features the PHY supports.
It is only called if phydrv->features is NULL.

This requires minor changes to pause. The PHY driver should not set
pause abilities, except for when it has odd cause capabilities, e.g.
pause cannot be disabled. With this change, phydev->supported already
contains the drivers abilities, including pause. So rather than
considering phydrv->features, look at the phydev->supported, and
enable pause if neither of the pause bits are already set.

Signed-off-by: Andrew Lunn 
[hkallweit1@gmail.com: fixed small checkpatch complaint in one comment]
Signed-off-by: Heiner Kallweit 
Signed-off-by: David S. Miller