linux-stable.git/drivers/net/phy/phy.c, branch v5.13.2

net: phy: genphy_loopback: add link speed configuration

2021-04-20T23:08:02+00:00

In case of loopback, in most cases we need to disable autoneg support
and force some speed configuration. Otherwise, depending on currently
active auto negotiated link speed, the loopback may or may not work.

This patch was tested with following PHYs: TJA1102, KSZ8081, KSZ9031,
AT8035, AR9331.

Signed-off-by: Oleksij Rempel 
Signed-off-by: David S. Miller

net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-03-01T21:16:16+00:00

If phy uses generic driver and autoneg is on, enter command
"ethtool -s eth0 speed 50" will not change phy speed actually, but
command "ethtool eth0" shows speed is 50Mb/s because phydev->speed
has been set to 50 and no update later.

And duplex setting has same problem too.

However, if autoneg is on, phy only changes speed and duplex according to
phydev->advertising, but not phydev->speed and phydev->duplex. So in this
case, phydev->speed and phydev->duplex don't need to be set in function
phy_ethtool_ksettings_set() if autoneg is on.

Fixes: 51e2a3846eab ("PHY: Avoid unnecessary aneg restarts")
Signed-off-by: Guangbin Huang 
Signed-off-by: Huazhong Tan 
Signed-off-by: David S. Miller

net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT

2021-02-15T23:20:49+00:00

Some internal PHY's have their events like link change reported by the
MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario.
I'm not too happy with this name. We don't ignore interrupts, typically
there is no interrupt exposed at a PHY level. So let's rename it to
PHY_MAC_INTERRUPT. This is in line with phy_mac_interrupt(), which is
called from the MAC interrupt handler to handle PHY events.

Signed-off-by: Heiner Kallweit 
Reviewed-by: Andrew Lunn 
Acked-by: Florian Fainelli 
Reviewed-by: Russell King 
Signed-off-by: David S. Miller

net: phy: introduce phydev->port

2021-02-11T21:09:58+00:00

At the moment, PORT_MII is reported in the ethtool ops. This is odd
because it is an interface between the MAC and the PHY and no external
port. Some network card drivers will overwrite the port to twisted pair
or fiber, though. Even worse, the MDI/MDIX setting is only used by
ethtool if the port is twisted pair.

Set the port to PORT_TP by default because most PHY drivers are copper
ones. If there is fibre support and it is enabled, the PHY driver will
set it to PORT_FIBRE.

This will change reporting PORT_MII to either PORT_TP or PORT_FIBRE;
except for the genphy fallback driver.

Suggested-by: Andrew Lunn 
Signed-off-by: Michael Walle 
Reviewed-by: Florian Fainelli 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: replace mutex_is_locked with lockdep_assert_held in phylib

2021-01-07T22:53:07+00:00

Switch to lockdep_assert_held(_once), similar to what is being done
in other subsystems. One advantage is that there's zero runtime
overhead if lockdep support isn't enabled.

Signed-off-by: Heiner Kallweit 
Reviewed-by: Andrew Lunn 
Link: https://lore.kernel.org/r/ccc40b9d-8ee0-43a1-5009-2cc95ca79c85@gmail.com
Signed-off-by: Jakub Kicinski

net: phy: remove the .did_interrupt() and .ack_interrupt() callback

2020-11-25T19:18:38+00:00

Now that all the PHY drivers have been migrated to directly implement
the generic .handle_interrupt() callback for a seamless support of
shared IRQs and all the .config_inter() implementations clear any
pending interrupts, we can safely remove the two callbacks.

With this patch, phylib has a proper support for shared IRQs (and not
just for multi-PHY devices. A PHY driver must implement both the
.handle_interrupt() and .config_intr() callbacks for the IRQs to be
actually used.

Signed-off-by: Ioana Ciornei 
Signed-off-by: Jakub Kicinski

net: phy: fix kernel-doc markups

2020-11-17T22:15:03+00:00

Some functions have different names between their prototypes
and the kernel-doc markup.

Reviewed-by: Andrew Lunn 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Jakub Kicinski

net: phy: export phy_error and phy_trigger_machine

2020-11-06T00:31:59+00:00

These functions are currently used by phy_interrupt() to either signal
an error condition or to trigger the link state machine. In an attempt
to actually support shared PHY IRQs, export these two functions so that
the actual PHY drivers can use them.

Cc: Alexandru Ardelean 
Cc: Andre Edich 
Cc: Antoine Tenart 
Cc: Baruch Siach 
Cc: Christophe Leroy 
Cc: Dan Murphy 
Cc: Divya Koppera 
Cc: Florian Fainelli 
Cc: Hauke Mehrtens 
Cc: Heiner Kallweit 
Cc: Jerome Brunet 
Cc: Kavya Sree Kotagiri 
Cc: Linus Walleij 
Cc: Marco Felsch 
Cc: Marek Vasut 
Cc: Martin Blumenstingl 
Cc: Mathias Kresin 
Cc: Maxim Kochetkov 
Cc: Michael Walle 
Cc: Neil Armstrong 
Cc: Nisar Sayed 
Cc: Oleksij Rempel 
Cc: Philippe Schenker 
Cc: Willy Liu 
Cc: Yuiko Oshino 
Signed-off-by: Ioana Ciornei 
Signed-off-by: Jakub Kicinski

net: phy: Document core PHY structures

2020-09-24T01:02:49+00:00

Add kerneldoc for the core PHY data structures, a few inline functions
and exported functions which are not already documented.

v2
Typos
g/phy/PHY/s

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: Do not warn in phy_stop() on PHY_DOWN

2020-09-17T23:55:35+00:00

When phy_is_started() was added to catch incorrect PHY states,
phy_stop() would not be qualified against PHY_DOWN. It is possible to
reach that state when the PHY driver has been unbound and the network
device is then brought down.

Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
Signed-off-by: Florian Fainelli 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller