linux-stable.git/drivers/net/phy/phy.c, branch v5.11

net: phy: remove the .did_interrupt() and .ack_interrupt() callback

2020-11-25T19:18:38+00:00

Now that all the PHY drivers have been migrated to directly implement
the generic .handle_interrupt() callback for a seamless support of
shared IRQs and all the .config_inter() implementations clear any
pending interrupts, we can safely remove the two callbacks.

With this patch, phylib has a proper support for shared IRQs (and not
just for multi-PHY devices. A PHY driver must implement both the
.handle_interrupt() and .config_intr() callbacks for the IRQs to be
actually used.

Signed-off-by: Ioana Ciornei 
Signed-off-by: Jakub Kicinski

net: phy: fix kernel-doc markups

2020-11-17T22:15:03+00:00

Some functions have different names between their prototypes
and the kernel-doc markup.

Reviewed-by: Andrew Lunn 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Jakub Kicinski

net: phy: export phy_error and phy_trigger_machine

2020-11-06T00:31:59+00:00

These functions are currently used by phy_interrupt() to either signal
an error condition or to trigger the link state machine. In an attempt
to actually support shared PHY IRQs, export these two functions so that
the actual PHY drivers can use them.

Cc: Alexandru Ardelean 
Cc: Andre Edich 
Cc: Antoine Tenart 
Cc: Baruch Siach 
Cc: Christophe Leroy 
Cc: Dan Murphy 
Cc: Divya Koppera 
Cc: Florian Fainelli 
Cc: Hauke Mehrtens 
Cc: Heiner Kallweit 
Cc: Jerome Brunet 
Cc: Kavya Sree Kotagiri 
Cc: Linus Walleij 
Cc: Marco Felsch 
Cc: Marek Vasut 
Cc: Martin Blumenstingl 
Cc: Mathias Kresin 
Cc: Maxim Kochetkov 
Cc: Michael Walle 
Cc: Neil Armstrong 
Cc: Nisar Sayed 
Cc: Oleksij Rempel 
Cc: Philippe Schenker 
Cc: Willy Liu 
Cc: Yuiko Oshino 
Signed-off-by: Ioana Ciornei 
Signed-off-by: Jakub Kicinski

net: phy: Document core PHY structures

2020-09-24T01:02:49+00:00

Add kerneldoc for the core PHY data structures, a few inline functions
and exported functions which are not already documented.

v2
Typos
g/phy/PHY/s

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: Do not warn in phy_stop() on PHY_DOWN

2020-09-17T23:55:35+00:00

When phy_is_started() was added to catch incorrect PHY states,
phy_stop() would not be qualified against PHY_DOWN. It is possible to
reach that state when the PHY driver has been unbound and the network
device is then brought down.

Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
Signed-off-by: Florian Fainelli 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

net: phy: Uninline PHY ethtool statistics operations

2020-07-08T19:39:05+00:00

Now that we have moved the PHY ethtool statistics to be dynamically
registered, we no longer need to inline those for ethtool. This used to
be done to avoid cross symbol referencing and allow ethtool to be
decoupled from PHYLIB entirely.

Signed-off-by: Florian Fainelli 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: make phy_disable_interrupts() non-static

2020-06-24T21:52:49+00:00

We face an issue with rtl8211f, a pin is shared between INTB and PMEB,
and the PHY Register Accessible Interrupt is enabled by default, so
the INTB/PMEB pin is always active in polling mode case.

As Heiner pointed out "I was thinking about calling
phy_disable_interrupts() in phy_init_hw(), to have a defined init
state as we don't know in which state the PHY is if the PHY driver is
loaded. We shouldn't assume that it's the chip power-on defaults, BIOS
or boot loader could have changed this. Or in case of dual-boot
systems the other OS could leave the PHY in whatever state."

Make phy_disable_interrupts() non-static so that it could be used in
phy_init_hw() to have a defined init state.

Suggested-by: Heiner Kallweit 
Signed-off-by: Jisheng Zhang 
Signed-off-by: David S. Miller

net: ethtool: Allow PHY cable test TDR data to configured

2020-05-27T06:22:21+00:00

Allow the user to configure where on the cable the TDR data should be
retrieved, in terms of first and last sample, and the step between
samples. Also add the ability to ask for TDR data for just one pair.

If this configuration is not provided, it defaults to 1-150m at 1m
intervals for all pairs.

Signed-off-by: Andrew Lunn 

v3:
Move the TDR configuration into a structure
Add a range check on step
Use NL_SET_ERR_MSG_ATTR() when appropriate
Move TDR configuration into a nest
Document attributes in the request

Signed-off-by: David S. Miller

net: ethtool: Add generic parts of cable test TDR

2020-05-27T06:21:48+00:00

Add the generic parts of the code used to trigger a cable test and
return raw TDR data. Any PHY driver which support this must implement
the new driver op.

Signed-off-by: Andrew Lunn 

v2
Update nxp-tja11xx for API change.

Signed-off-by: David S. Miller