linux-stable.git/drivers/net/phy/phy.c, branch v4.10.2

net: phy: leds: Break dependency of phy.h on phy_led_triggers.h

2017-01-25T19:40:19+00:00

 includes , which is not really
needed.  Drop the include from , and add it to all users
that didn't include it explicitly.

Suggested-by: Andrew Lunn 
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: Avoid deadlock during phy_error()

2017-01-23T20:37:10+00:00

phy_error() is called in the PHY state machine workqueue context, and
calls phy_trigger_machine() which does a cancel_delayed_work_sync() of
the workqueue we execute from, causing a deadlock situation.

Augment phy_trigger_machine() machine with a sync boolean indicating
whether we should use cancel_*_sync() or just cancel_*_work().

Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
Reported-by: Russell King 
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

phy state machine: failsafe leave invalid RUNNING state

2017-01-09T20:37:44+00:00

While in RUNNING state, phy_state_machine() checks for link changes by
comparing phydev->link before and after calling phy_read_status().
This works as long as it is guaranteed that phydev->link is never
changed outside the phy_state_machine().

If in some setups this happens, it causes the state machine to miss
a link loss and remain RUNNING despite phydev->link being 0.

This has been observed running a dsa setup with a process continuously
polling the link states over ethtool each second (SNMPD RFC-1213
agent). Disconnecting the link on a phy followed by a ETHTOOL_GSET
causes dsa_slave_get_settings() / dsa_slave_get_link_ksettings() to
call phy_read_status() and with that modify the link status - and
with that bricking the phy state machine.

This patch adds a fail-safe check while in RUNNING, which causes to
move to CHANGELINK when the link is gone and we are still RUNNING.

Signed-off-by: Zefir Kurtisi 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: update the mdix_ctrl with correct value.

2016-12-01T16:26:47+00:00

Update the mdix and mdix_ctrl with corresponding ethtool configuration
parameters.

Signed-off-by: Raju Lakkaraju 
Signed-off-by: David S. Miller

net: phy: add an option to disable EEE advertisement

2016-11-30T00:38:31+00:00

This patch adds an option to disable EEE advertisement in the generic PHY
by providing a mask of prohibited modes corresponding to the value found in
the MDIO_AN_EEE_ADV register.

On some platforms, PHY Low power idle seems to be causing issues, even
breaking the link some cases. The patch provides a convenient way for these
platforms to disable EEE advertisement and work around the issue.

Signed-off-by: Jerome Brunet 
Tested-by: Yegor Yefremov 
Tested-by: Andreas Färber 
Signed-off-by: David S. Miller

net: phy: Add phy_ethtool_nway_reset

2016-11-15T21:33:35+00:00

This function just calls into genphy_restart_aneg() to perform an
autonegotation restart.

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: expose phy_aneg_done API for use by drivers

2016-11-13T05:56:26+00:00

Make phy_aneg_done() available to drivers so that the result of the
auto-negotiation initiated by phy_start_aneg() can be determined.

Remove the local implementation of phy_aneg_done() from the Aeroflex
driver and use the phy library version.

Signed-off-by: Tom Lendacky 
Signed-off-by: David S. Miller

net: phy: leds: add support for led triggers on phy link state change

2016-10-18T15:56:31+00:00

Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a
set of led triggers for each instantiated PHY device. There is one LED
trigger per link-speed, per-phy.
The triggers are registered during phy_attach and unregistered during
phy_detach.

This allows for a user to configure their system to allow a set of LEDs
not controlled by the phy to represent link state changes on the phy.
LEDS controlled by the phy are unaffected.

For example, we have a board where some of the leds in the
RJ45 socket are controlled by the phy, but others are not. Using the
triggers provided by this patch the leds not controlled by the phy can
be configured to show the current speed of the ethernet connection. The
leds controlled by the phy are unaffected.

Signed-off-by: Josh Cartwright 
Signed-off-by: Nathan Sullivan 
Signed-off-by: Zach Brown 
Signed-off-by: David S. Miller

net: phy: Create phy_supported_speeds function which lists speeds currently supported by a phydevice

2016-10-18T15:56:31+00:00

phy_supported_speeds provides a means to get a list of all the speeds a
phy device currently supports.

Signed-off-by: Zach Brown 
Signed-off-by: David S. Miller

net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-18T15:56:30+00:00

During phy state machine state transitions some set of actions should
occur whenever the link state changes. These actions should be
encapsulated into a single function

This patch adds the phy_adjust_link function, which is called whenever
phydev->adjust_link would have been called before. Actions that should
occur whenever the phy link is adjusted can now be added to the
phy_adjust_link function.

Signed-off-by: Zach Brown 
Signed-off-by: David S. Miller