linux-stable.git/drivers/net/phy/phy.c, branch linux-2.6.33.y

phylib: Move workqueue initialization to a proper place

2010-01-19T09:59:02+00:00

commit 541cd3ee00a4fe975b22fac6a3bc846bacef37f7 ("phylib: Fix deadlock
on resume") caused TI DaVinci EMAC ethernet driver to oops upon resume:

 PM: resume of devices complete after 237.098 msecs
 Restarting tasks ... done.
 kernel BUG at kernel/workqueue.c:354!
 Unable to handle kernel NULL pointer dereference at virtual address 00000000
 [...]
 Backtrace:
 [] (__bug+0x0/0x2c) from [] (queue_delayed_work_on+0x74/0xf8)
 [] (queue_delayed_work_on+0x0/0xf8) from [] (queue_delayed_work+0x2c/0x30)

The oops pops up because TI DaVinci EMAC driver detaches PHY on
suspend and attaches it back on resume. Attaching makes phylib call
phy_start_machine() that initializes a workqueue. On the other hand,
PHY's resume routine will call phy_start_machine() again, and that
will cause the oops since we just destroyed the already scheduled
workqueue.

This patch fixes the issue by moving workqueue initialization to
phy_device_create().

p.s. We don't see this oops with ucc_geth and gianfar drivers because
they perform a fine-grained suspend, i.e. they just stop the PHYs
without detaching.

Reported-by: Sekhar Nori 
Signed-off-by: Anton Vorontsov 
Tested-by: Sekhar Nori 
Signed-off-by: David S. Miller

drivers/net: Move && and || to end of previous line

2009-12-03T21:18:01+00:00

Only files where David Miller is the primary git-signer.
wireless, wimax, ixgbe, etc are not modified.

Compile tested x86 allyesconfig only
Not all files compiled (not x86 compatible)

Added a few > 80 column lines, which I ignored.
Existing checkpatch complaints ignored.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations

2009-09-04T03:02:11+00:00

dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

phylib: fixes for PHY_RESUMING state changes

2009-07-02T20:16:55+00:00

The PHY_HALTED state disables phydev->link, but the link will not be
updated upon entering PHY_RESUMING.  Add a call to phy_read_status() to
update the link before entering PHY_RUNNING.  If the link is not up at
this point, enter the PHY_NOLINK state instead.

Also, when transitioning from PHY_RESUMING to PHY_RUNNING, calls to
netif_carrier_on() and phydev->adjust_link() are missing.  Add the calls
similar to the other transitions to PHY_RUNNING.

Signed-off-by: Wade Farnsworth 
Acked-by: Andy Fleming 
Signed-off-by: David S. Miller

phylib: Fix delay argument of schedule_delayed_work

2009-04-16T10:13:07+00:00

The commit a390d1f3 ("phylib: convert state_queue work to
delayed_work") missed converting 'expires' value to 'delay' value.

Signed-off-by: Atsushi Nemoto 
Acked-by: Marcin Slusarz 
Signed-off-by: David S. Miller

phylib: Allow early-out in phy_change

2009-04-13T21:51:23+00:00

Marvell 88E1121R Dual PHY device can be hardware-configured
to use shared interrupt pin for both PHY ports. For such
PHY configurations using shared PHY interrupt phy_interrupt()
handler will also schedule a work for PHY port which didn't
cause an interrupt.

This patch adds a possibility for PHY drivers to provide
did_interrupt() function which reports if the PHY (or a PHY
port in a multi-PHY device) generated an interrupt. This
function is called in phy_change() as phy_change() shouldn't
proceed if it is invoked for a PHY which didn't cause an
interrupt. So check for interrupt originator in phy_change()
to allow early-out.

Signed-off-by: Anatolij Gustschin 
Signed-off-by: David S. Miller

workqueue: add to_delayed_work() helper function

2009-04-03T02:04:50+00:00

It is a fairly common operation to have a pointer to a work and to need a
pointer to the delayed work it is contained in.  In particular, all
delayed works which want to rearm themselves will have to do that.  So it
would seem fair to offer a helper function for this operation.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Jean Delvare 
Acked-by: Ingo Molnar 
Cc: "David S. Miller" 
Cc: Herbert Xu 
Cc: Benjamin Herrenschmidt 
Cc: Martin Schwidefsky 
Cc: Greg KH 
Cc: Pekka Enberg 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

phylib: convert state_queue work to delayed_work

2009-03-13T22:41:19+00:00

It closes a race in phy_stop_machine when reprogramming of phy_timer
(from phy_state_machine) happens between del_timer_sync and cancel_work_sync.

Without this change it could lead to crash if phy_device would be freed after
phy_stop_machine (timer would fire and schedule freed work).

Signed-off-by: Marcin Slusarz 
Acked-by: Jean Delvare 
Signed-off-by: David S. Miller

net: struct device - replace bus_id with dev_name(), dev_set_name()

2008-11-10T21:55:14+00:00

Acked-by: Marcel Holtmann 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Kay Sievers 
Signed-off-by: David S. Miller

phylib: add mdiobus_{read,write}

2008-10-08T23:38:41+00:00

Add mdiobus_{read,write} routines to allow direct reading/writing
of registers on an mii bus without having to go through the PHY
abstraction, and make phy_{read,write} use these primitives.

Signed-off-by: Lennert Buytenhek 
Signed-off-by: David S. Miller