linux-stable.git/drivers/net/phy/mscc, branch v5.9

net: phy: mscc: Fix a couple of spelling mistakes "spcified" -> "specified"

2020-08-20T18:10:12+00:00

There are a couple of spelling mistakes in comment text. Fix these.

Signed-off-by: Kaige Li 
Signed-off-by: David S. Miller

net: phy: mscc: fix ptr_ret.cocci warnings

2020-07-09T20:09:51+00:00

drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support")
CC: Antoine Tenart 
Signed-off-by: kernel test robot 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2020-06-26T02:29:51+00:00

Minor overlapping changes in xfrm_device.c, between the double
ESP trailing bug fix setting the XFRM_INIT flag and the changes
in net-next preparing for bonding encryption support.

Signed-off-by: David S. Miller

net: phy: mscc: improve vsc8514/8584_config_init consistency

2020-06-25T23:22:11+00:00

All PHY read and write return values are checked for errors in
vsc8514_config_init and vsc8584_config_init, except for one. Fix this.

Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: remove useless page configuration in the config init

2020-06-25T23:22:11+00:00

In the middle of vsc8584_config_init and vsc8514_config_init, the page
is set to 'standard'. This is the default value, and the page isn't set
to another value before. Those pages configuration can be safely
removed.

Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: restore the base page in vsc8514/8584_config_init

2020-06-25T23:22:11+00:00

In the vsc8584_config_init and vsc8514_config_init, the base page is set
to 'GPIO', configuration is done, and the page is never explicitly
restored to the standard page. No bug was triggered as it turns out
helpers called in those config_init functions do modify the base page,
and set it back to standard. But that is dangerous and any modification
to those functions would introduce bugs. This patch fixes this, to
improve maintenance, by restoring the base page to 'standard' once
'GPIO' accesses are completed.

Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: do not access the MDIO bus lock directly

2020-06-25T23:22:11+00:00

This patch improves the MSCC driver by using the provided
phy_lock_mdio_bus and phy_unlock_mdio_bus helpers instead of locking and
unlocking the MDIO bus lock directly. The patch is only cosmetic but
should improve maintenance and consistency.

Signed-off-by: Antoine Tenart 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: mscc: ptp: fix a typo in a comment

2020-06-25T23:22:11+00:00

This patch fixes a typo in a comment, s/Ths/This/. The patch is cosmetic
only.

Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: ptp: fix a smatch error

2020-06-25T23:22:11+00:00

The following error was reported by smatch:
vsc85xx_ts_read_csr() error: uninitialized symbol 'blk_hw'.

In practice this is very unlikely, as all the block identifiers given to
this functions are handled and described in an enum. The smatch error is
fixed by doing what is already done in vsc85xx_ts_write_csr: using the
"PROCESSOR" block by default.

Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: fix a possible double unlock

2020-06-25T23:22:11+00:00

On vsc8584_ptp_init failure we jump to the 'err' label, which unlocks
the MDIO bus lock. But vsc8584_ptp_init isn't called with the MDIO bus
lock taken, which could result in a double unlock. Fix this.

Fixes: ab2bf9339357 ("net: phy: mscc: 1588 block initialization")
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller