linux-stable.git/drivers/net/phy/mscc, branch v5.8

net: phy: mscc: avoid skcipher API for single block AES encryption

2020-06-25T19:16:14+00:00

The skcipher API dynamically instantiates the transformation object
on request that implements the requested algorithm optimally on the
given platform. This notion of optimality only matters for cases like
bulk network or disk encryption, where performance can be a bottleneck,
or in cases where the algorithm itself is not known at compile time.

In the mscc case, we are dealing with AES encryption of a single
block, and so neither concern applies, and we are better off using
the AES library interface, which is lightweight and safe for this
kind of use.

Note that the scatterlist API does not permit references to buffers
that are located on the stack, so the existing code is incorrect in
any case, but avoiding the skcipher and scatterlist APIs entirely is
the most straight-forward approach to fixing this.

Cc: Antoine Tenart 
Cc: Andrew Lunn 
Cc: Florian Fainelli 
Cc: Heiner Kallweit 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Fixes: 28c5107aa904e ("net: phy: mscc: macsec support")
Reviewed-by: Eric Biggers 
Signed-off-by: Ard Biesheuvel 
Tested-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05T20:16:13+00:00

When converting the MSCC PHY driver to shared PHY packages, the Serdes
configuration in vsc8584_config_init was modified to use 'base_addr'
instead of 'base' as the port number. But 'base_addr' isn't equal to
'addr' for all PHYs inside the package, which leads to the Serdes still
being enabled on those ports. This patch fixes it.

Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared")
Signed-off-by: Antoine Tenart 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: mscc: Fix OF_MDIO config check

2020-06-05T20:15:22+00:00

When CONFIG_OF_MDIO is set to be a module the code block is not
compiled. Use the IS_ENABLED macro that checks for both built in as
well as module.

Fixes: 4f58e6dceb0e4 ("net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.")
Signed-off-by: Dan Murphy 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: mscc: fix PHYs using the vsc8574_probe

2020-05-29T19:44:27+00:00

PHYs using the vsc8574_probe fail to be initialized and their
config_init return -EIO leading to errors like:
"could not attach PHY: -5".

This is because when the conversion of the MSCC PHY driver to use the
shared PHY package helpers was done, the base address retrieval and the
base PHY read and write helpers in the driver were modified. In
particular, the base address retrieval logic was moved from the
config_init to the probe. But the vsc8574_probe was forgotten. This
patch fixes it.

Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared")
Signed-off-by: Antoine Tenart 
Reviewed-by: Michael Walle 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2020-05-24T20:47:27+00:00

The MSCC bug fix in 'net' had to be slightly adjusted because the
register accesses are done slightly differently in net-next.

Signed-off-by: David S. Miller

net: phy: mscc: fix initialization of the MACsec protocol mode

2020-05-23T23:31:53+00:00

At the very end of the MACsec block initialization in the MSCC PHY
driver, the MACsec "protocol mode" is set. This setting should be set
based on the PHY id within the package, as the bank used to access the
register used depends on this. This was not done correctly, and only the
first bank was used leading to the two upper PHYs being unstable when
using the VSC8584. This patch fixes it.

Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization")
Signed-off-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: use phy_package_shared

2020-05-06T21:53:29+00:00

Use the new phy_package_shared common storage to ease the package
initialization and to access the global registers.

Signed-off-by: Michael Walle 
Tested-by: Vladimir Oltean 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: mscc: use mdiobus_get_phy()

2020-04-20T19:07:22+00:00

Don't use internal knowledge of the mdio bus core, instead use
mdiobus_get_phy() which does the same thing.

Signed-off-by: Michael Walle 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: mscc: consolidate a common RGMII delay implementation

2020-03-24T23:36:37+00:00

It looks like the VSC8584 PHY driver is rolling its own RGMII delay
configuration code, despite the fact that the logic is mostly the same.

In fact only the register layout and position for the RGMII controls has
changed. So we need to adapt and parameterize the PHY-dependent bit
fields when calling the new generic function.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Andrew Lunn 
Tested-by: Antoine Tenart 
Signed-off-by: David S. Miller

net: phy: mscc: add support for VSC8502

2020-03-24T03:52:27+00:00

This is a dual copper PHY with support for MII/GMII/RGMII on MAC side,
as well as a bunch of other features such as SyncE and Ring Resiliency.

I haven't tested interrupts and WoL, but I am confident that they work
since support is already present in the driver and the register map is
no different for this PHY.

PHY statistics work, PHY tunables appear to work, suspend/resume works.

Signed-off-by: Wes Li 
Signed-off-by: Vladimir Oltean 
Signed-off-by: David S. Miller