linux-stable.git/drivers/net/phy/broadcom.c, branch linux-6.14.y

net: phy: broadcom: Correct BCM5221 PHY model detection

2025-04-10T12:44:36+00:00

[ Upstream commit 4f1eaabb4b66a1f7473f584e14e15b2ac19dfaf3 ]

Correct detect condition is applied to the entire 5221 family of PHYs.

Fixes: 3abbd0699b67 ("net: phy: broadcom: add support for BCM5221 phy")
Signed-off-by: Jim Liu 
Reviewed-by: Michal Swiatkowski 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: phy: Constify struct mdio_device_id

2025-01-14T23:01:32+00:00

'struct mdio_device_id' is not modified in these drivers.

Constifying these structures moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  27014	  12792	      0	  39806	   9b7e	drivers/net/phy/broadcom.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  27206	  12600	      0	  39806	   9b7e	drivers/net/phy/broadcom.o

Signed-off-by: Christophe JAILLET 
Reviewed-by: Andrew Lunn 
Link: https://patch.msgid.link/403c381b7d9156b67ad68ffc44b8eee70c5e86a9.1736691226.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski

net: phy: bcm-phy-lib: Implement BroadR-Reach link modes

2024-07-15T03:38:35+00:00

Implement single-pair BroadR-Reach modes on bcm5481x PHY by Broadcom.
Create set of functions alternative to IEEE 802.3 to handle
configuration of these modes on compatible Broadcom PHYs.
There is only subset of capabilities supported because of limited
collection of hardware available for the development.
For BroadR-Reach capable PHYs, the LRE (Long Reach Ethernet)
alternative register set is handled. Only bcm54811 PHY is verified,
for bcm54810, there is some support possible but untested. There
is no auto-negotiation of the link parameters (called LDS in the
Broadcom terminology, Long-Distance Signaling) for bcm54811.
It should be possible to enable LDS for bcm54810.

Signed-off-by: Kamil Horák (2N) 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Link: https://patch.msgid.link/20240712150709.3134474-5-kamilh@axis.com
Signed-off-by: Jakub Kicinski

net: phy: provide whether link has changed in c37_read_status

2024-02-10T15:36:19+00:00

Some PHY driver might require additional regs call after
genphy_c37_read_status() is called.

Expand genphy_c37_read_status to provide a bool wheather the link has
changed or not to permit PHY driver to skip additional regs call if
nothing has changed.

Every user of genphy_c37_read_status() is updated with the new
additional bool.

Signed-off-by: Christian Marangi 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: phy: broadcom: Wire suspend/resume for BCM54612E

2023-11-17T02:45:47+00:00

The BCM54612E ethernet PHY supports IDDQ-SR.
Therefore wire-up the suspend and resume callbacks
to point to bcm54xx_suspend() and bcm54xx_resume().

Signed-off-by: Marco von Rosenberg 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: broadcom: add support for BCM5221 phy

2023-10-06T23:01:27+00:00

This patch adds the BCM5221 PHY support by reusing brcm_fet_*()
callbacks and adding quirks for BCM5221 when needed.

Cc: Jim Reinhart 
Cc: James Autry 
Cc: Matthew Maron 
Signed-off-by: Giulio Benetti 
Reviewed-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20231005182915.153815-1-giulio.benetti@benettiengineering.com
Signed-off-by: Jakub Kicinski

net: phy: broadcom: stub c45 read/write for 54810

2023-08-16T01:53:43+00:00

The 54810 does not support c45. The mmd_phy_indirect accesses return
arbirtary values leading to odd behavior like saying it supports EEE
when it doesn't. We also see that reading/writing these non-existent
MMD registers leads to phy instability in some cases.

Fixes: b14995ac2527 ("net: phy: broadcom: Add BCM54810 PHY entry")
Signed-off-by: Justin Chen 
Reviewed-by: Florian Fainelli 
Link: https://lore.kernel.org/r/1691901708-28650-1-git-send-email-justin.chen@broadcom.com
Signed-off-by: Jakub Kicinski

net: phy: broadcom: drop brcm_phy_setbits() and use phy_set_bits() instead

2023-06-24T22:05:40+00:00

Linux provides phy_set_bits() helper so let's drop brcm_phy_setbits() and
use phy_set_bits() in its place.

Signed-off-by: Giulio Benetti 
Reviewed-by: Simon Horman 
Reviewed-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20230622184721.24368-1-giulio.benetti@benettiengineering.com
Signed-off-by: Jakub Kicinski

net: phy: broadcom: Add support for setting LED brightness

2023-06-09T09:38:43+00:00

Broadcom PHYs have two LEDs selector registers which allow us to control
the LED assignment, including how to turn them on/off.

Signed-off-by: Florian Fainelli 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

net: phy: broadcom: Rename LED registers

2023-06-09T09:38:43+00:00

These registers are common to most PHYs and are not specific to the
BCM5482, renamed the constants accordingly, no functional change.

Signed-off-by: Florian Fainelli 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller