linux-stable.git/drivers/net/netdevsim/dev.c, branch linux-5.10.y

netdevsim: fix uninitialized data in nsim_dev_trap_fa_cookie_write()

2023-07-27T06:44:24+00:00

[ Upstream commit f72207a5c0dbaaf6921cf9a6c0d2fd0bc249ea78 ]

The simple_write_to_buffer() function is designed to handle partial
writes.  It returns negatives on error, otherwise it returns the number
of bytes that were able to be copied.  This code doesn't check the
return properly.  We only know that the first byte is written, the rest
of the buffer might be uninitialized.

There is no need to use the simple_write_to_buffer() function.
Partial writes are prohibited by the "if (*ppos != 0)" check at the
start of the function.  Just use memdup_user() and copy the whole
buffer.

Fixes: d3cbb907ae57 ("netdevsim: add ACL trap reporting cookie as a metadata")
Signed-off-by: Dan Carpenter 
Reviewed-by: Pavan Chebbi 
Reviewed-by: Ido Schimmel 
Link: https://lore.kernel.org/r/7c1f950b-3a7d-4252-82a6-876e53078ef7@moroto.mountain
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

netdevsim: dev: Initialize FIB module after debugfs

2021-04-07T13:00:07+00:00

[ Upstream commit f57ab5b75f7193e194c83616cd104f41c8350f68 ]

Initialize the dummy FIB offload module after debugfs, so that the FIB
module could create its own directory there.

Signed-off-by: Amit Cohen 
Signed-off-by: Ido Schimmel 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

netdevsim: set .owner to THIS_MODULE

2020-11-17T22:08:59+00:00

If THIS_MODULE is not set, the module would be removed while debugfs is
being used.
It eventually makes kernel panic.

Fixes: 82c93a87bf8b ("netdevsim: implement couple of testing devlink health reporters")
Fixes: 424be63ad831 ("netdevsim: add UDP tunnel port offload support")
Fixes: 4418f862d675 ("netdevsim: implement support for devlink region and snapshots")
Fixes: d3cbb907ae57 ("netdevsim: add ACL trap reporting cookie as a metadata")
Signed-off-by: Taehee Yoo 
Link: https://lore.kernel.org/r/20201115103041.30701-1-ap420073@gmail.com
Signed-off-by: Jakub Kicinski

devlink: Add devlink reload limit option

2020-10-09T19:06:52+00:00

Add reload limit to demand restrictions on reload actions.
Reload limits supported:
no_reset: No reset allowed, no down time allowed, no link flap and no
          configuration is lost.

By default reload limit is unspecified and so no constraints on reload
actions are required.

Some combinations of action and limit are invalid. For example, driver
can not reinitialize its entities without any downtime.

The no_reset reload limit will have usecase in this patchset to
implement restricted fw_activate on mlx5.

Have the uapi parameter of reload limit ready for future support of
multiselection.

Signed-off-by: Moshe Shemesh 
Reviewed-by: Jiri Pirko 
Signed-off-by: Jakub Kicinski

devlink: Add reload action option to devlink reload command

2020-10-09T19:06:52+00:00

Add devlink reload action to allow the user to request a specific reload
action. The action parameter is optional, if not specified then devlink
driver re-init action is used (backward compatible).
Note that when required to do firmware activation some drivers may need
to reload the driver. On the other hand some drivers may need to reset
the firmware to reinitialize the driver entities. Therefore, the devlink
reload command returns the actions which were actually performed.
Reload actions supported are:
driver_reinit: driver entities re-initialization, applying devlink-param
               and devlink-resource values.
fw_activate: firmware activate.

command examples:
$devlink dev reload pci/0000:82:00.0 action driver_reinit
reload_actions_performed:
  driver_reinit

$devlink dev reload pci/0000:82:00.0 action fw_activate
reload_actions_performed:
  driver_reinit fw_activate

Signed-off-by: Moshe Shemesh 
Reviewed-by: Jakub Kicinski 
Reviewed-by: Jacob Keller 
Reviewed-by: Jiri Pirko 
Signed-off-by: Jakub Kicinski

netdevsim: add support for flash_update overwrite mask

2020-09-26T00:20:57+00:00

The devlink interface recently gained support for a new "overwrite mask"
parameter that allows specifying how various sub-sections of a flash
component are modified when updating.

Add support for this to netdevsim, to enable easily testing the
interface. Make the allowed overwrite mask values controllable via
a debugfs parameter. This enables testing a flow where the driver
rejects an unsupportable overwrite mask.

Signed-off-by: Jacob Keller 
Reviewed-by: Jakub Kicinski 
Signed-off-by: David S. Miller

devlink: convert flash_update to use params structure

2020-09-26T00:20:57+00:00

The devlink core recently gained support for checking whether the driver
supports a flash_update parameter, via `supported_flash_update_params`.
However, parameters are specified as function arguments. Adding a new
parameter still requires modifying the signature of the .flash_update
callback in all drivers.

Convert the .flash_update function to take a new `struct
devlink_flash_update_params` instead. By using this structure, and the
`supported_flash_update_params` bit field, a new parameter to
flash_update can be added without requiring modification to existing
drivers.

As before, all parameters except file_name will require driver opt-in.
Because file_name is a necessary field to for the flash_update to make
sense, no "SUPPORTED" bitflag is provided and it is always considered
valid. All future additional parameters will require a new bit in the
supported_flash_update_params bitfield.

Signed-off-by: Jacob Keller 
Reviewed-by: Jakub Kicinski 
Cc: Jiri Pirko 
Cc: Jakub Kicinski 
Cc: Jonathan Corbet 
Cc: Michael Chan 
Cc: Bin Luo 
Cc: Saeed Mahameed 
Cc: Leon Romanovsky 
Cc: Ido Schimmel 
Cc: Danielle Ratson 
Signed-off-by: David S. Miller

devlink: check flash_update parameter support in net core

2020-09-26T00:20:57+00:00

When implementing .flash_update, drivers which do not support
per-component update are manually checking the component parameter to
verify that it is NULL. Without this check, the driver might accept an
update request with a component specified even though it will not honor
such a request.

Instead of having each driver check this, move the logic into
net/core/devlink.c, and use a new `supported_flash_update_params` field
in the devlink_ops. Drivers which will support per-component update must
now specify this by setting DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT in
the supported_flash_update_params in their devlink_ops.

This helps ensure that drivers do not forget to check for a NULL
component if they do not support per-component update. This also enables
a slightly better error message by enabling the core stack to set the
netlink bad attribute message to indicate precisely the unsupported
attribute in the message.

Going forward, any new additional parameter to flash update will require
a bit in the supported_flash_update_params bitfield.

Signed-off-by: Jacob Keller 
Reviewed-by: Jakub Kicinski 
Cc: Jiri Pirko 
Cc: Jonathan Corbet 
Cc: Michael Chan 
Cc: Bin Luo 
Cc: Saeed Mahameed 
Cc: Leon Romanovsky 
Cc: Ido Schimmel 
Cc: Danielle Ratson 
Cc: Shannon Nelson 
Signed-off-by: David S. Miller

net: devlink: region: Pass the region ops to the snapshot function

2020-09-19T01:17:45+00:00

Pass the region to be snapshotted to the function performing the
snapshot. This allows one function to operate on numerous regions.

v4:
Add missing kerneldoc for ICE

Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

netdevsim: devlink flash timeout message

2020-09-18T20:54:23+00:00

Add a simple devlink flash timeout message to exercise
the message mechanism.

Signed-off-by: Shannon Nelson 
Signed-off-by: David S. Miller