linux-stable.git/drivers/net/netdevsim/bpf.c, branch linux-5.4.y

netdevsim: Avoid allocation warnings triggered from user space

2022-08-25T09:17:49+00:00

[ Upstream commit d0b80a9edb1a029ff913e81b47540e57ad034329 ]

We need to suppress warnings from sily map sizes. Also switch
from GFP_USER to GFP_KERNEL_ACCOUNT, I'm pretty sure I misunderstood
the flags when writing this code.

Fixes: 395cacb5f1a0 ("netdevsim: bpf: support fake map offload")
Reported-by: syzbot+ad24705d3fd6463b18c6@syzkaller.appspotmail.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20220726213605.154204-1-kuba@kernel.org
Signed-off-by: Sasha Levin

netdevsim: Zero-initialize memory for new map's value in function nsim_bpf_map_alloc

2021-12-22T08:29:38+00:00

[ Upstream commit 481221775d53d6215a6e5e9ce1cce6d2b4ab9a46 ]

Zero-initialize memory for new map's value in function nsim_bpf_map_alloc
since it may cause a potential kernel information leak issue, as follows:
1. nsim_bpf_map_alloc calls nsim_map_alloc_elem to allocate elements for
a new map.
2. nsim_map_alloc_elem uses kmalloc to allocate map's value, but doesn't
zero it.
3. A user application can use IOCTL BPF_MAP_LOOKUP_ELEM to get specific
element's information in the map.
4. The kernel function map_lookup_elem will call bpf_map_copy_value to get
the information allocated at step-2, then use copy_to_user to copy to the
user buffer.
This can only leak information for an array map.

Fixes: 395cacb5f1a0 ("netdevsim: bpf: support fake map offload")
Suggested-by: Jakub Kicinski 
Acked-by: Jakub Kicinski 
Signed-off-by: Haimin Zhang 
Link: https://lore.kernel.org/r/20211215111530.72103-1-tcs.kernel@gmail.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

netdevsim: move netdev creation/destruction to dev probe

2019-04-26T05:52:03+00:00

Remove the existing way to create netdevsim over rtnetlink and move the
netdev creation/destruction to dev probe, so for every probed port,
a netdevsim-netdev instance is created.

Adjust selftests to work with new interface.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

netdevsim: merge sdev into dev

2019-04-26T05:52:02+00:00

As previously introduce dev which is mapped 1:1 to a bus device covers
the purpose of the original shared device, merge the sdev code into dev.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

netdevsim: move sdev-specific init/uninit code into separate functions

2019-04-12T23:49:54+00:00

In order to improve readability and prepare for future code changes,
move sdev specific init/uninit code into separate functions.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

netdevsim: make bpf_offload_dev_create() per-sdev instead of first ns

2019-04-12T23:49:54+00:00

offload dev is stored in sdev struct. However, first netdevsim instance
is used as a priv. Change this to be sdev to as it is shared among
multiple netdevsim instances.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

netdevsim: move sdev specific bpf debugfs files to sdev dir

2019-04-12T23:49:54+00:00

Some netdevsim bpf debugfs files are per-sdev, yet they are defined per
netdevsim instance. Move them under sdev directory.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

bpf: offload: add priv field for drivers

2019-02-12T16:07:09+00:00

Currently bpf_offload_dev does not have any priv pointer, forcing
the drivers to work backwards from the netdev in program metadata.
This is not great given programs are conceptually associated with
the offload device, and it means one or two unnecessary deferences.
Add a priv pointer to bpf_offload_dev.

Signed-off-by: Jakub Kicinski 
Reviewed-by: Quentin Monnet 
Signed-off-by: Daniel Borkmann

netdevsim: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-13T00:00:48+00:00

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li 
Acked-by: Jakub Kicinski 
Signed-off-by: David S. Miller

bpf: Remove unused variable in nsim_bpf

2018-11-17T01:51:13+00:00

Clang warns:

drivers/net/netdevsim/bpf.c:557:30: error: unused variable 'state'
[-Werror,-Wunused-variable]
        struct nsim_bpf_bound_prog *state;
                                    ^
1 error generated.

The declaration should have been removed in commit b07ade27e933 ("bpf:
pass translate() as a callback and remove its ndo_bpf subcommand").

Signed-off-by: Nathan Chancellor 
Acked-by: Jakub Kicinski 
Acked-by: Quentin Monnet 
Signed-off-by: Alexei Starovoitov