linux-stable.git/drivers/net/ipvlan/ipvlan_core.c, branch v4.3

ipvlan: use rcu_deference_bh() in ipvlan_queue_xmit()

2015-07-16T04:33:40+00:00

In tx path rcu_read_lock_bh() is held, so we need rcu_deference_bh().
This fixes the following warning:

 ===============================
 [ INFO: suspicious RCU usage. ]
 4.1.0-rc1+ #1007 Not tainted
 -------------------------------
 drivers/net/ipvlan/ipvlan.h:106 suspicious rcu_dereference_check() usage!

 other info that might help us debug this:

 rcu_scheduler_active = 1, debug_locks = 0
 1 lock held by dhclient/1076:
  #0:  (rcu_read_lock_bh){......}, at: [] rcu_lock_acquire+0x0/0x26

 stack backtrace:
 CPU: 2 PID: 1076 Comm: dhclient Not tainted 4.1.0-rc1+ #1007
 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
  0000000000000001 ffff8800d381bac8 ffffffff81a4154f 000000003c1a3c19
  ffff8800d4d0a690 ffff8800d381baf8 ffffffff810b849f ffff880117d41148
  ffff880117d40000 ffff880117d40068 0000000000000156 ffff8800d381bb18
 Call Trace:
  [] dump_stack+0x4c/0x65
  [] lockdep_rcu_suspicious+0x107/0x110
  [] ipvlan_port_get_rcu+0x47/0x4e
  [] ipvlan_queue_xmit+0x35/0x450
  [] ? rcu_read_unlock+0x3e/0x5f
  [] ? local_clock+0x19/0x22
  [] ? __lock_is_held+0x39/0x52
  [] ipvlan_start_xmit+0x1b/0x44
  [] dev_hard_start_xmit+0x2ae/0x467
  [] __dev_queue_xmit+0x50a/0x60c
  [] dev_queue_xmit_sk+0x13/0x15
  [] dev_queue_xmit+0x10/0x12
  [] packet_sendmsg+0xb6b/0xbdf
  [] ? mark_lock+0x2e/0x226
  [] ? sched_clock_cpu+0x9e/0xb7
  [] sock_sendmsg_nosec+0x12/0x1d
  [] sock_sendmsg+0x29/0x2e
  [] sock_write_iter+0x70/0x91
  [] __vfs_write+0x7e/0xa7
  [] vfs_write+0x92/0xe8
  [] SyS_write+0x47/0x7e
  [] system_call_fastpath+0x12/0x6f

Fixes: 2ad7bf363841 ("ipvlan: Initial check-in of the IPVLAN driver.")
Cc: Mahesh Bandewar 
Signed-off-by: Cong Wang 
Acked-by: Mahesh Bandewar 
Acked-by: Konstantin Khlebnikov 
Signed-off-by: David S. Miller

ipvlan: unhash addresses without synchronize_rcu

2015-07-16T04:33:39+00:00

All structures used in traffic forwarding are rcu-protected:
ipvl_addr, ipvl_dev and ipvl_port. Thus we can unhash addresses
without synchronization. We'll anyway hash it back into the same
bucket: in worst case lockless lookup will scan hash once again.

Signed-off-by: Konstantin Khlebnikov 
Signed-off-by: David S. Miller

ipvlan: Defer multicast / broadcast processing to a work-queue

2015-05-05T23:29:49+00:00

Processing multicast / broadcast in fast path is performance draining
and having more links means more cloning and bringing performance
down further.

Broadcast; in particular, need to be given to all the virtual links.
Earlier tricks of enabling broadcast bit for IPv4 only interfaces are not
really working since it fails autoconf. Which means enabling broadcast
for all the links if protocol specific hacks do not have to be added into
the driver.

This patch defers all (incoming as well as outgoing) multicast traffic to
a work-queue leaving only the unicast traffic in the fast-path. Now if we
need to apply any additional tricks to further reduce the impact of this
(multicast / broadcast) type of traffic, it can be implemented while
processing this work without affecting the fast-path.

Signed-off-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2015-04-02T20:16:53+00:00

Conflicts:
	drivers/net/usb/asix_common.c
	drivers/net/usb/sr9800.c
	drivers/net/usb/usbnet.c
	include/linux/usb/usbnet.h
	net/ipv4/tcp_ipv4.c
	net/ipv6/tcp_ipv6.c

The TCP conflicts were overlapping changes.  In 'net' we added a
READ_ONCE() to the socket cached RX route read, whilst in 'net-next'
Eric Dumazet touched the surrounding code dealing with how mini
sockets are handled.

With USB, it's a case of the same bug fix first going into net-next
and then I cherry picked it back into net.

Signed-off-by: David S. Miller

dev: introduce dev_get_iflink()

2015-04-02T18:04:59+00:00

The goal of this patch is to prepare the removal of the iflink field. It
introduces a new ndo function, which will be implemented by virtual interfaces.

There is no functional change into this patch. All readers of iflink field
now call dev_get_iflink().

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

ipvlan: fix check for IP addresses in control path

2015-03-31T17:28:33+00:00

When an ipvlan interface is down, its addresses are not on the hash list.
Fix checks for existence of addresses not to depend on the hash list, walk
through all interface addresses instead.

Signed-off-by: Jiri Benc 
Acked-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

ipvlan: protect against concurrent link removal

2015-03-31T17:28:33+00:00

Adding and removing to the 'ipvlans' list is already done using _rcu list
operations.

Signed-off-by: Jiri Benc 
Signed-off-by: David S. Miller

ipvlan: fix addr hash list corruption

2015-03-31T17:28:33+00:00

When ipvlan interface with IP addresses attached is brought down and then
deleted, the assigned addresses are deleted twice from the address hash
list, first on the interface down and second on the link deletion.
Similarly, when an address is added while the interface is down, it is added
second time once the interface is brought up.

When the interface is down, the addresses should be kept off the hash list
for performance reasons. Ensure this is true, which also fixes the double add
problem. To fix the double free, check whether the address is hashed before
removing it.

Reported-by: Dan Williams 
Signed-off-by: Jiri Benc 
Signed-off-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

net: mark some potential candidates __read_mostly

2015-01-31T01:58:39+00:00

They are all either written once or extremly rarely (e.g. from init
code), so we can move them to the .data..read_mostly section.

Signed-off-by: Daniel Borkmann 
Signed-off-by: David S. Miller

ipvlan: fix incorrect usage of IS_ERR() macro in IPv6 code path.

2015-01-25T08:24:19+00:00

The ip6_route_output() always returns a valid dst pointer unlike in IPv4
case. So the validation has to be different from the IPv4 path. Correcting
that error in this patch.

This was picked up by a static checker with a following warning -

   drivers/net/ipvlan/ipvlan_core.c:380 ipvlan_process_v6_outbound()
        warn: 'dst' isn't an ERR_PTR

Signed-off-by: Mahesh Bandewar 
Reported-by: Dan Carpenter 
Signed-off-by: David S. Miller