linux-stable.git/drivers/net/ipvlan/ipvlan.h, branch v4.7

ipvlan: misc changes

2016-02-22T03:43:24+00:00

1. scope correction for few functions that are used in single file.
2. Adjust variables that are used in fast-path to fit into single cacheline
3. Update rcv_frame() to skip shared check for frames coming over wire

Signed-off-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

ipvlan: mode is u16

2016-02-22T03:43:24+00:00

The mode argument was erronusly defined as u32 but it has always
been u16. Also use ipvlan_set_mode() helper to set the mode instead
of assigning directly. This should avoid future erronus assignments /
updates.

Signed-off-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

ipvlan: use rcu_deference_bh() in ipvlan_queue_xmit()

2015-07-16T04:33:40+00:00

In tx path rcu_read_lock_bh() is held, so we need rcu_deference_bh().
This fixes the following warning:

 ===============================
 [ INFO: suspicious RCU usage. ]
 4.1.0-rc1+ #1007 Not tainted
 -------------------------------
 drivers/net/ipvlan/ipvlan.h:106 suspicious rcu_dereference_check() usage!

 other info that might help us debug this:

 rcu_scheduler_active = 1, debug_locks = 0
 1 lock held by dhclient/1076:
  #0:  (rcu_read_lock_bh){......}, at: [] rcu_lock_acquire+0x0/0x26

 stack backtrace:
 CPU: 2 PID: 1076 Comm: dhclient Not tainted 4.1.0-rc1+ #1007
 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
  0000000000000001 ffff8800d381bac8 ffffffff81a4154f 000000003c1a3c19
  ffff8800d4d0a690 ffff8800d381baf8 ffffffff810b849f ffff880117d41148
  ffff880117d40000 ffff880117d40068 0000000000000156 ffff8800d381bb18
 Call Trace:
  [] dump_stack+0x4c/0x65
  [] lockdep_rcu_suspicious+0x107/0x110
  [] ipvlan_port_get_rcu+0x47/0x4e
  [] ipvlan_queue_xmit+0x35/0x450
  [] ? rcu_read_unlock+0x3e/0x5f
  [] ? local_clock+0x19/0x22
  [] ? __lock_is_held+0x39/0x52
  [] ipvlan_start_xmit+0x1b/0x44
  [] dev_hard_start_xmit+0x2ae/0x467
  [] __dev_queue_xmit+0x50a/0x60c
  [] dev_queue_xmit_sk+0x13/0x15
  [] dev_queue_xmit+0x10/0x12
  [] packet_sendmsg+0xb6b/0xbdf
  [] ? mark_lock+0x2e/0x226
  [] ? sched_clock_cpu+0x9e/0xb7
  [] sock_sendmsg_nosec+0x12/0x1d
  [] sock_sendmsg+0x29/0x2e
  [] sock_write_iter+0x70/0x91
  [] __vfs_write+0x7e/0xa7
  [] vfs_write+0x92/0xe8
  [] SyS_write+0x47/0x7e
  [] system_call_fastpath+0x12/0x6f

Fixes: 2ad7bf363841 ("ipvlan: Initial check-in of the IPVLAN driver.")
Cc: Mahesh Bandewar 
Signed-off-by: Cong Wang 
Acked-by: Mahesh Bandewar 
Acked-by: Konstantin Khlebnikov 
Signed-off-by: David S. Miller

ipvlan: unhash addresses without synchronize_rcu

2015-07-16T04:33:39+00:00

All structures used in traffic forwarding are rcu-protected:
ipvl_addr, ipvl_dev and ipvl_port. Thus we can unhash addresses
without synchronization. We'll anyway hash it back into the same
bucket: in worst case lockless lookup will scan hash once again.

Signed-off-by: Konstantin Khlebnikov 
Signed-off-by: David S. Miller

ipvlan: remove counters of ipv4 and ipv6 addresses

2015-07-16T04:33:39+00:00

They are unused after commit f631c44bbe15 ("ipvlan: Always set broadcast bit in
multicast filter").

Signed-off-by: Konstantin Khlebnikov 
Signed-off-by: David S. Miller

ipvlan: Defer multicast / broadcast processing to a work-queue

2015-05-05T23:29:49+00:00

Processing multicast / broadcast in fast path is performance draining
and having more links means more cloning and bringing performance
down further.

Broadcast; in particular, need to be given to all the virtual links.
Earlier tricks of enabling broadcast bit for IPv4 only interfaces are not
really working since it fails autoconf. Which means enabling broadcast
for all the links if protocol specific hacks do not have to be added into
the driver.

This patch defers all (incoming as well as outgoing) multicast traffic to
a work-queue leaving only the unicast traffic in the fast-path. Now if we
need to apply any additional tricks to further reduce the impact of this
(multicast / broadcast) type of traffic, it can be implemented while
processing this work without affecting the fast-path.

Signed-off-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

ipvlan: fix check for IP addresses in control path

2015-03-31T17:28:33+00:00

When an ipvlan interface is down, its addresses are not on the hash list.
Fix checks for existence of addresses not to depend on the hash list, walk
through all interface addresses instead.

Signed-off-by: Jiri Benc 
Acked-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

ipvlan: add a missing __percpu pcpu_stats

2015-02-12T04:03:23+00:00

Cosmetic patch to add __percpu qualifier to pcpu_stats

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipvlan: move the device check function into netdevice.h

2014-12-09T21:10:06+00:00

Move the port check [ipvlan_dev_master()] and device check
[ipvlan_dev_slave()] functions to netdevice.h and rename them
netif_is_ipvlan_port() and netif_is_ipvlan() resp. to be
consistent with macvlan api naming.

Signed-off-by: Mahesh Bandewar 
Signed-off-by: David S. Miller

ipvlan: ipvlan depends on INET and IPV6

2014-11-30T04:53:05+00:00

This driver uses ip_out_local() and ip6_route_output() which are
defined only if CONFIG_INET and CONFIG_IPV6 are enabled respectively.

Reported-by: Jim Davis 
Signed-off-by: Mahesh Bandewar 
Signed-off-by: David S. Miller