linux-stable.git/drivers/net/ipa, branch linux-5.13.y

net: ipa: fix IPA v4.9 interconnects

2021-09-18T11:42:08+00:00

[ Upstream commit 0fd75f5760b6a7a7f35dff46a6cdc4f6d1a86ee8 ]

Three interconnects are defined for IPA version 4.9, but there
should only be two.  They should also use names that match what's
used for other platforms (and specified in the Device Tree binding).

Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: ipa: fix ipa_cmd_table_valid()

2021-09-18T11:42:04+00:00

[ Upstream commit f2c1dac0abcfa93e8b20065b8d6b4b2b6f9990aa ]

Stop supporting different sizes for hashed and non-hashed filter or
route tables.  Add BUILD_BUG_ON() calls to verify the sizes of the
fields in the filter/route table initialization immediate command
are the same.

Add a check to ipa_cmd_table_valid() to ensure the size of the
memory region being checked fits within the immediate command field
that must hold it.

Remove two Boolean parameters used only for error reporting.  This
actually fixes a bug that would only show up if IPA_VALIDATE were
defined.  Define ipa_cmd_table_valid() unconditionally (no longer
dependent on IPA_VALIDATE).

Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: ipa: fix IPA v4.11 interconnect data

2021-09-18T11:42:00+00:00

[ Upstream commit 0ac26271344478ff718329fa9d4ef81d4bcbc43b ]

Currently three interconnects are defined for the Qualcomm SC7280
SoC, but this was based on a misunderstanding.  There should only be
two interconnects defined:  one between the IPA and system memory;
and another between the AP and IPA config space.  The bandwidths
defined for the memory and config interconnects do not match what I
understand to be proper values, so update these.

Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: ipa: Add missing of_node_put() in ipa_firmware_load()

2021-07-19T08:04:41+00:00

[ Upstream commit b244163f2c45c12053cb0291c955f892e79ed8a9 ]

This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. of_node_put() on it before exiting
this function.

Reported-by: Hulk Robot 
Signed-off-by: Yang Yingliang 
Acked-by: Alex Elder 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: ipa: memory region array is variable size

2021-05-11T23:22:37+00:00

IPA configuration data includes an array of memory region
descriptors.  That was a fixed-size array at one time, but
at some point we started defining it such that it was only
as big as required for a given platform.  The actual number
of entries in the array is recorded in the configuration data
along with the array.

A loop in ipa_mem_config() still assumes the array has entries
for all defined memory region IDs.  As a result, this loop can
go past the end of the actual array and attempt to write
"canary" values based on nonsensical data.

Fix this, by stashing the number of entries in the array, and
using that rather than IPA_MEM_COUNT in the initialization loop
found in ipa_mem_config().

The only remaining use of IPA_MEM_COUNT is in a validation check
to ensure configuration data doesn't have too many entries.
That's fine for now.

Fixes: 3128aae8c439a ("net: ipa: redefine struct ipa_mem_data")
Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller

net: ipa: fix inter-EE IRQ register definitions

2021-05-06T23:32:10+00:00

In gsi_irq_setup(), two registers are written with the intention of
disabling inter-EE channel and event IRQs.

But the wrong registers are used (and defined); the ones used are
read-only registers that indicate whether the interrupt condition is
present.

Define the mask registers instead of the status registers, and use
them to disable the inter-EE interrupt types.

Fixes: 46f748ccaf01 ("net: ipa: explicitly disallow inter-EE interrupts")
Signed-off-by: Alex Elder 
Link: https://lore.kernel.org/r/20210505223636.232527-1-elder@linaro.org
Signed-off-by: Jakub Kicinski

net: ipa: optionally define firmware name via DT

2021-04-16T22:38:32+00:00

IPA initialization includes loading some firmware.  This step is
done either by the modem or by the AP under Trust Zone.  If the
AP loads firmware, the name of the firmware file is currently
hard-coded ("ipa_fws.mdt").

Add the ability to specify the relative path of the firmware file to
use in a property in the Device Tree IPA node.  If the property is
not found (or if any other error occurs attempting to get it), fall
back to using a default relative path.

Use the "old" fixed name as the default.  Rename the symbol that
represents this default to emphasize its purpose.

Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller

net: ipa: add IPA v4.9 configuration data

2021-04-13T22:02:25+00:00

Add support for the SM8350 SoC, which includes IPA version 4.9.

Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller

net: ipa: add IPA v4.11 configuration data

2021-04-11T23:49:08+00:00

Add support for the SC7280 SoC, which includes IPA version 4.11.

Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller

net: ipa: add IPA v4.5 configuration data

2021-04-11T23:49:08+00:00

Add support for the SDX55 SoC, which includes IPA version 4.5.

Starting with IPA v4.5, a few of the memory regions have a different
number of "canary" values; update comments in the where the region
identifers are defined to accurately reflect that.

I'll note three differences in SDX55 versus the other two existing
platforms (SDM845 and SC7180):
  - SDX55 uses a 32-bit Linux kernel
  - SDX55 has four interconnects rather than three
  - SDX55 uses IPA v4.5, which uses inline checksum offload

Signed-off-by: Alex Elder 
Signed-off-by: David S. Miller