linux-stable.git/drivers/net/ifb.c, branch v3.0

net: call dev_alloc_name from register_netdevice

2011-05-05T17:57:45+00:00

Force dev_alloc_name() to be called from register_netdevice() by
dev_get_valid_name(). That allows to remove multiple explicit
dev_alloc_name() calls.

The possibility to call dev_alloc_name in advance remains.

This also fixes veth creation regresion caused by
84c49d8c3e4abefb0a41a77b25aa37ebe8d6b743

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

ifb: add performance flags

2011-01-03T20:43:10+00:00

Le lundi 03 janvier 2011 à 11:40 -0800, David Miller a écrit :
> From: Jarek Poplawski 
> Date: Mon, 3 Jan 2011 20:37:03 +0100
>
> > On Sun, Jan 02, 2011 at 09:24:36PM +0100, Eric Dumazet wrote:
> >> Le mercredi 29 décembre 2010 ?? 00:07 +0100, Jarek Poplawski a écrit :
> >>
> >> > Ingress is before vlans handler so these features and the
> >> > NETIF_F_HW_VLAN_TX flag seem useful for ifb considering
> >> > dev_hard_start_xmit() checks.
> >>
> >> OK, here is v2 of the patch then, thanks everybody.
> >>
> >>
> >> [PATCH v2 net-next-2.6] ifb: add performance flags
> >>
> >> IFB can use the full set of features flags (NETIF_F_SG |
> >> NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to
> >> avoid unnecessary split of some packets (GRO for example)
> >>
> >> Changli suggested to also set vlan_features,
> >
> > He also suggested more GSO flags of which especially NETIF_F_TSO6
> > seems interesting (wrt GRO)?
>
> I think at least TSO6 would very much be appropriate here.

Yes, why not, I am only wondering why loopback / dummy (and others ?)
only set NETIF_F_TSO :)

Since I want to play with ECN, I might also add NETIF_F_TSO_ECN ;)

For other flags, I really doubt it can matter on ifb ?

[PATCH v3 net-next-2.6] ifb: add performance flags

IFB can use the full set of features flags (NETIF_F_SG |
NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to
avoid unnecessary split of some packets (GRO for example)

Changli suggested to also set vlan_features, NETIF_F_TSO6,
NETIF_F_TSO_ECN.

Jarek suggested to add NETIF_F_HW_VLAN_TX as well.

Signed-off-by: Eric Dumazet 
Cc: Changli Gao 
Cc: Jarek Poplawski 
Cc: Pawel Staszewski 
Signed-off-by: David S. Miller

ifb: use netif_receive_skb() instead of netif_rx()

2010-12-20T05:44:30+00:00

In ri_tasklet(), we run from softirq, so can directly handle packet
through netif_receive_skb() instead of netif_rx().
There is no risk of recursion.

Signed-off-by: Eric Dumazet 
Acked-by: Changli Gao 
Signed-off-by: David S. Miller

ifb: fix a lockdep splat

2010-12-16T22:54:52+00:00

After recent ifb changes, we must use lockless __skb_dequeue() since
lock is not anymore initialized.

Signed-off-by: Eric Dumazet 
Cc: Jamal Hadi Salim 
Cc: Changli Gao 
Acked-by: Changli Gao 
Signed-off-by: David S. Miller

ifb: use the lockless variants of skb_queue

2010-12-10T22:34:34+00:00

rq and tq are both protected by tx queue lock, so we can simply use
the lockless variants of skb_queue.

skb_queue_splice_tail_init() is used instead of the open coded and slow
one.

Signed-off-by: Changli Gao 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

ifb: remove unused macro TX_TIMEOUT

2010-12-10T22:34:34+00:00

Signed-off-by: Changli Gao 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

ifb: remove the useless debug stats

2010-12-10T22:34:33+00:00

These debug stats are not exported, and become useless.

Signed-off-by: Changli Gao 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

ifb: goto resched directly if error happens and dp->tq isn't empty

2010-12-08T17:45:34+00:00

If we break the loop when there are still skbs in tq and no skb in
rq, the skbs will be left in txq until new skbs are enqueued into rq.
In rare cases, no new skb is queued, then these skbs will stay in rq
forever.

After this patch, if tq isn't empty when we break the loop, we goto
resched directly.

Signed-off-by: Changli Gao 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net: trans_start cleanups

2010-05-10T12:01:31+00:00

Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.

Exceptions are NETIF_F_LLTX drivers

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: rename skb->iif to skb->skb_iif

2009-11-20T23:35:04+00:00

To help grep games, rename iif to skb_iif

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller