linux-stable.git/drivers/net/hyperv, branch v4.12

netvsc: don't access netdev->num_rx_queues directly

2017-06-22T17:27:28+00:00

This structure member is hidden behind CONFIG_SYSFS, and we
get a build error when that is disabled:

drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh':
drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?

As the value is only set once to the argument of alloc_netdev_mq(),
we can compare against that constant directly.

Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of channels")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Haiyang Zhang 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netvsc: move filter setting to rndis_device

2017-06-08T15:45:48+00:00

The work queue and handling of network filter parameters should
be in rndis_device. This gets rid of warning from RCU checks,
eliminates a race and cleans up code.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netvsc: fix net poll mode

2017-06-08T15:45:48+00:00

The ndo_poll_controller function needs to schedule NAPI to pick
up arriving packets and send completions. Otherwise no data
will ever be received. For simple case of netconsole, it also
will allow send completions to happen.  Without this netpoll
will eventually get stuck.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netvsc: fix rcu dereference warning from ethtool

2017-06-08T15:45:48+00:00

The ethtool info command calls the netvsc get_sset_count with RTNL
but not with RCU. Which causes warning:

drivers/net/hyperv/netvsc_drv.c:1010 suspicious rcu_dereference_check() usage!

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netvsc: make sure napi enabled before vmbus_open

2017-05-04T15:08:36+00:00

This fixes a race where vmbus callback for new packet arriving
could occur before NAPI is initialized.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-04-27T02:39:08+00:00

Signed-off-by: David S. Miller

netvsc: fix calculation of available send sections

2017-04-25T15:56:59+00:00

My change (introduced in 4.11) to use find_first_clear_bit
incorrectly assumed that the size argument was words, not bits.
The effect was only a small limited number of the available send
sections were being actually used. This can cause performance loss
with some workloads.

Since map_words is now used only during initialization, it can
be on stack instead of in per-device data.

Fixes: b58a185801da ("netvsc: simplify get next send section")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netvsc: fix use after free on module removal

2017-04-21T17:59:57+00:00

The NAPI data structure is embedded in the netvsc_device structure
and is freed when device is closed. There is still a reference
(in NAPI list) to this which causes a crash in netif_napi_del
when device is removed. Fix by managing NAPI instances correctly.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netvsc: Deal with rescinded channels correctly

2017-04-21T17:47:00+00:00

We will not be able to send packets over a channel that has been
rescinded. Make necessary adjustments so we can properly cleanup
even when the channel is rescinded. This issue can be trigerred
in the NIC hot-remove path.

Signed-off-by: K. Y. Srinivasan 
Signed-off-by: David S. Miller

hv_netvsc: change netvsc device default duplex to FULL

2017-04-17T19:12:33+00:00

The netvsc device supports full duplex by default.
This warnings in log from bonding device which did not like
seeing UNKNOWN duplex.

Signed-off-by: Simon Xiao 
Signed-off-by: David S. Miller