linux-stable.git/drivers/net/hyperv, branch linux-5.0.y

hv_netvsc: fix race that may miss tx queue wakeup

2019-05-31T13:44:53+00:00

[ Upstream commit 93aa4792c3908eac87ddd368ee0fe0564148232b ]

When the ring buffer is almost full due to RX completion messages, a
TX packet may reach the "low watermark" and cause the queue stopped.
If the TX completion arrives earlier than queue stopping, the wakeup
may be missed.

This patch moves the check for the last pending packet to cover both
EAGAIN and success cases, so the queue will be reliably waked up when
necessary.

Reported-and-tested-by: Stephan Klein 
Signed-off-by: Haiyang Zhang 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

hv_netvsc: Fix unwanted wakeup after tx_disable

2019-04-17T06:39:37+00:00

[ Upstream commit 1b704c4a1ba95574832e730f23817b651db2aa59 ]

After queue stopped, the wakeup mechanism may wake it up again
when ring buffer usage is lower than a threshold. This may cause
send path panic on NULL pointer when we stopped all tx queues in
netvsc_detach and start removing the netvsc device.

This patch fix it by adding a tx_disable flag to prevent unwanted
queue wakeup.

Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
Reported-by: Mohammed Gamal 
Signed-off-by: Haiyang Zhang 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

hv_netvsc: Fix IP header checksum for coalesced packets

2019-02-26T22:45:02+00:00

Incoming packets may have IP header checksum verified by the host.
They may not have IP header checksum computed after coalescing.
This patch re-compute the checksum when necessary, otherwise the
packets may be dropped, because Linux network stack always checks it.

Signed-off-by: Haiyang Zhang 
Signed-off-by: David S. Miller

hv_netvsc: fix typos in code comments

2019-01-23T18:21:34+00:00

Fix all typos from hyperv netvsc code comments.

Signed-off-by: Adrian Vladu 

Cc: "K. Y. Srinivasan" 
Cc: Haiyang Zhang 
Cc: Stephen Hemminger 
Cc: Sasha Levin 
Cc: "David S. Miller" 
Cc: "Alessandro Pilotti" 
Signed-off-by: Sasha Levin

hv_netvsc: Fix hash key value reset after other ops

2019-01-23T18:21:28+00:00

Changing mtu, channels, or buffer sizes ops call to netvsc_attach(),
rndis_set_subchannel(), which always reset the hash key to default
value. That will override hash key changed previously. This patch
fixes the problem by save the hash key, then restore it when we re-
add the netvsc device.

Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
Signed-off-by: Haiyang Zhang 
Reviewed-by: Michael Kelley 
[sl: fix up subject line]
Signed-off-by: Sasha Levin

hv_netvsc: Refactor assignments of struct netvsc_device_info

2019-01-23T18:20:10+00:00

These assignments occur in multiple places. The patch refactor them
to a function for simplicity. It also puts the struct to heap area
for future expension.

Signed-off-by: Haiyang Zhang 
Reviewed-by: Michael Kelley 
[sl: fix up subject line]
Signed-off-by: Sasha Levin

hv_netvsc: Fix ethtool change hash key error

2019-01-23T18:19:35+00:00

Hyper-V hosts require us to disable RSS before changing RSS key,
otherwise the changing request will fail. This patch fixes the
coding error.

Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
Reported-by: Wei Hu 
Signed-off-by: Haiyang Zhang 
Reviewed-by: Michael Kelley 
[sl: fix up subject line]
Signed-off-by: Sasha Levin

net: dev: Add extack argument to dev_set_mac_address()

2018-12-14T02:41:38+00:00

A follow-up patch will add a notifier type NETDEV_PRE_CHANGEADDR, which
allows vetoing of MAC address changes. One prominent path to that
notification is through dev_set_mac_address(). Therefore give this
function an extack argument, so that it can be packed together with the
notification. Thus a textual reason for rejection (or a warning) can be
communicated back to the user.

Signed-off-by: Petr Machata 
Acked-by: Jiri Pirko 
Reviewed-by: Ido Schimmel 
Signed-off-by: David S. Miller

net: core: dev: Add extack argument to dev_change_flags()

2018-12-06T21:26:07+00:00

In order to pass extack together with NETDEV_PRE_UP notifications, it's
necessary to route the extack to __dev_open() from diverse (possibly
indirect) callers. One prominent API through which the notification is
invoked is dev_change_flags().

Therefore extend dev_change_flags() with and extra extack argument and
update all users. Most of the calls end up just encoding NULL, but
several sites (VLAN, ipvlan, VRF, rtnetlink) do have extack available.

Since the function declaration line is changed anyway, name the other
function arguments to placate checkpatch.

Signed-off-by: Petr Machata 
Acked-by: Jiri Pirko 
Reviewed-by: Ido Schimmel 
Reviewed-by: David Ahern 
Signed-off-by: David S. Miller

net: core: dev: Add extack argument to dev_open()

2018-12-06T21:26:06+00:00

In order to pass extack together with NETDEV_PRE_UP notifications, it's
necessary to route the extack to __dev_open() from diverse (possibly
indirect) callers. One prominent API through which the notification is
invoked is dev_open().

Therefore extend dev_open() with and extra extack argument and update
all users. Most of the calls end up just encoding NULL, but bond and
team drivers have the extack readily available.

Signed-off-by: Petr Machata 
Acked-by: Jiri Pirko 
Reviewed-by: Ido Schimmel 
Reviewed-by: David Ahern 
Signed-off-by: David S. Miller