linux-stable.git/drivers/net/forcedeth.c, branch v2.6.30

forcedeth: add phy_power_down parameter, leave phy powered up by default (v2)

2009-06-02T07:19:52+00:00

Add a phy_power_down parameter to forcedeth: set to 1 to power down the
phy and disable the link when an interface goes down; set to 0 to always
leave the phy powered up.

The phy power state persists across reboots; Windows, some BIOSes, and
older versions of Linux don't bother to power up the phy again, forcing
users to remove all power to get the interface working (see
http://bugzilla.kernel.org/show_bug.cgi?id=13072).  Leaving the phy
powered on is the safest default behavior.  Users accustomed to seeing
the link state reflect the interface state and/or wanting to minimize
power consumption can set phy_power_down=1 if compatibility with other
OSes is not an issue.

Signed-off-by: Ed Swierk 
Signed-off-by: David S. Miller

forcedeth: tx timeout fix

2009-04-27T09:40:51+00:00

This patch fixes the tx_timeout() to properly handle the clean up of the
tx ring. It also sets the tx put pointer back to the correct position to
be in sync with HW.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: David S. Miller

forcedeth: Use napi_complete() not __napi_complete().

2009-04-09T08:09:33+00:00

It's not enough that forcedeth's interrupts are disabled,
local cpu interrupts have to unconditionally be off
when we remove the device from the poll list.

Based upon a crash report from
Alexander Beregalov :

 WARNING: at lib/list_debug.c:30 __list_add+0x89/0x90()
 Hardware name:
 list_add corruption. prev->next should be next (c06ea834), but was
f70244c8. (prev=c06ea834).
 Modules linked in: w83627hf hwmon_vid i2c_nforce2
 Pid: 1436, comm: portageq Not tainted 2.6.30-rc1 #1
 Call Trace:
  [] warn_slowpath+0x73/0xd0
  [] ? __kfree_skb+0x38/0x90
  [] ? tcp_data_snd_check+0x26/0xe0
  [] ? tcp_rcv_established+0x2bf/0x5e0
  [] ? tcp_v4_rcv+0x47a/0x610
  [] ? print_lock_contention_bug+0x1d/0x110
  [] ? _spin_unlock+0x27/0x50
  [] ? tcp_v4_rcv+0x54b/0x610
  [] __list_add+0x89/0x90
  [] __napi_schedule+0x29/0x60
  [] e1000_intr+0xbd/0x1a0
  [] handle_IRQ_event+0x3e/0x120
  [] handle_fasteoi_irq+0x60/0xd0
  [] handle_irq+0x34/0x60
  [] ? rcu_irq_enter+0x8/0x40
  [] do_IRQ+0x39/0xa0
  [] ? skb_release_head_state+0x2c/0x60
  [] common_interrupt+0x2e/0x34
  [] ? list_del+0x21/0x90
  [] ? trace_hardirqs_on+0xb/0x10
  [] __napi_complete+0x1a/0x30
  [] nv_napi_poll+0xd1/0x5c0
  [] ? trace_hardirqs_on+0xb/0x10
  [] net_rx_action+0x106/0x1b0
  [] __do_softirq+0x6f/0x100
  [] ? _spin_unlock+0x27/0x50
  [] ? handle_fasteoi_irq+0x88/0xd0
  [] do_softirq+0x5d/0x70
  [] irq_exit+0x7d/0xa0
  [] do_IRQ+0x42/0xa0
  [] ? do_softirq+0x47/0x70
  [] common_interrupt+0x2e/0x34

Signed-off-by: David S. Miller

dma-mapping: replace all DMA_39BIT_MASK macro with DMA_BIT_MASK(39)

2009-04-07T15:31:11+00:00

Replace all DMA_39BIT_MASK macro with DMA_BIT_MASK(39)

Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

forcedeth: Fix resume from hibernation regression.

2009-04-07T00:49:12+00:00

Reset phy state on resume, fixing a regression caused by powering down
the phy on hibernate.

Signed-off-by: Ed Swierk 
Signed-off-by: David S. Miller

forcedeth: version bump to 64

2009-03-10T12:29:52+00:00

This patch bumps up the version to 0.64

Signed-off-by: Ayaz Abdulla 
Signed-off-by: David S. Miller

forcedeth: fix irq clearing and napi spin lock changes

2009-03-10T12:29:51+00:00

This patch clears the irqstatus register with the exact same events it
has read from it. Since the read-write operation is not atomic, a new
irqstatus bit could have been set in between these operations and would
then be cleared accidentally.

Secondly, we now don't need any spin lock protection when
scheduling/completing napi poll as the isr will not execute anymore (as
we turn off all interrupts now).

Signed-off-by: Ayaz Abdulla 
Signed-off-by: David S. Miller

forcedeth: performance changes

2009-03-10T12:29:50+00:00

This patch modifies the throughput mode poll settings to reduce the
number of interrupts. This is only used by older hardware that need a
timer irq in throughput mode.

Secondly, this patch increases the default rx ring from 128 to 512. This
drastically improves bandwidth utilization for small packets sizes i.e
512 bytes.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: David S. Miller

forcedeth: add interrupt moderation logic

2009-03-10T12:29:49+00:00

This patch adds the logic to moderate the interrupts by changing the
mode between throughput and poll. If there has been a large amount of
time without any burst of network load, the code will transition to pure
throughput mode (where each tx/rx/other will cause an interrupt). If
bursts of network load occurs, it will transition to poll based mode to
help reduce cpu utilization (it will not interrupt on each packet) while
maintaining the optimum network bandwidth utilization.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: David S. Miller

forcedeth: remove isr processing loop

2009-03-10T12:29:49+00:00

This patch is only a subset of changes so that it is easier to see the
modifications. This patch removes the isr 'for' loop and shifts all the
logic to account for new tab spacing.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: David S. Miller