<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux-stable.git/drivers/net/forcedeth.c, branch linux-2.6.33.y</title>
<subtitle>Linux kernel stable tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/'/>
<entry>
<title>forcedeth: fix tx limit2 flag check</title>
<updated>2010-08-02T17:26:48+00:00</updated>
<author>
<name>Ayaz Abdulla</name>
<email>aabdulla@nvidia.com</email>
</author>
<published>2010-04-14T01:49:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=aeff222848474b810074b5fdec054fb8f9f2ecef'/>
<id>aeff222848474b810074b5fdec054fb8f9f2ecef</id>
<content type='text'>
commit 5c659322a904a7cc0265e7b183372b9bdebec6db upstream.

This is a fix for bug 572201 @ bugs.debian.org

This patch fixes the TX_LIMIT feature flag. The previous logic check
for TX_LIMIT2 also took into account a device that only had TX_LIMIT
set.

Reported-by: Stephen Mulcahu &lt;stephen.mulcahy@deri.org&gt;
Reported-by: Ben Huchings &lt;ben@decadent.org.uk&gt;
Signed-off-by: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
Cc: Ben Hutchings &lt;ben@decadent.org.uk&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit 5c659322a904a7cc0265e7b183372b9bdebec6db upstream.

This is a fix for bug 572201 @ bugs.debian.org

This patch fixes the TX_LIMIT feature flag. The previous logic check
for TX_LIMIT2 also took into account a device that only had TX_LIMIT
set.

Reported-by: Stephen Mulcahu &lt;stephen.mulcahy@deri.org&gt;
Reported-by: Ben Huchings &lt;ben@decadent.org.uk&gt;
Signed-off-by: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
Cc: Ben Hutchings &lt;ben@decadent.org.uk&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>drivers/net: request_irq - Remove unnecessary leading &amp; from second arg</title>
<updated>2009-11-19T07:29:17+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2009-11-19T07:29:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=a0607fd3a25ba1848a63a0d925e36d914735ab47'/>
<id>a0607fd3a25ba1848a63a0d925e36d914735ab47</id>
<content type='text'>
Not as fancy as coccinelle.  Checkpatch errors ignored.
Compile tested allyesconfig x86, not all files compiled.

grep -rPl --include=*.[ch] "\brequest_irq\s*\([^,\)]+,\s*\&amp;" drivers/net | while read file ; do \
	perl -i -e 'local $/; while (&lt;&gt;) { s@(\brequest_irq\s*\([^,\)]+,\s*)\&amp;@\1@g ; print ; }' $file ;\
done

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Not as fancy as coccinelle.  Checkpatch errors ignored.
Compile tested allyesconfig x86, not all files compiled.

grep -rPl --include=*.[ch] "\brequest_irq\s*\([^,\)]+,\s*\&amp;" drivers/net | while read file ; do \
	perl -i -e 'local $/; while (&lt;&gt;) { s@(\brequest_irq\s*\([^,\)]+,\s*)\&amp;@\1@g ; print ; }' $file ;\
done

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6</title>
<updated>2009-11-18T22:54:45+00:00</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@linux-foundation.org</email>
</author>
<published>2009-11-18T22:54:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=486bfe5c7ca6184f35b93b9f2bf3fa3baa1b65e4'/>
<id>486bfe5c7ca6184f35b93b9f2bf3fa3baa1b65e4</id>
<content type='text'>
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (42 commits)
  cxgb3: fix premature page unmap
  ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts
  vlan: Fix register_vlan_dev() error path
  gro: Fix illegal merging of trailer trash
  sungem: Fix Serdes detection.
  net: fix mdio section mismatch warning
  ppp: fix BUG on non-linear SKB (multilink receive)
  ixgbe: Fixing EEH handler to handle more than one error
  net: Fix the rollback test in dev_change_name()
  Revert "isdn: isdn_ppp: Use SKB list facilities instead of home-grown implementation."
  TI Davinci EMAC : Fix Console Hang when bringing the interface down
  smsc911x: Fix Console Hang when bringing the interface down.
  mISDN: fix error return in HFCmulti_init()
  forcedeth: mac address fix
  r6040: fix version printing
  Bluetooth: Fix regression with L2CAP configuration in Basic Mode
  Bluetooth: Select Basic Mode as default for SOCK_SEQPACKET
  Bluetooth: Set general bonding security for ACL by default
  r8169: Fix receive buffer length when MTU is between 1515 and 1536
  can: add the missing netlink get_xstats_size callback
  ...
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (42 commits)
  cxgb3: fix premature page unmap
  ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts
  vlan: Fix register_vlan_dev() error path
  gro: Fix illegal merging of trailer trash
  sungem: Fix Serdes detection.
  net: fix mdio section mismatch warning
  ppp: fix BUG on non-linear SKB (multilink receive)
  ixgbe: Fixing EEH handler to handle more than one error
  net: Fix the rollback test in dev_change_name()
  Revert "isdn: isdn_ppp: Use SKB list facilities instead of home-grown implementation."
  TI Davinci EMAC : Fix Console Hang when bringing the interface down
  smsc911x: Fix Console Hang when bringing the interface down.
  mISDN: fix error return in HFCmulti_init()
  forcedeth: mac address fix
  r6040: fix version printing
  Bluetooth: Fix regression with L2CAP configuration in Basic Mode
  Bluetooth: Select Basic Mode as default for SOCK_SEQPACKET
  Bluetooth: Set general bonding security for ACL by default
  r8169: Fix receive buffer length when MTU is between 1515 and 1536
  can: add the missing netlink get_xstats_size callback
  ...
</pre>
</div>
</content>
</entry>
<entry>
<title>forcedeth: mac address fix</title>
<updated>2009-11-16T05:17:02+00:00</updated>
<author>
<name>Stanislav O. Bezzubtsev</name>
<email>stas@lvk.cs.msu.su</email>
</author>
<published>2009-11-16T05:17:02+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=655a6595af5cd7e91992bd768d7a5949f813dc0d'/>
<id>655a6595af5cd7e91992bd768d7a5949f813dc0d</id>
<content type='text'>
Use the existing random_ether_addr() to generate random MAC
instead of doing it by-hand.

Signed-off-by: Stanislav O. Bezzubtsev &lt;stas@lvk.cs.msu.su&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use the existing random_ether_addr() to generate random MAC
instead of doing it by-hand.

Signed-off-by: Stanislav O. Bezzubtsev &lt;stas@lvk.cs.msu.su&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>headers: remove sched.h from interrupt.h</title>
<updated>2009-10-11T18:20:58+00:00</updated>
<author>
<name>Alexey Dobriyan</name>
<email>adobriyan@gmail.com</email>
</author>
<published>2009-10-07T13:09:06+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=d43c36dc6b357fa1806800f18aa30123c747a6d1'/>
<id>d43c36dc6b357fa1806800f18aa30123c747a6d1</id>
<content type='text'>
After m68k's task_thread_info() doesn't refer to current,
it's possible to remove sched.h from interrupt.h and not break m68k!
Many thanks to Heiko Carstens for allowing this.

Signed-off-by: Alexey Dobriyan &lt;adobriyan@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After m68k's task_thread_info() doesn't refer to current,
it's possible to remove sched.h from interrupt.h and not break m68k!
Many thanks to Heiko Carstens for allowing this.

Signed-off-by: Alexey Dobriyan &lt;adobriyan@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>netdev: convert bulk of drivers to netdev_tx_t</title>
<updated>2009-09-01T08:14:07+00:00</updated>
<author>
<name>Stephen Hemminger</name>
<email>shemminger@vyatta.com</email>
</author>
<published>2009-08-31T19:50:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=61357325f377889a1daffa14962d705dc814dd0e'/>
<id>61357325f377889a1daffa14962d705dc814dd0e</id>
<content type='text'>
In a couple of cases collapse some extra code like:
   int retval = NETDEV_TX_OK;
   ...
   return retval;
into
   return NETDEV_TX_OK;

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In a couple of cases collapse some extra code like:
   int retval = NETDEV_TX_OK;
   ...
   return retval;
into
   return NETDEV_TX_OK;

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>forcedeth: Fix NAPI race.</title>
<updated>2009-07-06T01:03:33+00:00</updated>
<author>
<name>Eric Dumazet</name>
<email>eric.dumazet@gmail.com</email>
</author>
<published>2009-07-02T04:04:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=78c29bd95bd8d2c3bcf7932cb3ab8ae01cd8f58f'/>
<id>78c29bd95bd8d2c3bcf7932cb3ab8ae01cd8f58f</id>
<content type='text'>
Eric Dumazet a écrit :
&gt; Ingo Molnar a écrit :
&gt;&gt;&gt; The following changes since commit 52989765629e7d182b4f146050ebba0abf2cb0b7:
&gt;&gt;&gt;   Linus Torvalds (1):
&gt;&gt;&gt;         Merge git://git.kernel.org/.../davem/net-2.6
&gt;&gt;&gt;
&gt;&gt;&gt; are available in the git repository at:
&gt;&gt;&gt;
&gt;&gt;&gt;   master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master
&gt;&gt; Hm, something in this lot quickly wrecked networking here - see the
&gt;&gt; tx timeout dump below. It starts with:
&gt;&gt;
&gt;&gt; [  351.004596] WARNING: at net/sched/sch_generic.c:246 dev_watchdog+0x10b/0x19c()
&gt;&gt; [  351.011815] Hardware name: System Product Name
&gt;&gt; [  351.016220] NETDEV WATCHDOG: eth0 (forcedeth): transmit queue 0 timed out
&gt;&gt;
&gt;&gt; Config attached. Unfortunately i've got no time to do bisection
&gt;&gt; today.
&gt;
&gt;
&gt;
&gt; forcedeth might have a problem, in its netif_wake_queue() logic, but
&gt; I could not see why a recent patch could make this problem visible now.
&gt;
&gt; CPU0/1: AMD Athlon(tm) 64 X2 Dual Core Processor 3800+ stepping 02
&gt; is not a new cpu either :)
&gt;
&gt; forcedeth uses an internal tx_stop without appropriate barrier.
&gt;
&gt; Could you try following patch ?
&gt;
&gt; (random guess as I dont have much time right now)

We might have a race in napi_schedule(), leaving interrupts disabled forever.
I cannot test this patch, I dont have the hardware...

Tested-by: Ingo Molnar &lt;mingo@elte.hu&gt;

Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Eric Dumazet a écrit :
&gt; Ingo Molnar a écrit :
&gt;&gt;&gt; The following changes since commit 52989765629e7d182b4f146050ebba0abf2cb0b7:
&gt;&gt;&gt;   Linus Torvalds (1):
&gt;&gt;&gt;         Merge git://git.kernel.org/.../davem/net-2.6
&gt;&gt;&gt;
&gt;&gt;&gt; are available in the git repository at:
&gt;&gt;&gt;
&gt;&gt;&gt;   master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master
&gt;&gt; Hm, something in this lot quickly wrecked networking here - see the
&gt;&gt; tx timeout dump below. It starts with:
&gt;&gt;
&gt;&gt; [  351.004596] WARNING: at net/sched/sch_generic.c:246 dev_watchdog+0x10b/0x19c()
&gt;&gt; [  351.011815] Hardware name: System Product Name
&gt;&gt; [  351.016220] NETDEV WATCHDOG: eth0 (forcedeth): transmit queue 0 timed out
&gt;&gt;
&gt;&gt; Config attached. Unfortunately i've got no time to do bisection
&gt;&gt; today.
&gt;
&gt;
&gt;
&gt; forcedeth might have a problem, in its netif_wake_queue() logic, but
&gt; I could not see why a recent patch could make this problem visible now.
&gt;
&gt; CPU0/1: AMD Athlon(tm) 64 X2 Dual Core Processor 3800+ stepping 02
&gt; is not a new cpu either :)
&gt;
&gt; forcedeth uses an internal tx_stop without appropriate barrier.
&gt;
&gt; Could you try following patch ?
&gt;
&gt; (random guess as I dont have much time right now)

We might have a race in napi_schedule(), leaving interrupts disabled forever.
I cannot test this patch, I dont have the hardware...

Tested-by: Ingo Molnar &lt;mingo@elte.hu&gt;

Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>forcedeth: fix dma api mismatches</title>
<updated>2009-06-18T07:46:13+00:00</updated>
<author>
<name>Eric Dumazet</name>
<email>eric.dumazet@gmail.com</email>
</author>
<published>2009-06-17T21:17:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=73a370795371e41f72aeca61656d47adeadf28e5'/>
<id>73a370795371e41f72aeca61656d47adeadf28e5</id>
<content type='text'>
forcedeth doesnt use properly dma api in its tx completion path
and in nv_loopback_test()

pci_map_single() should be paired with pci_unmap_single()
pci_map_page() should be paired with pci_unmap_page()

forcedeth xmit path uses pci_map_single() &amp; pci_map_page(),
but tx completion path only uses pci_unmap_single()

nv_loopback_test() uses pci_map_single() &amp; pci_unmap_page()

Add a dma_single field in struct nv_skb_map, and
define a helper function nv_unmap_txskb

Signed-off-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
CC: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
forcedeth doesnt use properly dma api in its tx completion path
and in nv_loopback_test()

pci_map_single() should be paired with pci_unmap_single()
pci_map_page() should be paired with pci_unmap_page()

forcedeth xmit path uses pci_map_single() &amp; pci_map_page(),
but tx completion path only uses pci_unmap_single()

nv_loopback_test() uses pci_map_single() &amp; pci_unmap_page()

Add a dma_single field in struct nv_skb_map, and
define a helper function nv_unmap_txskb

Signed-off-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
CC: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>forcedeth: addition of new mcp89 device id</title>
<updated>2009-06-07T10:52:37+00:00</updated>
<author>
<name>Ayaz Abdulla</name>
<email>aabdulla@nvidia.com</email>
</author>
<published>2009-06-03T15:05:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=3df81c4e950a7e38a8ef98f818abc3eed76b3fb2'/>
<id>3df81c4e950a7e38a8ef98f818abc3eed76b3fb2</id>
<content type='text'>
This patch adds a new device id for mcp89 chipset.

Signed-off-by: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch adds a new device id for mcp89 chipset.

Signed-off-by: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>forcedeth: remove device id macros</title>
<updated>2009-06-07T10:52:37+00:00</updated>
<author>
<name>Ayaz Abdulla</name>
<email>aabdulla@nvidia.com</email>
</author>
<published>2009-06-03T15:05:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux-stable.git/commit/?id=3c2e1c11d9126d765ab40207150cb6f9869637f1'/>
<id>3c2e1c11d9126d765ab40207150cb6f9869637f1</id>
<content type='text'>
This patch removes the device id macros and instead uses the constants
directly.

The areas in which logic expressions where using the macros now instead
use feature/workaround flags.

No new functionality has been introduced in this patch, only clean up of
flags and macros.

Signed-off-by: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch removes the device id macros and instead uses the constants
directly.

The areas in which logic expressions where using the macros now instead
use feature/workaround flags.

No new functionality has been introduced in this patch, only clean up of
flags and macros.

Signed-off-by: Ayaz Abdulla &lt;aabdulla@nvidia.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
</feed>
