linux-stable.git/drivers/net/ethernet, branch v6.6

iavf: in iavf_down, disable queues when removing the driver

2023-10-26T00:48:31+00:00

In iavf_down, we're skipping the scheduling of certain operations if
the driver is being removed. However, the IAVF_FLAG_AQ_DISABLE_QUEUES
request must not be skipped in this case, because iavf_close waits
for the transition to the __IAVF_DOWN state, which happens in
iavf_virtchnl_completion after the queues are released.

Without this fix, "rmmod iavf" takes half a second per interface that's
up and prints the "Device resources not yet released" warning.

Fixes: c8de44b577eb ("iavf: do not process adminq tasks when __IAVF_IN_REMOVE_TASK is set")
Signed-off-by: Michal Schmidt 
Reviewed-by: Wojciech Drewek 
Tested-by: Rafal Romanowski 
Tested-by: Jacob Keller 
Signed-off-by: Jacob Keller 
Link: https://lore.kernel.org/r/20231025183213.874283-1-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski

i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR

2023-10-25T00:03:29+00:00

The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one.

Fixes: 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722")
Signed-off-by: Ivan Vecera 
Tested-by: Pucha Himasekhar Reddy  (A Contingent worker at Intel)
Signed-off-by: Jacob Keller 
Link: https://lore.kernel.org/r/20231023212714.178032-1-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski

sfc: cleanup and reduce netlink error messages

2023-10-23T22:47:47+00:00

Reduce the length of netlink error messages as they are likely to be
truncated anyway. Additionally, reword netlink error messages so they
are more consistent with previous messages.

Fixes: 9dbc8d2b9a02 ("sfc: add decrement ipv6 hop limit by offloading set hop limit actions")
Fixes: 3c9561c0a5b9 ("sfc: support TC decap rules matching on enc_ip_tos")
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202310202136.4u7bv0hp-lkp@intel.com/
Signed-off-by: Pieter Jansen van Vuuren 
Reviewed-by: Edward Cree 
Link: https://lore.kernel.org/r/20231020140149.30490-1-pieter.jansen-van-vuuren@amd.com
Signed-off-by: Jakub Kicinski

net: chelsio: cxgb4: add an error code check in t4_load_phy_fw

2023-10-22T10:36:30+00:00

t4_set_params_timeout() can return -EINVAL if failed, add check
for this.

Signed-off-by: Su Hui 
Signed-off-by: David S. Miller

net: ethernet: adi: adin1110: Fix uninitialized variable

2023-10-21T10:54:42+00:00

The spi_transfer struct has to have all it's fields initialized to 0 in
this case, since not all of them are set before starting the transfer.
Otherwise, spi_sync_transfer() will sometimes return an error.

Fixes: a526a3cc9c8d ("net: ethernet: adi: adin1110: Fix SPI transfers")
Signed-off-by: Dell Jin 
Signed-off-by: Ciprian Regus 
Signed-off-by: David S. Miller

net: stmmac: update MAC capabilities when tx queues are updated

2023-10-21T10:53:32+00:00

Upon boot up, the driver will configure the MAC capabilities based on
the maximum number of tx and rx queues. When the user changes the
tx queues to single queue, the MAC should be capable of supporting Half
Duplex, but the driver does not update the MAC capabilities when it is
configured so.

Using the stmmac_reinit_queues() to check the number of tx queues
and set the MAC capabilities accordingly.

Fixes: 0366f7e06a6b ("net: stmmac: add ethtool support for get/set channels")
Cc:  # 5.17+
Signed-off-by: Michael Sit Wei Hong 
Signed-off-by: Gan, Yi Fang 
Signed-off-by: David S. Miller

net: xgene: Fix unused xgene_enet_of_match warning for !CONFIG_OF

2023-10-21T10:49:31+00:00

Commit b0377116decd ("net: ethernet: Use device_get_match_data()") dropped
the unconditional use of xgene_enet_of_match resulting in this warning:

drivers/net/ethernet/apm/xgene/xgene_enet_main.c:2004:34: warning: unused variable 'xgene_enet_of_match' [-Wunused-const-variable]

The fix is to drop of_match_ptr() which is not necessary because DT is
always used for this driver (well, it could in theory support ACPI only,
but CONFIG_OF is always enabled for arm64).

Fixes: b0377116decd ("net: ethernet: Use device_get_match_data()")
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202310170627.2Kvf6ZHY-lkp@intel.com/
Signed-off-by: Rob Herring 
Signed-off-by: David S. Miller

i40e: sync next_to_clean and next_to_process for programming status desc

2023-10-21T01:17:11+00:00

When a programming status desc is encountered on the rx_ring,
next_to_process is bumped along with cleaned_count but next_to_clean is
not. This causes I40E_DESC_UNUSED() macro to misbehave resulting in
overwriting whole ring with new buffers.

Update next_to_clean to point to next_to_process on seeing a programming
status desc if not in the middle of handling a multi-frag packet. Also,
bump cleaned_count only for such case as otherwise next_to_clean buffer
may be returned to hardware on reaching clean_threshold.

Fixes: e9031f2da1ae ("i40e: introduce next_to_process to i40e_ring")
Suggested-by: Maciej Fijalkowski 
Reported-by: hq.dev+kernel@msdfc.xyz
Reported by: Solomon Peachy 
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217678
Tested-by: hq.dev+kernel@msdfc.xyz
Tested by: Indrek Järve 
Signed-off-by: Tirthendu Sarkar 
Tested-by: Arpana Arland  (A Contingent worker at Intel)
Signed-off-by: Jacob Keller 
Acked-by: Maciej Fijalkowski 
Link: https://lore.kernel.org/r/20231019203852.3663665-1-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski

igc: Fix ambiguity in the ethtool advertising

2023-10-21T01:15:38+00:00

The 'ethtool_convert_link_mode_to_legacy_u32' method does not allow us to
advertise 2500M speed support and TP (twisted pair) properly. Convert to
'ethtool_link_ksettings_test_link_mode' to advertise supported speed and
eliminate ambiguity.

Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Suggested-by: Dima Ruinskiy 
Suggested-by: Vitaly Lifshits 
Signed-off-by: Sasha Neftin 
Tested-by: Naama Meir 
Signed-off-by: Jacob Keller 
Link: https://lore.kernel.org/r/20231019203641.3661960-1-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski

igb: Fix potential memory leak in igb_add_ethtool_nfc_entry

2023-10-20T12:29:40+00:00

Add check for return of igb_update_ethtool_nfc_entry so that in case
of any potential errors the memory alocated for input will be freed.

Fixes: 0e71def25281 ("igb: add support of RX network flow classification")
Reviewed-by: Wojciech Drewek 
Signed-off-by: Mateusz Palczewski 
Tested-by: Arpana Arland  (A Contingent worker at Intel)
Signed-off-by: Jacob Keller 
Signed-off-by: David S. Miller