linux-stable.git/drivers/net/ethernet, branch v3.19

qlcnic: Fix NAPI poll routine for Tx completion

2015-02-05T08:24:08+00:00

After d75b1ade567f ("net: less interrupt masking in NAPI")
driver's NAPI poll routine is expected to return
exact budget value if it wants to be re-called.

Signed-off-by: Shahed Shaikh 
Fixes: d75b1ade567f ("net: less interrupt masking in NAPI")
Signed-off-by: David S. Miller

amd-xgbe: Set RSS enablement based on hardware features

2015-02-05T04:31:51+00:00

The RSS support requires enablement based on the features reported by
the hardware. The setting of this flag is missing. Add support to
set the RSS enablement flag based on the reported hardware features.

Signed-off-by: Tom Lendacky 
Signed-off-by: David S. Miller

amd-xgbe: Adjust for zero-based traffic class count

2015-02-05T04:28:14+00:00

The number of traffic classes reported by the hardware is zero-based
so increment the value returned to get an actual count.

Signed-off-by: Tom Lendacky 
Signed-off-by: David S. Miller

gianfar: correct the bad expression while writing bit-pattern

2015-02-04T21:55:24+00:00

This patch correct the bad expression while writing the
bit-pattern from software's buffer to hardware registers.

Signed-off-by: Sanjeev Sharma 
Signed-off-by: David S. Miller

net/mlx4_core: Fix kernel Oops (mem corruption) when working with more than 80 VFs

2015-02-03T03:38:04+00:00

Commit de966c592802 (net/mlx4_core: Support more than 64 VFs) was meant to
allow up to 126 VFs.  However, due to leaving MLX4_MFUNC_MAX too low, using
more than 80 VFs resulted in memory corruptions (and Oopses) when more than
80 VFs were requested. In addition, the number of slaves was left too high.

This commit fixes these issues.

Fixes: de966c592802 ("net/mlx4_core: Support more than 64 VFs")
Signed-off-by: Jack Morgenstein 
Signed-off-by: Amir Vadai 
Signed-off-by: David S. Miller

sunvnet: set queue mapping when doing packet copies

2015-02-03T02:20:35+00:00

This patch fixes a bug where vnet_skb_shape() didn't set the already-selected
queue mapping when a packet copy was required. This results in using the
wrong queue index for stops/starts, hung tx queues and watchdog timeouts
under heavy load.

Signed-off-by: David L Stevens 
Acked-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

qlge: Fix qlge_update_hw_vlan_features to handle if interface is down

2015-02-03T01:51:14+00:00

Currently qlge_update_hw_vlan_features() will always first put the
interface down, then update features and then bring it up again. But it
is possible to hit this code while the adapter is down and this causes a
non-paired call to napi_disable(), which will get stuck.

This patch fixes it by skipping these down/up actions if the interface
is already down.

Fixes: a45adbe8d352 ("qlge: Enhance nested VLAN (Q-in-Q) handling.")
Cc: Harish Patil 
Signed-off-by: Marcelo Ricardo Leitner 
Signed-off-by: David S. Miller

drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-31T02:17:31+00:00

This patch fixes the following kernel crash,

	WARNING: CPU: 2 PID: 0 at net/ipv4/tcp_input.c:3079 tcp_clean_rtx_queue+0x658/0x80c()
	Call trace:
	[] dump_backtrace+0x0/0x184
	[] show_stack+0x10/0x1c
	[] dump_stack+0x74/0x98
	[] warn_slowpath_common+0x88/0xb0
	[] warn_slowpath_null+0x14/0x20
	[] tcp_clean_rtx_queue+0x654/0x80c
	[] tcp_ack+0x454/0x688
	[] tcp_rcv_established+0x4a4/0x62c
	[] tcp_v4_do_rcv+0x16c/0x350
	[] tcp_v4_rcv+0x8e8/0x904
	[] ip_local_deliver_finish+0x100/0x26c
	[] ip_local_deliver+0xac/0xc4
	[] ip_rcv_finish+0xe8/0x328
	[] ip_rcv+0x24c/0x38c
	[] __netif_receive_skb_core+0x29c/0x7c8
	[] __netif_receive_skb+0x28/0x7c
	[] netif_receive_skb_internal+0x5c/0xe0
	[] napi_gro_receive+0xb4/0x110
	[] xgene_enet_process_ring+0x144/0x338
	[] xgene_enet_napi+0x1c/0x50
	[] net_rx_action+0x154/0x228
	[] __do_softirq+0x110/0x28c
	[] irq_exit+0x8c/0xc0
	[] handle_IRQ+0x44/0xa8
	[] gic_handle_irq+0x38/0x7c
	[...]

Software writes poison data into the descriptor bytes[15:8] and upon
receiving the interrupt, if those bytes are overwritten by the hardware with
the valid data, software also reads bytes[7:0] and executes receive/tx
completion logic.

If the CPU executes the above two reads in out of order fashion, then the
bytes[7:0] will have older data and causing the kernel panic.  We have to
force the order of the reads and thus this patch introduces read memory
barrier between these reads.

Signed-off-by: Iyappan Subramanian 
Signed-off-by: Keyur Chudgar 
Signed-off-by: David S. Miller

ixgbevf: Fix checksum error when using stacked vlan

2015-01-31T02:03:47+00:00

When a skb has multiple vlans and it is CHECKSUM_PARTIAL,
ixgbevf_tx_csum() fails to get the network protocol and checksum related
descriptor fields are not configured correctly because skb->protocol
doesn't show the L3 protocol in this case.

Use first->protocol instead of skb->protocol to get the proper network
protocol.

Signed-off-by: Toshiaki Makita 
Signed-off-by: David S. Miller

ixgbe: Fix checksum error when using stacked vlan

2015-01-31T02:03:47+00:00

When a skb has multiple vlans and it is CHECKSUM_PARTIAL,
ixgbe_tx_csum() fails to get the network protocol and checksum related
descriptor fields are not configured correctly because skb->protocol
doesn't show the L3 protocol in this case.

Use vlan_get_protocol() to get the proper network protocol.

Signed-off-by: Toshiaki Makita 
Signed-off-by: David S. Miller