linux-stable.git/drivers/net/ethernet/sun, branch linux-5.0.y

net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-07T01:38:15+00:00

dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei 
Signed-off-by: David S. Miller

net: sun: cassini: Cleanup license conflict

2019-01-22T19:22:07+00:00

The recent addition of SPDX license identifiers to the files in
drivers/net/ethernet/sun created a licensing conflict.

The cassini driver files contain a proper license notice:

  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as
  * published by the Free Software Foundation; either version 2 of the
  * License, or (at your option) any later version.

but the SPDX change added:

   SPDX-License-Identifier: GPL-2.0

So the file got tagged GPL v2 only while in fact it is licensed under GPL
v2 or later.

It's nice that people care about the SPDX tags, but they need to be more
careful about it. Not everything under (the) sun belongs to ...

Fix up the SPDX identifier and remove the boiler plate text as it is
redundant.

Fixes: c861ef83d771 ("sun: Add SPDX license tags to Sun network drivers")
Signed-off-by: Thomas Gleixner 
Cc: Shannon Nelson 
Cc: Zhu Yanjun 
Cc: David S. Miller 
Cc: netdev@vger.kernel.org
Cc: stable@vger.kernel.org
Acked-by: Shannon Nelson 
Reviewed-by: Zhu Yanjun 
Signed-off-by: David S. Miller

niu: fix missing checks of niu_pci_eeprom_read

2018-12-28T00:19:27+00:00

niu_pci_eeprom_read() may fail, so we should check its return value
before using the read data.

Signed-off-by: Kangjie Lu 
Acked-by: Shannon Nelson 
Signed-off-by: David S. Miller

net: Use of_node_name_eq for node name comparisons

2018-12-06T04:51:05+00:00

Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

For instances using of_node_cmp, this has the side effect of now using
case sensitive comparisons. This should not matter for any FDT based
system which all of these are.

Cc: "David S. Miller" 
Cc: Claudiu Manoil 
Cc: Grygorii Strashko 
Cc: Wingman Kwok 
Cc: Murali Karicheri 
Cc: netdev@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Signed-off-by: Rob Herring 
Signed-off-by: David S. Miller

net: sun: fix return type of ndo_start_xmit function

2018-09-20T04:17:58+00:00

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.

Found by coccinelle.

Signed-off-by: YueHaibing 
Acked-by: Shannon Nelson 
Signed-off-by: David S. Miller

net: ethernet: Convert to using %pOFn instead of device_node.name

2018-08-30T02:41:30+00:00

In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Cc: "David S. Miller" 
Cc: Yisen Zhuang 
Cc: Salil Mehta 
Cc: Sebastian Hesselbarth 
Cc: Felix Fietkau 
Cc: John Crispin 
Cc: Sean Wang 
Cc: Nelson Chang 
Cc: Matthias Brugger 
Cc: Wingman Kwok 
Cc: Murali Karicheri 
Cc: netdev@vger.kernel.org

Signed-off-by: Rob Herring 
Reviewed-by: Matthias Brugger 
Acked-by: Sean Wang 
Signed-off-by: David S. Miller

net: allow ndo_select_queue to pass netdev

2018-07-09T20:41:34+00:00

This patch makes it so that instead of passing a void pointer as the
accel_priv we instead pass a net_device pointer as sb_dev. Making this
change allows us to pass the subordinate device through to the fallback
function eventually so that we can keep the actual code in the
ndo_select_queue call as focused on possible on the exception cases.

Signed-off-by: Alexander Duyck 
Tested-by: Andrew Bowers 
Signed-off-by: Jeff Kirsher

net: ethernet: sun: remove redundant variables adv and lpa and mii_reads

2018-07-05T11:07:40+00:00

Variables adv and lpa are being assigned but are never used hence they
are redundant and can be removed.  Also remove the unncessary mii_reads
too.

Cleans up clang warnings:
warning: variable 'lpa' set but not used [-Wunused-but-set-variable]
warning: variable 'adv' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King 
Signed-off-by: David S. Miller

net: sungem: fix rx checksum support

2018-06-20T05:30:06+00:00

After commit 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE
are friends"), sungem owners reported the infamous "eth0: hw csum failure"
message.

CHECKSUM_COMPLETE has in fact never worked for this driver, but this
was masked by the fact that upper stacks had to strip the FCS, and
therefore skb->ip_summed was set back to CHECKSUM_NONE before
my recent change.

Driver configures a number of bytes to skip when the chip computes
the checksum, and for some reason only half of the Ethernet header
was skipped.

Then a second problem is that we should strip the FCS by default,
unless the driver is updated to eventually support NETIF_F_RXFCS in
the future.

Finally, a driver should check if NETIF_F_RXCSUM feature is enabled
or not, so that the admin can turn off rx checksum if wanted.

Many thanks to Andreas Schwab and Mathieu Malaterre for their
help in debugging this issue.

Signed-off-by: Eric Dumazet 
Reported-by: Meelis Roos 
Reported-by: Mathieu Malaterre 
Reported-by: Andreas Schwab 
Tested-by: Andreas Schwab 
Signed-off-by: David S. Miller

net: ethernet: sun: niu set correct packet size in skb

2018-05-04T17:20:46+00:00

Currently, skb->len and skb->data_len are set to the page size, not
the packet size. This causes the frame check sequence to not be
located at the "end" of the packet resulting in ethernet frame check
errors. The driver does work currently, but stricter kernel facing
networking solutions like OpenVSwitch will drop these packets as
invalid.

These changes set the packet size correctly so that these errors no
longer occur. The length does not include the frame check sequence, so
that subtraction was removed.

Tested on Oracle/SUN Multithreaded 10-Gigabit Ethernet Network
Controller [108e:abcd] and validated in wireshark.

Signed-off-by: Rob Taglang 
Signed-off-by: David S. Miller