linux-stable.git/drivers/net/ethernet/microchip, branch v6.0

net: lan966x: improve error handle in lan966x_fdma_rx_get_frame()

2022-08-31T06:18:17+00:00

Don't just print a warning.  Clean up and return an error as well.

Fixes: c8349639324a ("net: lan966x: Add FDMA functionality")
Signed-off-by: Dan Carpenter 
Reviewed-by: Horatiu Vultur 
Link: https://lore.kernel.org/r/YwjgDm/SVd5c1tQU@kili
Signed-off-by: Jakub Kicinski

net: sparx5: fix handling uneven length packets in manual extraction

2022-08-27T00:25:28+00:00

Packets that are not of length divisible by 4 (e.g. 77, 78, 79) would
have the checksum included up to next multiple of 4 (a 77 bytes packet
would have 3 bytes of ethernet checksum included). The check for the
value expects it in host (Little) endian.

Fixes: f3cad2611a77 ("net: sparx5: add hostmode with phylink support")
Signed-off-by: Casper Andersson 
Reviewed-by: Steen Hegelund 
Link: https://lore.kernel.org/r/20220825084955.684637-1-casper.casan@gmail.com
Signed-off-by: Jakub Kicinski

net: lan966x: fix checking for return value of platform_get_irq_byname()

2022-08-12T10:29:46+00:00

The platform_get_irq_byname() returns non-zero IRQ number
or negative error number. "if (irq)" always true, chang it
to "if (irq > 0)"

Signed-off-by: Li Qiong 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2022-07-21T20:03:39+00:00

No conflicts.

Signed-off-by: Jakub Kicinski

net: lan966x: Fix usage of lan966x->mac_lock when used by FDB

2022-07-19T03:00:00+00:00

When the SW bridge was trying to add/remove entries to/from HW, the
access to HW was not protected by any lock. In this way, it was
possible to have race conditions.
Fix this by using the lan966x->mac_lock to protect parallel access to HW
for this cases.

Fixes: 25ee9561ec622 ("net: lan966x: More MAC table functionality")
Signed-off-by: Horatiu Vultur 
Reviewed-by: Vladimir Oltean 
Signed-off-by: Jakub Kicinski

net: lan966x: Fix usage of lan966x->mac_lock inside lan966x_mac_irq_handler

2022-07-19T03:00:00+00:00

The problem with this spin lock is that it was just protecting the list
of the MAC entries in SW and not also the access to the MAC entries in HW.
Because the access to HW is indirect, then it could happen to have race
conditions.
For example when SW introduced an entry in MAC table and the irq mac is
trying to read something from the MAC.
Update such that also the access to MAC entries in HW is protected by
this lock.

Fixes: 5ccd66e01cbef ("net: lan966x: add support for interrupts from analyzer")
Signed-off-by: Horatiu Vultur 
Reviewed-by: Vladimir Oltean 
Signed-off-by: Jakub Kicinski

net: lan966x: Fix usage of lan966x->mac_lock when entry is removed

2022-07-19T03:00:00+00:00

To remove an entry to the MAC table, it is required first to setup the
entry and then issue a command for the MAC to forget the entry.
So if it happens for two threads to remove simultaneously an entry
in MAC table then it would be a race condition.
Fix this by using lan966x->mac_lock to protect the HW access.

Fixes: e18aba8941b40 ("net: lan966x: add mactable support")
Signed-off-by: Horatiu Vultur 
Reviewed-by: Vladimir Oltean 
Signed-off-by: Jakub Kicinski

net: lan966x: Fix usage of lan966x->mac_lock when entry is added

2022-07-19T02:59:59+00:00

To add an entry to the MAC table, it is required first to setup the
entry and then issue a command for the MAC to learn the entry.
So if it happens for two threads to add simultaneously an entry in MAC
table then it would be a race condition.
Fix this by using lan966x->mac_lock to protect the HW access.

Fixes: fc0c3fe7486f2 ("net: lan966x: Add function lan966x_mac_ip_learn()")
Signed-off-by: Horatiu Vultur 
Reviewed-by: Vladimir Oltean 
Signed-off-by: Jakub Kicinski

net: lan966x: Fix taking rtnl_lock while holding spin_lock

2022-07-19T02:59:59+00:00

When the HW deletes an entry in MAC table then it generates an
interrupt. The SW will go through it's own list of MAC entries and if it
is not found then it would notify the listeners about this. The problem
is that when the SW will go through it's own list it would take a spin
lock(lan966x->mac_lock) and when it notifies that the entry is deleted.
But to notify the listeners it taking the rtnl_lock which is illegal.

This is fixed by instead of notifying right away that the entry is
deleted, move the entry on a temp list and once, it checks all the
entries then just notify that the entries from temp list are deleted.

Fixes: 5ccd66e01cbe ("net: lan966x: add support for interrupts from analyzer")
Signed-off-by: Horatiu Vultur 
Reviewed-by: Vladimir Oltean 
Signed-off-by: Jakub Kicinski

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2022-07-07T19:07:37+00:00

No conflicts.

Signed-off-by: Jakub Kicinski