linux-stable.git/drivers/net/ethernet/micrel, branch linux-3.7.y

drivers/net: fix tasklet misuse issue

2012-11-15T02:50:10+00:00

In commit 175c0dff, drivers uses tasklet_kill to avoid put disabled tasklet
on the tasklet vec. But some of the drivers uses tasklet_init & tasklet_disable
in the driver init code, then tasklet_enable when it is opened. This makes
tasklet_enable on a killed tasklet and make ksoftirqd crazy then. Normally,
drivers should use tasklet_init/tasklet_kill on device open/remove, and use
tasklet_disable/tasklet_enable on device suspend/resume.

Reported-by: Peter Wu 
Tested-by: Peter Wu 
Signed-off-by: Xiaotian Feng 
Cc: "David S. Miller" 
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: David S. Miller

drivers/net: use tasklet_kill in device remove/close process

2012-11-03T19:10:15+00:00

Some driver uses tasklet_disable in device remove/close process,
tasklet_disable will inc tasklet->count and return. If the tasklet
is not handled yet because some softirq pressure, the tasklet will
placed on the tasklet_vec, never have a chance to excute. This might
lead to ksoftirqd heavy loaded, wakeup with pending_softirq, but
tasklet is disabled. tasklet_kill should be used in this case.

Signed-off-by: Xiaotian Feng 
Cc: "David S. Miller" 
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller

ethernet: Use eth_random_addr

2012-07-17T05:38:27+00:00

Convert the existing uses of random_ether_addr to
the new eth_random_addr.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

ksz884x: fix Endian

2012-07-11T08:31:23+00:00

ETH_P_IP is host Endian, skb->protocol is big Endian, when
compare them, Using htons on skb->protocol is wrong.

And fix two code style issues: indentation and remove
unnecessary parentheses.

CC: Tristram Ha 
CC: Ben Hutchings 
CC: Joe Perches 
Signed-off-by: Li RongQing 
Signed-off-by: David S. Miller

ksz884x: remove unnecessary setting of skb->dev

2012-07-11T06:24:57+00:00

skb->dev is being unnecessarily set during ring init.  It is already being set
to the proper value when eth_type_trans is called on packet receive, and the
skb->dev is not referenced anywhere else in the code.

Signed-off-by: Jon Mason 
Signed-off-by: David S. Miller

drivers/net/ethernet: Fix non-kernel-doc comments with kernel-doc start markers

2012-07-11T06:13:46+00:00

Convert doxygen (or similar) formatted comments to kernel-doc or
unformatted comment.  Delete a few that are content-free.

Signed-off-by: Ben Hutchings 
Acked-by: Jeff Kirsher 
Signed-off-by: David S. Miller

drivers/net/ethernet: Fix (nearly-)kernel-doc comments for various functions

2012-07-11T06:13:46+00:00

Fix incorrect start markers, wrapped summary lines, missing section
breaks, incorrect separators, and some name mismatches.  Delete
a few that are content-free.

Signed-off-by: Ben Hutchings 
Acked-by: Jeff Kirsher 
Signed-off-by: David S. Miller

net/ethernet: ks8851_mll unregister_netdev() before freeing

2012-06-07T20:15:09+00:00

We added another error condition here, but if we were to hit it then
we need to unregister_netdev() before doing the free_netdev().
Otherwise we would hit the BUG_ON() in free_netdev():

	BUG_ON(dev->reg_state != NETREG_UNREGISTERED);

Signed-off-by: Dan Carpenter 
Tested-by: Raffaele Recalcati 
Signed-off-by: David S. Miller

net/ethernet: ks8851_mll mac address configuration support added

2012-06-04T15:43:00+00:00

Signed-off-by: Raffaele Recalcati 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2012-05-17T02:17:37+00:00