linux-stable.git/drivers/net/ethernet/intel, branch v3.17

i40evf: Fix TSO and hw checksums for non-accelerated vlan packets.

2014-08-26T00:27:09+00:00

This device claims TSO and checksum support for vlans.  It also
allows a user to control vlan acceleration offloading.  As such,
it is possible to turn off vlan acceleration and configure a vlan
which will continue to support TSO and hw checksums.

In such situation the packet passed down the the device will contain
a vlan header and skb->protocol will be set to ETH_P_8021Q.
The device assumes that skb->protocol contains network protocol
value and uses that value to set up TSO and checksum information.
This results in corrupted frames sent on the wire.

This patch extract the protocol value correctly and corrects TSO
and checksums for non-accelerated traffic.

Fix this by using vlan_get_protocol() helper.

CC: Jeff Kirsher 
CC: Jesse Brandeburg 
CC: Bruce Allan 
CC: Carolyn Wyborny 
CC: Don Skidmore 
CC: Greg Rose 
CC: Alex Duyck 
CC: John Ronciak 
CC: Mitch Williams 
CC: Linux NICS 
CC: e1000-devel@lists.sourceforge.net
Signed-off-by: Vladislav Yasevich 
Signed-off-by: David S. Miller

i40e: Fix TSO and hw checksums for non-accelerated vlan packets.

2014-08-26T00:27:09+00:00

This device claims TSO and checksum support for vlans.  It also
allows a user to control vlan acceleration offloading.  As such,
it is possible to turn off vlan acceleration and configure a vlan
which will continue to support TSO and hw checksums.

In such situation the packet passed down the the device will contain
a vlan header and skb->protocol will be set to ETH_P_8021Q.
The device assumes that skb->protocol contains network protocol
value and uses that value to set up TSO and checksum information.
This results in corrupted frames sent on the wire.

This patch extract the protocol value correctly and corrects TSO
and checksums for non-accelerated traffic.

Fix this by using vlan_get_protocol() helper.

CC: Jeff Kirsher 
CC: Jesse Brandeburg 
CC: Bruce Allan 
CC: Carolyn Wyborny 
CC: Don Skidmore 
CC: Greg Rose 
CC: Alex Duyck 
CC: John Ronciak 
CC: Mitch Williams 
CC: Linux NICS 
CC: e1000-devel@lists.sourceforge.net
Signed-off-by: Vladislav Yasevich 
Signed-off-by: David S. Miller

e1000: Fix TSO for non-accelerated vlan traffic

2014-08-26T00:27:09+00:00

This device claims TSO and checksum support for vlans.  It also
allows a user to control vlan acceleration offloading.  As such,
it is possible to turn off vlan acceleration and configure a vlan
which will continue to support TSO.

In such situation the packet passed down the the device will contain
a vlan header and skb->protocol will be set to ETH_P_8021Q.
The device assumes that skb->protocol contains network protocol
value and uses that value to set up TSO and checksum information.
This will results in corrupted frames sent on the wire.

This patch extract the protocol value correctly and corrects TSO
for non-accelerated traffic.

CC: Jeff Kirsher 
CC: Jesse Brandeburg 
CC: Bruce Allan 
CC: Carolyn Wyborny 
CC: Don Skidmore 
CC: Greg Rose 
CC: Alex Duyck 
CC: John Ronciak 
CC: Mitch Williams 
CC: Linux NICS 
CC: e1000-devel@lists.sourceforge.net
Signed-off-by: Vladislav Yasevich 
Signed-off-by: David S. Miller

e1000e: Fix TSO with non-accelerated vlans

2014-08-26T00:27:09+00:00

This device claims  TSO support for vlans.  It also allows a
user to control vlan acceleration offloading.  As such, it is
possible to turn off vlan acceleration and configure a vlan
which will continue to support TSO.

In such situation the packet passed down the the device will contain
a vlan header and skb->protocol will be set to ETH_P_8021Q.
The device assumes that skb->protocol contains network protocol
value and uses that value to set up TSO information.  This results
in corrupted frames sent on the wire.  Corruptions include
incorrect IP total length and invalid IP checksum.

This patch extract the protocol value correctly and corrects TSO
for non-accelerated traffic.

CC: Jeff Kirsher 
CC: Jesse Brandeburg 
CC: Bruce Allan 
CC: Carolyn Wyborny 
CC: Don Skidmore 
CC: Greg Rose 
CC: Alex Duyck 
CC: John Ronciak 
CC: Mitch Williams 
CC: Linux NICS 
CC: e1000-devel@lists.sourceforge.net
Signed-off-by: Vladislav Yasevich 
Signed-off-by: David S. Miller

i40e: fix PTP bug

2014-08-15T11:00:39+00:00

The receive hang detection routine was never being run when
PTP was enabled.

Change-ID: I200f35b0f3190d31b595df89d678f4c8a2131ba0
Signed-off-by: Jesse Brandeburg 
Tested-by: Jim Young 
Signed-off-by: Jeff Kirsher

i40e: Fix a few potential VF dereferences

2014-08-15T10:50:37+00:00

In some functions we might be doing potential dereference
without a check. This patch puts the check in place for all these
functions. Also fix the "for loops" so that we increment VF at the
right place so that we always do it even if we are short-circuiting
the loop through continue.

Change-ID: Id4276cfb1e841031bb7b6d6790c414242f364a9f
Signed-off-by: Anjali Singhai Jain 
Tested-by: Jim Young 
Signed-off-by: Jeff Kirsher

i40e: Fix for recent kernel panic

2014-08-15T10:39:08+00:00

Whenever we get a Tx hang we issue a PFR, which means we send AQ
messages to VFS about the reset coming. Unfortunately with the recent
fix to be able to send messages to all VFS which earlier was not
happening at all we now are sending messages to not just the VFS that
are up but also to VFS that are not up.  AQ complains about this and
sends us an error in ARQ called LAN overflow event for a queue. We
check if the queue belongs to a VF and if it does we try to send a
vc_notify_vf_reset message to that VF. Well if the VF is not up/enabled
we will be entering this function with a non-active VF id. In this
function we were assuming VF struct is populated but it won't be if
the VF is not active.

Change-ID: Ic6733cda4582d3609fe6d83b2872bb2dcdc73f4a
Signed-off-by: Ashish N Shah 
Signed-off-by: Anjali Singhai Jain 
Tested-by: Jim Young 
Signed-off-by: Jeff Kirsher

Merge tag 'pci-v3.17-changes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2014-08-15T00:10:33+00:00

Pull DEFINE_PCI_DEVICE_TABLE removal from Bjorn Helgaas:
 "Part two of the PCI changes for v3.17:

    - Remove DEFINE_PCI_DEVICE_TABLE macro use (Benoit Taine)

  It's a mechanical change that removes uses of the
  DEFINE_PCI_DEVICE_TABLE macro.  I waited until later in the merge
  window to reduce conflicts, but it's possible you'll still see a few"

* tag 'pci-v3.17-changes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci:
  PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use

PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use

2014-08-12T18:15:14+00:00

We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines.  This issue was reported by checkpatch.

A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):

// 

@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@

- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;

// 

[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine 
Signed-off-by: Bjorn Helgaas

e1000e: delete excessive space character in debug message

2014-08-12T08:16:19+00:00

There is an excessive space character between the word and the
period in the debug message. So delete it.

Signed-off-by: Jean Sacren 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher