linux-stable.git/drivers/net/ethernet/intel, branch v3.12

igb: Avoid uninitialized advertised variable in eee_set_cur

2013-10-02T20:31:48+00:00

eee_get_cur assumes that the output data is already zeroed. It can
read-modify-write the advertised field:

              if (ipcnfg & E1000_IPCNFG_EEE_100M_AN)
2594			edata->advertised |= ADVERTISED_100baseT_Full;

This is ok for the normal ethtool eee_get call, which always
zeroes the input data before.

But eee_set_cur also calls eee_get_cur and it did not zero the input
field. Later on it then compares agsinst the field, which can contain partial
stack garbage.

Zero the input field in eee_set_cur() too.

Cc: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org
Signed-off-by: Andi Kleen 
Acked-by: Jeff Kirsher 
Signed-off-by: David S. Miller

i40e: clean up coccicheck reported errors

2013-09-27T12:24:05+00:00

coccicheck shows:

drivers/net/ethernet/intel/i40e/i40e_adminq.c:704:2-8: Replace memcpy
with struct assignment
drivers/net/ethernet/intel/i40e/i40e_adminq.c:763:1-7: Replace memcpy
with struct assignment
drivers/net/ethernet/intel/i40e/i40e_adminq.c:810:2-8: Replace memcpy
with struct assignment
drivers/net/ethernet/intel/i40e/i40e_common.c:510:2-8: Replace memcpy
with struct assignment

Fix each of them with a *a = *b;

Signed-off-by: Jesse Brandeburg 
Tested-by: Kavindya Deegala 
Signed-off-by: Jeff Kirsher

i40e: better return values

2013-09-27T12:22:30+00:00

As mentioned by Joe Perches, clean up return values in some functions
making sure to have consistent return types, not mixing types.

A couple of Joe's comments suggested returning void, but since
the functions in question are ndo defined, the return values are fixed.
So make a comment in the header that notes this is a function called by
net_device_ops.

v2: fix post increment bug in return

CC: Joe Perches 
Signed-off-by: Jesse Brandeburg 
Tested-by: Kavindya Deegala 
Signed-off-by: Jeff Kirsher

i40e: convert ret to aq_ret

2013-09-27T11:50:58+00:00

When calling admin queue functions the driver should use aq_ret
variable to help make clear that the return value is not a regular
return variable.

This allows for clean up of the return types that were previously
converted to int.

Signed-off-by: Jesse Brandeburg 
Tested-by: Kavindya Deegala 
Signed-off-by: Jeff Kirsher

i40e: small clean ups from review

2013-09-27T11:50:50+00:00

As mentioned by Joe Perches clean up a loop flow.

Signed-off-by: Jesse Brandeburg 
CC: Joe Perches 
Tested-by: Kavindya Deegala 
Signed-off-by: Jeff Kirsher

i40e: use common failure flow

2013-09-27T11:50:46+00:00

As mentioned by Joe Perches, we should be using
foo = alloc(...)
if (!foo)
	return -ENOMEM;

return 0;

Signed-off-by: Jesse Brandeburg 
CC: Joe Perches 
Tested-by: Kavindya Deegala 
Signed-off-by: Jeff Kirsher

igb: Fix ethtool loopback test for 82580 copper

2013-09-27T11:50:38+00:00

Add back 82580 loopback tests to ethtool.

Signed-off-by: Todd Fujinaka 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

e1000e: fix overrun of PHY RAR array

2013-09-13T17:19:56+00:00

When copying the MAC RAR registers to PHY there is an error in the
calculation of the rar_entry_count, which causes a write of unknown/
undefined register space in the MAC to unknown/undefined register space in
the PHY.

This patch fixes the overrun with writing to the PHY RAR and also fixes the
ethtool offline register tests so that the correctly addressed registers
have the appropriate bitmasks for R/W and RO bits for affected parts.

Shawn Rader gets credit for finding and fixing the register overrun.

Signed-off-by: Dave Ertman 
CC: Shawn Rader 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

e1000e: cleanup boolean comparison to true

2013-09-13T17:06:55+00:00

Removing a comparison to the boolean value true where simply interrogating
the lvalue will produce the same result.

Signed-off-by: David Ertman 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

ixgbe: fix ethtool reporting of supported links for SFP modules

2013-09-13T16:58:12+00:00

This patch resolves an issue where the driver will display incorrect info
for Q/SFP+ modules that were inserted after the driver has been loaded.

This patch adds a call to identify_phy() in ixgbe_get_settings() prior to
calling get_link_capabilities() which needs the PHY data in order to
determine the correct settings.

Signed-off-by: Emil Tantilov 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher