linux-stable.git/drivers/net/ethernet/intel, branch linux-3.7.y

e1000e: enable ECC on I217/I218 to catch packet buffer memory errors

2013-02-14T18:48:00+00:00

commit 286003048aaef49b26bb9d93611dc69085e8982e upstream.

In rare instances, memory errors have been detected in the internal packet
buffer memory on I217/I218 when stressed under certain environmental
conditions.  Enable Error Correcting Code (ECC) in hardware to catch both
correctable and uncorrectable errors.  Correctable errors will be handled
by the hardware.  Uncorrectable errors in the packet buffer will cause the
packet to be received with an error indication in the buffer descriptor
causing the packet to be discarded.  If the uncorrectable error is in the
descriptor itself, the hardware will stop and interrupt the driver
indicating the error.  The driver will then reset the hardware in order to
clear the error and restart.

Both types of errors will be accounted for in statistics counters.

Signed-off-by: Bruce Allan 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

igb: release already assigned MSI-X interrupts if setup fails

2013-01-21T19:44:44+00:00

commit 52285b762b3681669215bf1d17ca6143448ab7d3 upstream.

During MSI-X setup the system might run out of vectors. If this happens the
already assigned vectors for this NIC should be freed before trying the
disable MSI-X. Failing to do so results in the following oops.

kernel BUG at drivers/pci/msi.c:341!
[...]
Call Trace:
 [] pci_disable_msix+0x3d/0x60
 [] igb_reset_interrupt_capability+0x27/0x5c [igb]
 [] igb_clear_interrupt_scheme+0x26/0x2d [igb]
 [] igb_request_irq+0x73/0x297 [igb]
 [] __igb_open+0xc8/0x223 [igb]
 [] igb_open+0x13/0x15 [igb]
 [] __dev_open+0xbf/0x120
 [] __dev_change_flags+0xa1/0x180
 [] dev_change_flags+0x28/0x70
 [] devinet_ioctl+0x5b7/0x620
 [] inet_ioctl+0x88/0xa0
 [] sock_do_ioctl+0x30/0x70
 [] sock_ioctl+0x72/0x270
 [] do_vfs_ioctl+0x8c/0x340
 [] sys_ioctl+0xa1/0xb0
 [] system_call_fastpath+0x16/0x1b
Code: 48 89 df e8 1f 40 ed ff 4d 39 e6 49 8b 45 10 75 b6 48 83 c4 18 5b 41 5c 41 5d 41 5e 41 5f c9 c3 48 8b 7b 20 e8 3e 91 db ff eb ae <0f> 0b eb fe 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 1f 44 00 00
RIP  [] free_msi_irqs+0x124/0x130
 RSP 

Signed-off-by: Stefan Assmann 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher 
Signed-off-by: Abdallah Chatila

ixgbe: PTP get_ts_info missing software support

2012-11-01T15:22:34+00:00

This patch corrects the ethtool get_ts_info functon which did not state that
software timestamping was supported, even though it is.

Signed-off-by: Jacob Keller 
CC: Stable  [3.5]
Tested-by: Stephen Ko 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000e: Change wthresh to 1 to avoid possible Tx stalls

2012-10-11T02:59:18+00:00

This patch originated from Hiroaki SHIMODA but has been modified
by Intel with some minor cleanups and additional commit log text.

Denys Fedoryshchenko and others reported Tx stalls on e1000e with
BQL enabled.  Issue was root caused to hardware delays. They were
introduced because some of the e1000e hardware with transmit
writeback bursting enabled, waits until the driver does an
explict flush OR there are WTHRESH descriptors to write back.

Sometimes the delays in question were on the order of seconds,
causing visible lag for ssh sessions and unacceptable tx
completion latency, especially for BQL enabled kernels.

To avoid possible Tx stalls, change WTHRESH back to 1.

The current plan is to investigate a method for re-enabling
WTHRESH while not harming BQL, but those patches will be later
for net-next if they work.

please enqueue for stable since v3.3 as this bug was introduced in
commit 3f0cfa3bc11e7f00c9994e0f469cbc0e7da7b00c
Author: Tom Herbert 
Date:   Mon Nov 28 16:33:16 2011 +0000

    e1000e: Support for byte queue limits

    Changes to e1000e to use byte queue limits.

Reported-by: Denys Fedoryshchenko 
Tested-by: Denys Fedoryshchenko 
Signed-off-by: Hiroaki SHIMODA 
CC: eric.dumazet@gmail.com
CC: therbert@google.com
Signed-off-by: Jesse Brandeburg 
Signed-off-by: David S. Miller

e1000e: add device IDs for i218

2012-10-09T10:03:01+00:00

i218 is the next-generation LOM that will be available on systems with the
Lynx Point LP Platform Controller Hub (PCH) chipset from Intel.  This patch
provides the initial support of those devices.

Signed-off-by: Bruce Allan 
Signed-off-by: Jeff Kirsher

ixgbe/ixgbevf: Limit maximum jumbo frame size to 9.5K to avoid Tx hangs

2012-10-09T09:53:53+00:00

This change limits the PF/VF driver to 9.5K max jumbo frame size in order
prevent a possible Tx hang in the adapter when sending frames between
pools.

All of the parts in ixgbe support a maximum frame of 15.5K for standard
traffic, however with SR-IOV or DCB enabled they should be limiting the
MTU size to 9.5K.  Instead of adding extra checks which would have to
change the MTU when we go into or out of these modes it is preferred to
just use a standard 9.5K MTU limit for all modes so that this extra
overhead can be avoided.

Signed-off-by: Alexander Duyck 
Tested-by: Phil Schmitt 
Tested-by: Sibai Li 
Signed-off-by: Jeff Kirsher

ixgbevf: Set the netdev number of Tx queues

2012-10-09T09:08:39+00:00

The driver was not setting the number of real Tx queues in the net_device
structure.  This caused some serious issues such as Tx hangs and extremely
poor performance with some usages of the driver.

The issue is best observed by running:

iperf -c  -P 

Where n is greater than one.  The greater the value of n the more likely
the problem is to show up.

Signed-off-by: Greg Rose 
Signed-off-by: Jeff Kirsher

ixgbe: add support for X540-AT1

2012-10-03T15:38:30+00:00

This patch adds device support for Ethernet Controller X540-AT1.

Signed-off-by: Josh Hay 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

ixgbe: fix poll loop for FDIRCTRL.INIT_DONE bit

2012-10-03T15:36:11+00:00

The loop in ixgbe_reinit_fdir_tables_82599() only polls for up to 100us
resulting in failures to update the FDIR filter table at 1Gbps and 10Gbps
when under load.

The poll times for FDIRCTRL.INIT_DONE are 55us, 550us and 5.5ms for 10Gbps,
1Gbps and 100Mbps respectively.

This patch sets the wait time to be the same as in ixgbe_fdir_enable_82599()

Reported-by: Bhushan 
Signed-off-by: Emil Tantilov 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher

ixgbe: fix PTP ethtool timestamping function

2012-10-03T15:35:00+00:00

This patch fixes a development issue that occurred due to invalid modes reported
in the ethtool get_ts_info function. The issue is resolved by removing
unsupported modes from the Rx supported list.

CC: stable  [3.5]
Signed-off-by: Jacob Keller 
Tested-by: Phil Schmitt 
Signed-off-by: Jeff Kirsher