linux-stable.git/drivers/net/ethernet/broadcom, branch v4.4

bnx2x: Prevent FW assertion when using Vxlan

2015-12-18T21:34:32+00:00

FW has a rare corner case in which a fragmented packet using lots
of frags would not be linearized, causing the FW to assert while trying
to transmit the packet.

To prevent this, we need to make sure the window of fragements containing
MSS worth of data contains 1 BD less than for regular packets due to
the additional parsing BD.

Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: David S. Miller

bnxt_en: Implement missing tx timeout reset logic.

2015-12-12T04:34:06+00:00

The reset logic calls bnxt_close_nic() and bnxt_open_nic() under rtnl_lock
from bnxt_sp_task.  BNXT_STATE_IN_SP_TASK must be cleared before calling
bnxt_close_nic() to avoid deadlock.

v2: Fixed white space error.  Thanks Dave.

Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: Don't cancel sp_task from bnxt_close_nic().

2015-12-12T04:34:06+00:00

When implementing driver reset from tx_timeout in the next patch,
bnxt_close_nic() will be called from the sp_task workqueue.  Calling
cancel_work() on sp_task will hang the workqueue.

Instead, set a new bit BNXT_STATE_IN_SP_TASK when bnxt_sp_task() is running.
bnxt_close_nic() will wait for BNXT_STATE_IN_SP_TASK to clear before
proceeding.

Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: Change bp->state to bitmap.

2015-12-12T04:34:06+00:00

This allows multiple independent bits to be set for various states.
Subsequent patches to implement tx timeout reset will require this.

Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: Fix bitmap declaration to work on 32-bit arches.

2015-12-12T04:34:05+00:00

The declaration of the bitmap vf_req_snif_bmap using fixed array of
unsigned long will only work on 64-bit archs.  Use DECLARE_BITMAP instead
which will work on all archs.

Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: Setup uc_list mac filters after resetting the chip.

2015-12-03T20:07:13+00:00

Call bnxt_cfg_rx_mode() in bnxt_init_chip() to setup uc_list and
mc_list mac address filters.  Before the patch, uc_list is not
setup again after chip reset (such as ethtool ring size change)
and macvlans don't work any more after that.

Modify bnxt_cfg_rx_mode() to return error codes appropriately so
that the init chip sequence can detect any failures.

Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: enforce proper storing of MAC address

2015-12-03T20:07:13+00:00

For PF, the bp->pf.mac_addr always holds the permanent MAC
addr assigned by the HW.  For VF, the bp->vf.mac_addr always
holds the administrator assigned VF MAC addr. The random
generated VF MAC addr should never get stored to bp->vf.mac_addr.
This way, when the VF wants to change the MAC address, we can tell
if the adminstrator has already set it and disallow the VF from
changing it.

v2: Fix compile error if CONFIG_BNXT_SRIOV is not set.

Signed-off-by: Jeffrey Huang 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: Fixed incorrect implementation of ndo_set_mac_address

2015-12-03T20:07:13+00:00

The existing ndo_set_mac_address only copies the new MAC addr
and didn't set the new MAC addr to the HW. The correct way is
to delete the existing default MAC filter from HW and add
the new one. Because of RFS filters are also dependent on the
default mac filter l2 context, the driver must go thru
close_nic() to delete the default MAC and RFS filters, then
open_nic() to set the default MAC address to HW.

Signed-off-by: Jeffrey Huang 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnx2x: Fix vxlan removal

2015-11-20T15:58:31+00:00

Commmit ac7eccd4d48fc "bnx2x: track vxlan port count" contains a bug -
Instead of achieving the required goal, vxlan configuration would not
be removed since we're decrementing the port instead of the counter.

CC: Jiri Benc 
Signed-off-by: Yuval Mintz 
Signed-off-by: David S. Miller

bnx2x: Fix VLANs null-pointer for 57710, 57711

2015-11-16T20:13:01+00:00

Commit 05cc5a39ddb7 "bnx2x: add vlan filtering offload" introduced
a regression in regard for vlans for 57710, 57711 adapters -
Loading 8021q module on a machine with such an adapter would cause
a null pointer dereference, as the driver mistakenly publishes it
has capabilities for vlan CTAG filtering.

Reported-by: Otto Sabart 
Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: David S. Miller