linux-stable.git/drivers/net/ethernet/broadcom, branch v3.3

bnx2x: fix memory leak in bnx2x_init_firmware()

2012-03-16T08:57:26+00:00

When cycling the interface down and up, bnx2x_init_firmware() knows that
the firmware is already loaded, but nevertheless it allocates certain
arrays anew (init_data, init_ops, init_ops_offsets, iro_arr). The old
arrays are leaked.

Fix the leaks by returning early if the firmware was already loaded.
Because if the firmware is loaded, so are the arrays.

Signed-off-by: Michal Schmidt 
Acked-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: fix a crash on corrupt firmware file

2012-03-16T08:57:26+00:00

If the requested firmware is deemed corrupt and then released, reset the
pointer to NULL in order to avoid double-freeing it in
bnx2x_release_firmware() or dereferencing it in bnx2x_init_firmware().

Signed-off-by: Michal Schmidt 
Acked-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: FCoE statistics id fixed

2012-03-13T00:01:25+00:00

FCoE statistics ids were distinguished from the L2's statistics ids.
However, not all of the change was committed. This causes a possible
collision of indices when FCoE is present.

This patch fixes the issue.

Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: dcb bit indices flags used as bits

2012-03-13T00:01:25+00:00

DCB flags were updated using the flags' bit offsets instead of
the actual bits. This is now fixed.

Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: added cpu_to_le16 when preparing ramrod's data

2012-03-13T00:01:25+00:00

Fixed endianess issue when passing arguments to FW.

Signed-off-by: Ariel Elior 
Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: pfc statistics counts pfc events twice

2012-03-13T00:01:25+00:00

When pfc statistics were counted, the delta change from last count
was summed twice. This fixes the issue.

Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

tg3: Fix to use multi queue BQL interfaces

2012-03-06T06:19:08+00:00

Fix tg3 to use BQL multi queue related netdev interfaces since the
device supports multi queue.

Signed-off-by: Tom Herbert 
Reported-by: Christoph Lameter 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

tg3: Fix tg3_get_stats64 for 5700 / 5701 devs

2012-02-29T18:46:05+00:00

tg3_get_stats64() takes tp->lock when dealing with non-serdes bcm5700
and bcm5701 devices.  However, functions that call tg3_halt() have
already acquired tp->lock.  When tg3_get_stats64() is called in
tg3_halt(), deadlock will occur.

This patch fixes the problem by separating the stat gathering code into
a new tg3_get_nstats() function.  tg3_get_stats64() is recoded to call
this function and take tp->lock.  The code that takes tp->lock in
tg3_calc_crc_errors() has been removed.  Function signatures have been
cleaned up too.

Signed-off-by: Matt Carlson 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

ethernet/broadcom: ip6_route_output() never returns NULL.

2012-02-22T20:30:14+00:00

ip6_route_output() never returns NULL, so it is wrong to
check if the return value is NULL.

Signed-off-by: RongQing.Li 
Signed-off-by: David S. Miller

b44: remove __exit from b44_pci_exit()

2012-02-19T23:57:51+00:00

WARNING: drivers/net/ethernet/broadcom/built-in.o(.init.text+0x5d): Section mismatch in reference from the function b44_init() to the function .exit.text:b44_pci_exit()

module exits with b44_cleanup()

Signed-off-by: Nikola Pajkovsky 
Signed-off-by: David S. Miller