linux-stable.git/drivers/net/ethernet/broadcom, branch v3.2.26

bnx2x: fix panic when TX ring is full

2012-07-25T03:11:40+00:00

commit bc14786a100cc6a81cd060e8031ec481241b418c upstream.

There is a off by one error in the minimal number of BD in
bnx2x_start_xmit() and bnx2x_tx_int() before stopping/resuming tx queue.

A full size GSO packet, with data included in skb->head really needs
(MAX_SKB_FRAGS + 4) BDs, because of bnx2x_tx_split()

This error triggers if BQL is disabled and heavy TCP transmit traffic
occurs.

bnx2x_tx_split() definitely can be called, remove a wrong comment.

Reported-by: Tomas Hruby 
Signed-off-by: Eric Dumazet 
Cc: Eilon Greenstein 
Cc: Yaniv Rosner 
Cc: Merav Sicron 
Cc: Tom Herbert 
Cc: Robert Evans 
Cc: Willem de Bruijn 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

bnx2x: fix checksum validation

2012-07-25T03:11:39+00:00

commit d6cb3e41386f20fb0777d0b59a2def82c65d37f7 upstream.

bnx2x driver incorrectly sets ip_summed to CHECKSUM_UNNECESSARY on
encapsulated segments. TCP stack happily accepts frames with bad
checksums, if they are inside a GRE or IPIP encapsulation.

Our understanding is that if no IP or L4 csum validation was done by the
hardware, we should leave ip_summed as is (CHECKSUM_NONE), since
hardware doesn't provide CHECKSUM_COMPLETE support in its cqe.

Then, if IP/L4 checksumming was done by the hardware, set
CHECKSUM_UNNECESSARY if no error was flagged.

Patch based on findings and analysis from Robert Evans

Signed-off-by: Eric Dumazet 
Cc: Eilon Greenstein 
Cc: Yaniv Rosner 
Cc: Merav Sicron 
Cc: Tom Herbert 
Cc: Robert Evans 
Cc: Willem de Bruijn 
Acked-by: Eilon Greenstein 
Signed-off-by: David S. Miller 
[bwh: Backported to 3.2: adjust context, indentation]
Signed-off-by: Ben Hutchings

tg3: Apply short DMA frag workaround to 5906

2012-07-25T03:10:56+00:00

commit b7abee6ef888117f92db370620ebf116a38e3f4d upstream.

5906 devices also need the short DMA fragment workaround.  This patch
makes the necessary change.

Signed-off-by: Matt Carlson 
Tested-by: Christian Kujau 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

tg3: Avoid panic from reserved statblk field access

2012-05-20T21:56:37+00:00

[ Upstream commit f891ea1634ce41f5f47ae40d8594809f4cd2ca66 ]

When RSS is enabled, interrupt vector 0 does not receive any rx traffic.
The rx producer index fields for vector 0's status block should be
considered reserved in this case.  This patch changes the code to
respect these reserved fields, which avoids a kernel panic when these
fields take on non-zero values.

Signed-off-by: Matt Carlson 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

tg3: Fix 5717 serdes powerdown problem

2012-04-13T15:33:45+00:00

[ Upstream commit 085f1afc56619bda424941412fdeaff1e32c21dc ]

If port 0 of a 5717 serdes device powers down, it hides the phy from
port 1.  This patch works around the problem by keeping port 0's phy
powered up.

Signed-off-by: Matt Carlson 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

bnx2x: Fix 5461x LED

2011-11-24T00:07:55+00:00

Fix port identify test on 5461x PHY by driving LEDs through MDIO.

Signed-off-by: Yaniv Rosner 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

b44: Use dev_kfree_skb_irq() in b44_tx()

2011-11-23T21:40:31+00:00

Reported issues when using dev_kfree_skb() on UP systems and
systems with low numbers of cores.  dev_kfree_skb_irq() will
properly save IRQ state before freeing the skb.

Tested on 3.1.1 and 3.2_rc2

Example of reproducible trace of kernel 3.1.1
------------[ cut here ]------------
   WARNING: at kernel/softirq.c:159 local_bh_enable+0x32/0x79()
   ...
   Pid: 0, comm: swapper Not tainted 3.1.1-gentoo #1
   Call Trace:
    [] warn_slowpath_common+0x65/0x7a
    [] ? local_bh_enable+0x32/0x79
    [] warn_slowpath_null+0xf/0x13
    [] local_bh_enable+0x32/0x79
    [] destroy_conntrack+0x7c/0x9b
    [] nf_conntrack_destroy+0x1f/0x26
    [] skb_release_head_state+0x74/0x83
    [] __kfree_skb+0xb/0x6b
    [] consume_skb+0x24/0x26
    [] b44_poll+0xaa/0x449
    [] net_rx_action+0x3f/0xea
    [] __do_softirq+0x5f/0xd5
    [] ? local_bh_enable+0x79/0x79
      [] ? irq_exit+0x34/0x8d
    [] ? do_IRQ+0x74/0x87
    [] ? common_interrupt+0x29/0x30
    [] ? default_idle+0x29/0x3e
    [] ? cpu_idle+0x2f/0x5d
    [] ? rest_init+0x79/0x7b
    [] ? start_kernel+0x297/0x29c
    [] ? i386_start_kernel+0xb0/0xb7
   ---[ end trace 583f33bb1aa207a9 ]---

Signed-off-by: Xander Hover 
Signed-off-by: David S. Miller

bnx2x: cache-in compressed fw image

2011-11-16T22:37:15+00:00

Re-request fw from fs may fail for different reasons, once the fw was
loaded we won't release it until driver is removed.

This also resolves the boot problem when initial fw is located on initrd,
but rootfs is still unavailable, in this case device reset will fail due
to absence of fw files.

Signed-off-by: Dmitry Kravkov 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

tg3: Update version to 3.121

2011-11-04T21:31:49+00:00

This patch updates the tg3 version to 3.121.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Eliminate timer race with reset_task

2011-11-04T21:31:48+00:00

During shutdown, it is impossible to reliably disable the timer and
reset_task threads.  Each thread can schedule the other, which leads to
shutdown code that chases its tail.

To fix the problem, this patch removes the ability of tg3_reset_task to
schedule a new timer thread.  To support this change, tg3_timer no
longer terminates itself, but rather goes into a polling mode.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller