linux-stable.git/drivers/net/ethernet/broadcom, branch v3.12

bnx2x: Set NETIF_F_HIGHDMA unconditionally

2013-10-21T22:31:36+00:00

Current driver implementation incorrectly sets the flag only if 64-bit
DMA mask succeeded.

Signed-off-by: Merav Sicron 
Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Don't pretend during register dump

2013-10-21T22:31:36+00:00

As part of a register dump, the interface pretends to have the identity
of other interfaces of the same physical device in order to perform
HW configuration for them - specifically, it needs to prevent attentions
from generating on those functions as the register dump accesses registers
in common blocks which whose reading might generate an attention.

However, such pretension is unsafe - unlike other flows in which the driver
uses pretend, during register dump there is no guarantee no other HW access
will take place (by other flows). If such access will take place, the HW will
be accessed by the wrong interface, and leave both functions in an incorrect
state.

This patch removes all pretensions from the register dump flow. Instead, it
changes initial configuration of attentions such that no fatal attention will
be generated for other functions as a result of the register dump
(notice however, a debug print claiming an attention from other functions IS
possible during the register dump)

Signed-off-by: Dmitry Kravkov 
Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Lock DMAE when used by statistic flow

2013-10-21T22:31:35+00:00

bnx2x has several clients to its DMAE machines - all of them with the exception
of the statistics flow used the same locking mechanisms to synchronize the DMAE
machines' usage.

Since statistics (which are periodically entered) use DMAE without taking the
locks, they may erase the commands which were previously set -
e.g., it may cause a VF to timeout while waiting for a PF answer on the VF-PF
channel as that command header would have been overwritten by the statistics'
header.

This patch makes certain that all flows utilizing DMAE will use the same
API, assuring that the locking scheme will be kept by all said flows.

Signed-off-by: Ariel Elior 
Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Prevent null pointer dereference on error flow

2013-10-21T22:31:35+00:00

If debug message is open and bnx2x_vfop_qdtor_cmd() were to fail,
the resulting print would have caused a null pointer dereference.

Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Fix config when SR-IOV and iSCSI are enabled

2013-10-21T22:31:35+00:00

Starting with commit b9871bc "bnx2x: VF RSS support - PF side", if a PF will
have SR-IOV supported in its PCI configuration space, storage drivers will not
work for that interface.

This patch fixes the resource calculation to allow such a configuration to
properly work.

Signed-off-by: Ariel Elior 
Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Fix Coalescing configuration

2013-10-21T22:31:35+00:00

bnx2x drivers configure coalescing incorrectly (e.g., as a result of a call
to 'ethtool -c'). Although this is almost invisible to the user (due to NAPI)
designated tests will show the configuration is incorrect.

Signed-off-by: Dmitry Kravkov 
Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Unlock VF-PF channel on MAC/VLAN config error

2013-10-21T22:31:35+00:00

Current code returns upon failure, leaving the VF-PF in an unusable state;
This patch adds the missing release so further commands could pass between
PF and VF.

Signed-off-by: Ariel Elior 
Signed-off-by: Yuval Mintz 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Prevent an illegal pointer dereference during panic

2013-10-21T22:31:35+00:00

During a panic, the driver tries to print the Management FW buffer of recent
commands. To do so, the driver reads the address of that buffer from a known
address. If the buffer is unavailable (e.g., PCI reads don't work, MCP is
failing, etc.), the driver will try to access the address it has read, possibly
causing a kernel panic.

This check 'sanitizes' the access, validating the read value is indeed a valid
address inside the management FW's buffers.
The patch also removes a read outside the scope of the buffer, which resulted
in some unrelated chraracters appearing in the log.

Signed-off-by: Yuval Mintz 
Signed-off-by: Dmitry Kravkov 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: Fix Maximum CoS estimation for VFs

2013-10-21T22:31:35+00:00

bnx2x VFs do not support Multi-CoS; Current implementation
erroneously sets the VFs maximal number of CoS to be > 1.

This will cause the driver to call alloc_etherdev_mqs() with
a number of queues it cannot possibly support and reflects
in 'odd' driver prints.

Signed-off-by: Yuval Mintz 
Signed-off-by: Ariel Elior 
Signed-off-by: Eilon Greenstein 
Signed-off-by: David S. Miller

bnx2x: record rx queue for LRO packets

2013-10-17T19:42:35+00:00

RPS support is kind of broken on bnx2x, because only non LRO packets
get proper rx queue information. This triggers reorders, as it seems
bnx2x like to generate a non LRO packet for segment including TCP PUSH
flag : (this might be pure coincidence, but all the reorders I've
seen involve segments with a PUSH)

11:13:34.335847 IP A > B: . 415808:447136(31328) ack 1 win 457 
11:13:34.335992 IP A > B: . 447136:448560(1424) ack 1 win 457 
11:13:34.336391 IP A > B: . 448560:479888(31328) ack 1 win 457 
11:13:34.336425 IP A > B: P 511216:512640(1424) ack 1 win 457 
11:13:34.336423 IP A > B: . 479888:511216(31328) ack 1 win 457 
11:13:34.336924 IP A > B: . 512640:543968(31328) ack 1 win 457 
11:13:34.336963 IP A > B: . 543968:575296(31328) ack 1 win 457 

We must call skb_record_rx_queue() to properly give to RPS (and more
generally for TX queue selection on forward path) the receive queue
information.

Similar fix is needed for skb_mark_napi_id(), but will be handled
in a separate patch to ease stable backports.

Signed-off-by: Eric Dumazet 
Cc: Willem de Bruijn 
Cc: Eilon Greenstein 
Acked-by: Dmitry Kravkov 
Signed-off-by: David S. Miller