linux-stable.git/drivers/net/ethernet/broadcom, branch linux-6.5.y

tg3: power down device only on SYSTEM_POWER_OFF

2023-11-20T10:57:23+00:00

[ Upstream commit 9fc3bc7643341dc5be7d269f3d3dbe441d8d7ac3 ]

Dell R650xs servers hangs on reboot if tg3 driver calls
tg3_power_down.

This happens only if network adapters (BCM5720 for R650xs) were
initialized using SNP (e.g. by booting ipxe.efi).

The actual problem is on Dell side, but this fix allows servers
to come back alive after reboot.

Signed-off-by: George Shuklin 
Fixes: 2ca1c94ce0b6 ("tg3: Disable tg3 device on system reboot to avoid triggering AER")
Reviewed-by: Pavan Chebbi 
Reviewed-by: Michael Chan 
Link: https://lore.kernel.org/r/20231103115029.83273-1-george.shuklin@gmail.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

bnxt_en: Flush XDP for bnxt_poll_nitroa0()'s NAPI

2023-10-06T11:15:58+00:00

[ Upstream commit edc0140cc3b7b91874ebe70eb7d2a851e8817ccc ]

bnxt_poll_nitroa0() invokes bnxt_rx_pkt() which can run a XDP program
which in turn can return XDP_REDIRECT. bnxt_rx_pkt() is also used by
__bnxt_poll_work() which flushes (xdp_do_flush()) the packets after each
round. bnxt_poll_nitroa0() lacks this feature.
xdp_do_flush() should be invoked before leaving the NAPI callback.

Invoke xdp_do_flush() after a redirect in bnxt_poll_nitroa0() NAPI.

Cc: Michael Chan 
Fixes: f18c2b77b2e4e ("bnxt_en: optimized XDP_REDIRECT support")
Reviewed-by: Andy Gospodarek 
Signed-off-by: Sebastian Andrzej Siewior 
Reviewed-by: Michael Chan 
Acked-by: Jesper Dangaard Brouer 
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

bnxt_en: Share the bar0 address with the RoCE driver

2023-09-13T07:53:39+00:00

[ Upstream commit 61220e098e858951f1926d66c1490a96351e1c85 ]

Add a parameter in the bnxt_en_dev structure to share the bar0 address
with RoCE driver.

Link: https://lore.kernel.org/r/1689742977-9128-3-git-send-email-selvin.xavier@broadcom.com
CC: Michael Chan 
Signed-off-by: Chandramohan Akula 
Signed-off-by: Selvin Xavier 
Signed-off-by: Jason Gunthorpe 
Stable-dep-of: f19fba1f79dc ("RDMA/bnxt_re: Fix max_qp count for virtual functions")
Signed-off-by: Sasha Levin

bnxt_en: Update HW interface headers

2023-09-13T07:53:39+00:00

[ Upstream commit cf1694f09894e760f4e2cf068ee6519d11cd0ede ]

Updating the HW structures for the doorbell pacing related
information. Newly added interface structures will be used in
the followup patches.

Link: https://lore.kernel.org/r/1689742977-9128-2-git-send-email-selvin.xavier@broadcom.com
CC: Michael Chan 
Signed-off-by: Chandramohan Akula 
Signed-off-by: Selvin Xavier 
Signed-off-by: Jason Gunthorpe 
Stable-dep-of: f19fba1f79dc ("RDMA/bnxt_re: Fix max_qp count for virtual functions")
Signed-off-by: Sasha Levin

bnx2x: new flag for track HW resource allocation

2023-08-23T00:07:40+00:00

While injecting PCIe errors to the upstream PCIe switch of
a BCM57810 NIC, system hangs/crashes were observed.

After several calls to bnx2x_tx_timout() complete,
bnx2x_nic_unload() is called to free up HW resources
and bnx2x_napi_disable() is called to release NAPI objects.
Later, when the EEH driver calls bnx2x_io_slot_reset() to
complete the recovery process, bnx2x attempts to disable
NAPI again by calling bnx2x_napi_disable() and freeing
resources which have already been freed, resulting in a
hang or crash.

Introduce a new flag to track the HW resource and NAPI
allocation state, refactor duplicated code into a single
function, check page pool allocation status before freeing,
and reduces debug output when a TX timeout event occurs.

Reviewed-by: Manish Chopra 
Tested-by: Abdul Haleem 
Tested-by: David Christensen 
Reviewed-by: Simon Horman 
Tested-by: Venkata Sai Duggi 
Signed-off-by: Thinh Tran 
Link: https://lore.kernel.org/r/20230818161443.708785-2-thinhtr@linux.vnet.ibm.com
Signed-off-by: Jakub Kicinski

tg3: Use slab_build_skb() when needed

2023-08-22T02:11:58+00:00

The tg3 driver will use kmalloc() under some conditions. Check the
frag_size and use slab_build_skb() when frag_size is 0. Silences
the warning introduced by commit ce098da1497c ("skbuff: Introduce
slab_build_skb()"):

	Use slab_build_skb() instead
	...
	tg3_poll_work+0x638/0xf90 [tg3]

Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()")
Reported-by: Fiona Ebner 
Closes: https://lore.kernel.org/all/1bd4cb9c-4eb8-3bdb-3e05-8689817242d1@proxmox.com
Cc: Siva Reddy Kallam 
Cc: Prashant Sreedharan 
Cc: Michael Chan 
Cc: Bagas Sanjaya 
Signed-off-by: Kees Cook 
Reviewed-by: Pavan Chebbi 
Link: https://lore.kernel.org/r/20230818175417.never.273-kees@kernel.org
Signed-off-by: Jakub Kicinski

net: bcmgenet: Fix return value check for fixed_phy_register()

2023-08-20T09:58:28+00:00

The fixed_phy_register() function returns error pointers and never
returns NULL. Update the checks accordingly.

Fixes: b0ba512e25d7 ("net: bcmgenet: enable driver to work without a device tree")
Signed-off-by: Ruan Jinjie 
Reviewed-by: Leon Romanovsky 
Acked-by: Doug Berger 
Signed-off-by: David S. Miller

net: bgmac: Fix return value check for fixed_phy_register()

2023-08-20T09:58:28+00:00

The fixed_phy_register() function returns error pointers and never
returns NULL. Update the checks accordingly.

Fixes: c25b23b8a387 ("bgmac: register fixed PHY for ARM BCM470X / BCM5301X chipsets")
Signed-off-by: Ruan Jinjie 
Reviewed-by: Andrew Lunn 
Reviewed-by: Leon Romanovsky 
Signed-off-by: David S. Miller

broadcom: b44: Use b44_writephy() return value

2023-08-16T06:08:29+00:00

Return result of b44_writephy() instead of zero to
deal with possible error.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Artem Chernyshev 
Reviewed-by: Leon Romanovsky 
Signed-off-by: David S. Miller

bnxt_en: Fix max_mtu setting for multi-buf XDP

2023-08-01T22:04:58+00:00

The existing code does not allow the MTU to be set to the maximum even
after an XDP program supporting multiple buffers is attached.  Fix it
to set the netdev->max_mtu to the maximum value if the attached XDP
program supports mutiple buffers, regardless of the current MTU value.

Also use a local variable dev instead of repeatedly using bp->dev.

Fixes: 1dc4c557bfed ("bnxt: adding bnxt_xdp_build_skb to build skb from multibuffer xdp_buff")
Reviewed-by: Somnath Kotur 
Reviewed-by: Ajit Khaparde 
Reviewed-by: Andy Gospodarek 
Signed-off-by: Michael Chan 
Link: https://lore.kernel.org/r/20230731142043.58855-3-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski