linux-stable.git/drivers/net/dsa, branch v4.7.7

net: dsa: bcm_sf2: Fix race condition while unmasking interrupts

2016-09-24T08:09:25+00:00

[ Upstream commit 4f101c47791cdcb831b3ef1f831b1cc51e4fe03c ]

We kept shadow copies of which interrupt sources we have enabled and
disabled, but due to an order bug in how intrl2_mask_clear was defined,
we could run into the following scenario:

CPU0					CPU1
intrl2_1_mask_clear(..)
sets INTRL2_CPU_MASK_CLEAR
					bcm_sf2_switch_1_isr
					read INTRL2_CPU_STATUS and masks with stale
					irq1_mask value
updates irq1_mask value

Which would make us loop again and again trying to process and interrupt
we are not clearing since our copy of whether it was enabled before
still indicates it was not. Fix this by updating the shadow copy first,
and then unasking at the HW level.

Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net: dsa: mv88e6xxx: remove bridge work

2016-05-16T17:46:24+00:00

Now that the bridge code defers the switchdev port state setting, there
is no need to defer the port STP state change within the mv88e6xxx code.
Thus get rid of the driver's bridge work code.

This also fixes a race condition where the DSA layer assumes that the
bridge code already set the unbridged port's STP state to Disabled
before restoring the Forwarding state.

As a consequence, this also fixes the FDB flush for the unbridged port
which now correctly occurs during the Forwarding to Disabled transition.

Fixes: 0bc05d585d38 ("switchdev: allow caller to explicitly request attr_set as deferred")
Reported-by: Andrew Lunn 
Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

dsa: mv88e6xxx: Handle eeprom-length property

2016-05-11T23:36:29+00:00

A switch can export an attached EEPROM using the standard ethtool API.
However the switch itself cannot determine the size of the EEPROM, and
multiple sizes are allowed. Thus a device tree property is supported
to indicate the length of the EEPROM. Parse this property during
device probe, and implement a callback function to retrieve it.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: Rename switch chip data to cd

2016-05-11T23:36:28+00:00

The dsa_switch structure contains a dsa_chip_data member called pd.
However in the rest of the code, pd is used for dsa_platform_data.
This is confusing. Rename it cd, which is already often used in dsa.c
and slave.c for this data type.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: Remove master_dev from switch structure

2016-05-11T23:36:28+00:00

The switch drivers only use the master_dev member for dev_info()
messages.  Now that the device is passed to the old style probe, and
new style drivers are probed as true linux drivers, this is no longer
needed.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: Move gpio reset into switch driver

2016-05-11T23:36:28+00:00

Resetting the switch is something the driver does, not the framework.
So move the parsing of this property into the driver.

There are no in kernel users of this property, so moving it does not
break anything. There is however a board which will make use of this
property making its way into the kernel.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: Add mdio device support to Marvell switches

2016-05-11T23:36:28+00:00

Allow Marvell switches to be mdio devices. Currently the driver just
allocate the private structure and detects what device is on the
bus. Later patches will make them register with the DSA framework.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: mv88e6xxx: Rename probe function to fit the normal pattern

2016-05-11T23:36:28+00:00

All other DSA drivers use _drv_ in there DSA probe function name, thus
allowing for a true linux driver probe function to use the
conventional name. Make mv88e6xxx fit this pattern.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: mv88e6xxx: Initialise the mutex as soon as it is created

2016-05-11T23:36:28+00:00

By initialising immediately it, we don't run the danger of using it
before it is initialised.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: add STU capability

2016-05-11T23:34:23+00:00

Some switch models have a STU (per VLAN port state database). Add a new
capability flag to switches info, instead of checking their family.

Also if the 6165 family has an STU, it must have a VTU, so add the
MV88E6XXX_FLAG_VTU to its family flags.

Signed-off-by: Vivien Didelot 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller