linux-stable.git/drivers/net/dsa, branch v4.6

net: dsa: mv88e6xxx: fix uninitialized error return

2016-04-28T20:29:20+00:00

The error return err is not initialized and there is a possibility
that err is not assigned causing mv88e6xxx_port_bridge_join to
return a garbage error return status. Fix this by initializing err
to 0.

Signed-off-by: Colin Ian King 
Reviewed-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: share the same default FDB

2016-04-16T23:07:10+00:00

For hardware cross-chip bridging to work, user ports *and* DSA ports
need to share a common address database, in order to switch a frame to
the correct interconnected device.

This is currently working for VLAN filtering aware systems, since Linux
will implement a bridge group as a 802.1Q VLAN, which has its own FDB,
including DSA and CPU links as members.

However when the system doesn't support VLAN filtering, Linux only
relies on the port-based VLAN to implement a bridge group.

To fix hardware cross-chip bridging for such systems, set the same
default address database 0 for user and DSA ports, instead of giving
them all a different default database.

Note that the bridging code prevents frames to egress between unbridged
ports, and flushes FDB entries of a port when changing its STP state.

Also note that the FID 0 is special and means "all" for ATU operations,
but it's OK since it is used as a default forwarding address database.

Fixes: 2db9ce1fd9a3 ("net: dsa: mv88e6xxx: assign default FDB to ports")
Fixes: 466dfa077022 ("net: dsa: mv88e6xxx: assign dynamic FDB to bridges")
Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: enable SA learning on DSA ports

2016-04-16T23:07:10+00:00

In multi-chip systems, DSA Tag ports must learn SA addresses in order to
correctly switch frames between interconnected chips.

This fixes cross-chip hardware bridging in a VLAN filtering aware
system, because a bridge group gets implemented as an hardware 802.1Q
VLAN and thus DSA and user ports share the same FDB.

Fixes: 4c7ea3c0791e ("net: dsa: mv88e6xxx: disable SA learning for DSA and CPU ports")
Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: unlock DSA and CPU ports

2016-04-16T23:07:10+00:00

Locking a port generates an hardware interrupt when a new SA address is
received. This enables CPU directed learning, which is needed for 802.1X
MAC authentication.

To disable automatic learning on a port, the only configuration needed
is to set its Port Association Vector to all zero.

Clear PAV when SA learning should be disabled instead of locking a port.

Fixes: 4c7ea3c0791e ("net: dsa: mv88e6xxx: disable SA learning for DSA and CPU ports")
Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-31T19:12:57+00:00

Some of the vendor-specific bootloaders set up this part
of the initialization for us, so this was never added.
However, since upstream bootloaders don't initialize the
chip specifically, they leave the fiber MII's PDOWN flag
set, which means that the CPU port doesn't connect.

This patch checks whether this flag has been clear prior
by something else, and if not make us clear it.

Reviewed-by: Andrew Lunn 
Signed-off-by: Patrick Uiterwijk 
Tested-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read, write}

2016-03-31T19:12:57+00:00

Add versions of the phy_page_read and _write functions to
be used in a context where the SMI mutex is held.

Tested-by: Vivien Didelot 
Reviewed-by: Vivien Didelot 
Signed-off-by: Patrick Uiterwijk 
Signed-off-by: David S. Miller

net: dsa: make port_bridge_leave return void

2016-03-14T20:05:31+00:00

netdev_upper_dev_unlink() which notifies NETDEV_CHANGEUPPER, returns
void, as well as del_nbp(). So there's no advantage to catch an eventual
error from the port_bridge_leave routine at the DSA level.

Make this routine void for the DSA layer and its existing drivers.

Signed-off-by: Vivien Didelot 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: dsa: rename port_*_bridge routines

2016-03-14T20:05:31+00:00

Rename DSA port_join_bridge and port_leave_bridge routines to
respectively port_bridge_join and port_bridge_leave in order to respect
an implicit Port::Bridge namespace.

Signed-off-by: Vivien Didelot 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

dsa: Rename mv88e6123_61_65 to mv88e6123 to be consistent

2016-03-14T19:43:10+00:00

All the drivers support multiple chips, but mv88e6123_61_65 is the
only one that reflects this in its naming. Change it to be consistent
with the other drivers.

Signed-off-by: Andrew Lunn 
Reviewed-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: avoid writing the same mode

2016-03-10T21:10:31+00:00

There is no need to change the 802.1Q port mode for the same value.
Thus avoid such message:

    [  401.954836] dsa dsa@0 lan0: 802.1Q Mode: Disabled (was Disabled)

Signed-off-by: Vivien Didelot 
Tested-by: Andrew Lunn 
Signed-off-by: David S. Miller