linux-stable.git/drivers/net/dsa, branch v4.16.2

net: dsa: mt7530: fix module autoloading for OF platform drivers

2018-03-26T17:09:42+00:00

It's required to create a modules.alias via MODULE_DEVICE_TABLE helper
for the OF platform driver. Otherwise, module autoloading cannot work.

Signed-off-by: Sean Wang 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mt7530: remove redundant MODULE_ALIAS entries

2018-03-26T17:09:41+00:00

MODULE_ALIAS exports information to allow the module to be auto-loaded at
boot for the drivers registered using legacy platform registration.

However, currently the driver is always used by DT-only platform,
MODULE_ALIAS is redundant and should be removed properly.

Signed-off-by: Sean Wang 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: Fix functional dsa-loop dependency on FIXED_PHY

2018-03-22T17:02:47+00:00

We have a functional dependency on the FIXED_PHY MDIO bus because we register
fixed PHY devices "the old way" which only works if the code that does this has
had a chance to run before the fixed MDIO bus is probed. Make sure we account
for that and have dsa_loop_bdinfo.o be either built-in or modular depending on
whether CONFIG_FIXED_PHY reflects that too.

Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: b53: Use strlcpy() for ethtool::get_strings

2018-03-06T16:12:39+00:00

Our statistics strings are allocated at initialization without being
bound to a specific size, yet, we would copy ETH_GSTRING_LEN bytes using
memcpy() which would create out of bounds accesses, this was flagged by
KASAN. Replace this with strlcpy() to make sure we are bound the source
buffer size and we also always NUL-terminate strings.

Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: Free ATU/VTU irq only when there is chip irq

2018-01-19T20:57:02+00:00

We only register the ATU and VTU irq when we have a chip level IRQ.
In the error path, we should only attempt to remove the ATU and VTU
irq if we also have a chip level IRQ.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: Return error from irq_find_mapping()

2018-01-19T20:57:02+00:00

Fix a cut/paste error. When irq_find_mapping() returns an error for
the ATU or VTU interrupt, return that error, not the value of
chip->device_irq.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: lan9303: check error value from devm_gpiod_get_optional()

2018-01-15T18:18:02+00:00

devm_gpiod_get_optional() can return an error in addition to a NULL ptr.
Check for error and propagate that to the probe function. Check return
value in probe. This will now handle EPROBE_DEFER for the reset gpio.

Signed-off-by: Phil Reid 
Signed-off-by: David S. Miller

net: dsa: lan9303: make lan9303_handle_reset() a void function

2018-01-15T18:18:02+00:00

lan9303_handle_reset never returns anything other than success.
So there's not need for it to return an error code.

Signed-off-by: Phil Reid 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: Decode VTU problem interrupt

2018-01-14T17:08:45+00:00

When there is a problem with the VTU, an interrupt can be
generated. Trap this interrupt and decode the registers to determine
what the problem was, then log the error.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: Decode ATU problem interrupt

2018-01-14T17:08:45+00:00

When there is a problem with the ATU, an interrupt can be
generated. Trap this interrupt and decode the registers to determine
what the problem was, then log the error.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller