linux-stable.git/drivers/net/dsa, branch v4.12

net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-30T18:07:53+00:00

'static' was not enough, the helpers must be 'static inline'

net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]

Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-28T15:41:10+00:00

Stub functions in header files need to be static, or we can have
multiple definitions errors.

Reported-by: kbuild test robot 
Fixes: 6335e9f2446b ("net: dsa: mv88e6xxx: mv88e6390X SERDES support")
Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: add default case to switch

2017-05-12T16:14:40+00:00

Add default case to switch in order to avoid any chance of using an
uninitialized variable _low_, in case s->type does not match any of
the listed case values.

Addresses-Coverity-ID: 1398130
Suggested-by: Andrew Lunn 
Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: David S. Miller

net: dsa: loop: Check for memory allocation failure

2017-05-08T18:58:36+00:00

If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
Return -ENOMEM instead, as done for some other memory allocation just a
few lines above.

Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Signed-off-by: Christophe JAILLET 
Reviewed-by: Andrew Lunn 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: add VTU support for 88E6390

2017-05-01T19:03:13+00:00

The 6390 family of chips use only 2 of the 3 VTU Data registers to pack
the MemberTag and PortState VLAN data. This means that they must be
written or read before or after each VTU/STU operations.

Implement this variant to add support for VTU with such chips. These
chips have a 13th bit for the VID thus set their max_vid to 8191.

Signed-off-by: Vivien Didelot 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: support the VTU Page bit

2017-05-01T19:03:13+00:00

Newer chips such as the 88E6390 have a VTU Page bit in the VTU VID
register to specify a 13th bit for the VID. This can be used to support
8K VLANs.

When dumping the whole VTU, all VID bits must be set to one, including
this VTU Page bit. Add support for VID greater than 4095.

Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: simplify VTU entry getter

2017-05-01T19:03:13+00:00

Make the code which fetches or initializes a new VTU entry more concise.
This allows us the get rid of the old underscore prefix naming.

Signed-off-by: Vivien Didelot 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: make VTU helpers static

2017-05-01T19:03:12+00:00

Now that we have chip operations for VTU accesses, mark all helpers from
global1_vtu.c as static. Only the various implementations of the
GetNext, LoadPurge and Flush operations need to be exposed.

Signed-off-by: Vivien Didelot 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: add VTU Load/Purge operation

2017-05-01T19:03:12+00:00

Add a new vtu_loadpurge operation to the chip info structure to differ
the various implementations of the VTU accesses.

Now that the STU handling is abstracted behind VTU operations, kill the
obsolete MV88E6XXX_FLAG_STU flag.

Signed-off-by: Vivien Didelot 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: mv88e6xxx: add VTU GetNext operation

2017-05-01T19:03:12+00:00

Add a new vtu_getnext operation to the chip info structure to differ the
various implementations of the VTU accesses.

Signed-off-by: Vivien Didelot 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller