linux-stable.git/drivers/net/can, branch v3.12

can: at91-can: fix device to driver data mapping for platform devices

2013-10-09T21:04:31+00:00

In commit:

    3078cde7 can: at91_can: add dt support

device tree support was added to the at91_can driver. In this commit the
mapping of device to driver data was mixed up. This results in the sam9x5
parameters being used for the sam9263 and the workaround for the broken mailbox
0 on the sam9263 not being activated.

This patch fixes the broken platform_device_id table.

Cc: linux-stable 
Cc: Ludovic Desroches 
Signed-off-by: Marc Kleine-Budde

can: flexcan: fix mx28 detection by rearanging OF match table

2013-10-09T21:02:58+00:00

The current implemetation of of_match_device() relies that the of_device_id
table in the driver is sorted from most specific to least specific compatible.

Without this patch the mx28 is detected as the less specific p1010. This leads
to a p1010 specific workaround is activated on the mx28, which is not needed.

Cc: linux-stable 
Signed-off-by: Marc Kleine-Budde

can: flexcan: flexcan_chip_start: fix regression, mark one MB for TX and abort pending TX

2013-10-09T21:01:35+00:00

In patch

    0d1862e can: flexcan: fix flexcan_chip_start() on imx6

the loop in flexcan_chip_start() that iterates over all mailboxes after the
soft reset of the CAN core was removed. This loop put all mailboxes (even the
ones marked as reserved 1...7) into EMPTY/INACTIVE mode. On mailboxes 8...63,
this aborts any pending TX messages.

After a cold boot there is random garbage in the mailboxes, which leads to
spontaneous transmit of CAN frames during first activation. Further if the
interface was disabled with a pending message (usually due to an error
condition on the CAN bus), this message is retransmitted after enabling the
interface again.

This patch fixes the regression by:
1) Limiting the maximum number of used mailboxes to 8, 0...7 are used by the RX
FIFO, 8 is used by TX.
2) Marking the TX mailbox as EMPTY/INACTIVE, so that any pending TX of that
mailbox is aborted.

Cc: linux-stable 
Cc: Lothar Waßmann 
Signed-off-by: Marc Kleine-Budde

can: dev: fix nlmsg size calculation in can_get_size()

2013-10-07T19:55:03+00:00

This patch fixes the calculation of the nlmsg size, by adding the missing
nla_total_size().

Signed-off-by: Marc Kleine-Budde 
Signed-off-by: David S. Miller

can: flexcan: fix flexcan_chip_start() on imx6

2013-09-30T11:49:09+00:00

In the flexcan_chip_start() function first the flexcan core is going through
the soft reset sequence, then the RX FIFO is enabled.

With the hardware is put into FIFO mode, message buffers 1...7 are reserved by
the FIFO engine. The remaining message buffers are in reset default values.
This patch removes the bogus initialization of the message buffers, as it
causes an imprecise external abort on imx6.

Cc: linux-stable 
Reported-by: Lothar Waßmann 
Tested-by: Lothar Waßmann 
Signed-off-by: Marc Kleine-Budde

Merge branch 'fixes-for-3.12' of git://gitorious.org/linux-can/linux-can

2013-09-27T06:08:03+00:00

slcan: rewrite of slc_bump and slc_encaps

2013-09-20T19:38:27+00:00

The old implementation was heavy on str* functions and sprintf calls.
This version is more manual, but faster.

Profiling just the printing of a 3 char CAN-id resulted in 60 instructions
for the manual method and over 2000 for the sprintf method. Bear in
mind the profiling was done against libc and not the kernel sprintf.

Together with this rewrite an issue with sending and receiving of RTR frames
has been fixed by Oliver for the cases that the DLC is not zero.

Signed-off-by: Andre Naujoks 
Tested-by: Oliver Hartkopp 
Acked-by: Oliver Hartkopp 
Acked-by: Marc Kleine-Budde 
Signed-off-by: David S. Miller

slip/slcan: added locking in wakeup function

2013-09-20T19:38:26+00:00

The locking is needed, since the the internal buffer for the CAN frames is
changed during the wakeup call. This could cause buffer inconsistencies
under high loads, especially for the outgoing short CAN packet skbuffs.

The needed locks led to deadlocks before commit
"5ede52538ee2b2202d9dff5b06c33bfde421e6e4 tty: Remove extra wakeup from pty
write() path", which removed the direct callback to the wakeup function from the
tty layer.

As slcan.c is based on slip.c the issue in the original code is fixed, too.

Signed-off-by: Andre Naujoks 
Acked-by: Oliver Hartkopp 
Acked-by: Marc Kleine-Budde  
Signed-off-by: David S. Miller

can: pcan_usb_core: fix memory leak on failure paths in peak_usb_start()

2013-09-20T18:58:21+00:00

Tx and rx urbs are not deallocated if something goes wrong in peak_usb_start().
The patch fixes error handling to deallocate all the resources.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Stephane Grosjean 
Signed-off-by: Marc Kleine-Budde

can: mscan: improve clock API use

2013-08-29T20:49:35+00:00

the .get_clock() callback is run from probe() and might allocate
resources, introduce a .put_clock() callback that is run from remove()
to undo any allocation activities

prepare and enable the clocks in open(), disable and unprepare the
clocks in close() if clocks were acquired during probe(), to not assume
knowledge about which activities are done in probe() and remove()

use devm_get_clk() to lookup the SYS and REF clocks, to have the clocks
put upon device shutdown

store pointers to data structures upon successful allocation already
instead of deferral until complete setup, such that subroutines in the
setup sequence may access those data structures as well to track their
resource acquisition

since clock allocation remains optional, the release callback as well as
the enable/disable calls in open/close are optional as well

Cc: linux-can@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Gerhard Sittig 
Signed-off-by: Anatolij Gustschin 
Signed-off-by: Marc Kleine-Budde