linux-stable.git/drivers/net/can/dev.c, branch linux-3.13.y

can: add destructor for self generated skbs

2014-03-07T06:06:11+00:00

[ Upstream commit 0ae89beb283a0db5980d1d4781c7d7be2f2810d6 ]

Self generated skbuffs in net/can/bcm.c are setting a skb->sk reference but
no explicit destructor which is enforced since Linux 3.11 with commit
376c7311bdb6 (net: add a temporary sanity check in skb_orphan()).

This patch adds some helper functions to make sure that a destructor is
properly defined when a sock reference is assigned to a CAN related skb.
To create an unshared skb owned by the original sock a common helper function
has been introduced to replace open coded functions to create CAN echo skbs.

Signed-off-by: Oliver Hartkopp 
Tested-by: Andre Naujoks 
Reviewed-by: Eric Dumazet 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

can: dev: sort can_changelink() by IFLA_CAN_*

2013-10-31T19:55:15+00:00

This patch sorts the handling of data[IFLA_CAN_*] by IFLA_CAN_*.

Signed-off-by: Marc Kleine-Budde

can: dev: sort can_fill_info() by IFLA_CAN_*

2013-10-31T19:55:14+00:00

This patch sorts the call to nla_put() by IFLA_CAN_*.

Signed-off-by: Marc Kleine-Budde

can: dev: sort can_get_size() by IFLA_CAN_*

2013-10-31T19:55:13+00:00

This patch sorts the individual addends of the sum by IFLA_CAN_*.

Signed-off-by: Marc Kleine-Budde

can: dev: fix nlmsg size calculation in can_get_size()

2013-10-07T19:55:03+00:00

This patch fixes the calculation of the nlmsg size, by adding the missing
nla_total_size().

Signed-off-by: Marc Kleine-Budde 
Signed-off-by: David S. Miller

can: rework skb reserved data handling

2013-01-28T23:17:25+00:00

Added accessor and skb_reserve helpers for struct can_skb_priv.
Removed pointless skb_headroom() check.

Signed-off-by: Oliver Hartkopp 
CC: Marc Kleine-Budde 
Signed-off-by: David S. Miller

can: add private data space for CAN sk_buffs

2013-01-26T15:59:01+00:00

The struct can_skb_priv is used to transport additional information along
with the stored struct can(fd)_frame that can not be contained in existing
struct sk_buff elements.

can_skb_priv is located in the skb headroom, which does not touch the existing
CAN sk_buff usage with skb->data and skb->len, so that even out-of-tree
CAN drivers can be used without changes.

Btw. out-of-tree CAN drivers without can_skb_priv in the sk_buff headroom
would not support features based on can_skb_priv.

The can_skb_priv->ifindex contains the first interface where the CAN frame
appeared on the local host. Unfortunately skb->skb_iif can not be used as this
value is overwritten in every netif_receive_skb() call.

Signed-off-by: Oliver Hartkopp 
Signed-off-by: Marc Kleine-Budde

can: rename LED trigger name on netdev renames

2013-01-26T15:58:59+00:00

The LED trigger name for CAN devices is based on the initial
CAN device name, but does never change. The LED trigger name
is not guaranteed to be unique in case of hotplugging CAN devices.

This patch tries to address this problem by modifying the
LED trigger name according to the CAN device name when
the latter changes.

v1 - Kurt Van Dijck
v2 - Fabio Baltieri
- remove rename blocking if trigger is bound
- use led-subsystem function for the actual rename (still WiP)
- call init/exit functions from dev.c
v3 - Kurt Van Dijck
- safe operation for non-candev based devices (vcan, slcan)
	based on earlier patch
v4 - Kurt Van Dijck
- trivial patch mistakes fixed

Signed-off-by: Kurt Van Dijck 
Signed-off-by: Fabio Baltieri 
Signed-off-by: Marc Kleine-Budde

can: export a safe netdev_priv wrapper for candev

2013-01-26T15:58:59+00:00

In net_device notifier calls, it was impossible to determine
if a CAN device is based on candev in a safe way.
This patch adds such test in order to access candev storage
from within those notifiers.

Signed-off-by: Kurt Van Dijck 
Acked-by: Oliver Hartkopp 
Signed-off-by: Fabio Baltieri 
Signed-off-by: Marc Kleine-Budde

can: Do not call dev_put if restart timer is running upon close

2012-11-29T13:30:08+00:00

If the restart timer is running due to BUS-OFF and the device is
disconnected an dev_put will decrease the usage counter to -1 thus
blocking the interface removal, resulting in the following dmesg
lines repeating every 10s:
can: notifier: receive list not found for dev can0
can: notifier: receive list not found for dev can0
can: notifier: receive list not found for dev can0
unregister_netdevice: waiting for can0 to become free. Usage count = -1

Cc: linux-stable 
Signed-off-by: Alexander Stein 
Signed-off-by: Marc Kleine-Budde