linux-stable.git/drivers/net/bonding, branch v3.12

bonding: Fix broken promiscuity reference counting issue

2013-10-01T04:10:55+00:00

Recently grabbed this report:
https://bugzilla.redhat.com/show_bug.cgi?id=1005567

Of an issue in which the bonding driver, with an attached vlan encountered the
following errors when bond0 was taken down and back up:

dummy1: promiscuity touches roof, set promiscuity failed. promiscuity feature of
device might be broken.

The error occurs because, during __bond_release_one, if we release our last
slave, we take on a random mac address and issue a NETDEV_CHANGEADDR
notification.  With an attached vlan, the vlan may see that the vlan and bond
mac address were in sync, but no longer are.  This triggers a call to dev_uc_add
and dev_set_rx_mode, which enables IFF_PROMISC on the bond device.  Then, when
we complete __bond_release_one, we use the current state of the bond flags to
determine if we should decrement the promiscuity of the releasing slave.  But
since the bond changed promiscuity state during the release operation, we
incorrectly decrement the slave promisc count when it wasn't in promiscuous mode
to begin with, causing the above error

Fix is pretty simple, just cache the bonding flags at the start of the function
and use those when determining the need to set promiscuity.

This is also needed for the ALLMULTI flag

CC: Jay Vosburgh 
CC: Andy Gospodarek 
CC: Mark Wu 
CC: "David S. Miller" 
Reported-by: Mark Wu 

Signed-off-by: David S. Miller

bonding: Make alb learning packet interval configurable

2013-09-16T02:20:44+00:00

running bonding in ALB mode requires that learning packets be sent periodically,
so that the switch knows where to send responding traffic.  However, depending
on switch configuration, there may not be any need to send traffic at the
default rate of 3 packets per second, which represents little more than wasted
data.  Allow the ALB learning packet interval to be made configurable via sysfs

Signed-off-by: Neil Horman 
Acked-by: Acked-by: Veaceslav Falico 
CC: Jay Vosburgh 
CC: Andy Gospodarek 
CC: "David S. Miller" 
Signed-off-by: Andy Gospodarek 
Signed-off-by: David S. Miller

bonding: fix bond_arp_rcv setting and arp validate desync state

2013-09-11T19:55:17+00:00

We make bond_arp_rcv global so it can be used in bond_sysfs if the bond
interface is up and arp_interval is being changed to a positive value
and cleared otherwise as per Jay's suggestion.
This also fixes a problem where bond_arp_rcv was set even though
arp_validate was disabled while the bond was up by unsetting recv_probe
in bond_store_arp_validate and respectively setting it if enabled.

Signed-off-by: Nikolay Aleksandrov 
Signed-off-by: Marcelo Ricardo Leitner 
Acked-by: Veaceslav Falico 
Signed-off-by: David S. Miller

bonding: fix store_arp_validate race with mode change

2013-09-11T19:55:17+00:00

We need to protect store_arp_validate via rtnl because it can race with
mode changing and we can end up having arp_validate set in a mode
different from active-backup.

Signed-off-by: Nikolay Aleksandrov 
Acked-by: Veaceslav Falico 
Signed-off-by: David S. Miller

bonding: drop read_lock in bond_compute_features

2013-09-04T04:27:25+00:00

bond_compute_features is always called with RTNL held, so we can safely
drop the read bond->lock.

Signed-off-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

bonding: drop read_lock in bond_fix_features

2013-09-04T04:27:25+00:00

We're protected by RTNL so nothing can happen and we can safely drop the
read bond->lock.

Signed-off-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

bonding: simplify bond_3ad_update_lacp_rate and use RTNL for sync

2013-09-04T04:27:24+00:00

We can drop the use of bond->lock for mutual exclusion in
bond_3ad_update_lacp_rate and use RTNL in the sysfs store function
instead. This way we'll prevent races with mode change and interface
up/down as well as simplify update_lacp_rate by removing the check for
port->slave because it'll always be initialized (done while enslaving
with RTNL). This change will also help in the future removal of reader
bond->lock from bond_enslave.

Signed-off-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

bonding: trivial: remove outdated comment and braces

2013-09-04T04:27:24+00:00

We don't have to release all slaves when closing the bond dev, so remove
the outdated comment and the braces around the left single statement.

Signed-off-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

bonding: simplify and fix peer notification

2013-09-04T04:27:24+00:00

This patch aims to remove a use of the bond->lock for mutual exclusion
which will later allow easier migration to RCU of the users of this
functionality. We use RTNL as a synchronizing mechanism since it's
always held when send_peer_notif is set, and when it is decremented from
the notifier function. We can also drop some locking, and fix the
leakage of the send_peer_notif counter.

Signed-off-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

bonding: use rlb_client_info->vlan_id instead of ->tag

2013-09-04T02:02:32+00:00

Store VID in ->vlan_id (if any), and remove the useless ->tag.

CC: Jay Vosburgh 
CC: Andy Gospodarek 
Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller