linux-stable.git/drivers/mtd, branch linux-2.6.24.y

mtd: fix broken state in CFI driver caused by FL_SHUTDOWN

2008-04-19T01:53:23+00:00

upstream commit: fb6d080c6f75dfd7e23d5a3575334785aa8738eb

THe CFI driver in 2.6.24 kernel is broken.  Not so intensive read/write
operations cause incomplete writes which lead to kernel panics in JFFS2.

We investigated the issue - it is caused by bug in FL_SHUTDOWN parsing code.
Sometimes chip returns -EIO as if it is in FL_SHUTDOWN state when it should
wait in FL_PONT (error in order of conditions).

The following patch fixes the bug in state parsing code of CFI.  Also I've
added comments to notify developers if they want to add new case in future.

Signed-off-by: Alexey Korolev 
Reviewed-by: Joern Engel 
Cc: David Woodhouse 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Chris Wright

mtd: memory corruption in block2mtd.c

2008-04-19T01:53:18+00:00

upstream commit: 2875fb65f8e40401c4b781ebc5002df10485f635

The block2mtd driver (drivers/mtd/devices/block2mtd.c) will kfree an on-stack
pointer when handling an invalid argument line (e.g.
block2mtd=/dev/loop0,xxx).

The kfree was added some time ago when "name" was dynamically allocated.

Signed-off-by: Ingo van Lil 
Acked-by: Joern Engel 
Cc: David Woodhouse 
Cc: Andrew Morton 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Chris Wright

cache invalidation error for buffered write

2008-01-11T19:44:37+00:00

The bug causes corruptions of data read from flash.

The original code performs cache invalidation from "adr" to "adr + len"
in do_write_buffer().  Since len and adr could be updated in the code
before invalidation - it causes improper setting of cache invalidation
regions.

Signed-off-by: Massimo Cirillo 
Signed-off-by: Giuseppe D'Eliseo 
Acked-by: Nicolas Pitre 
Acked-by: Jörn Engel 
Signed-off-by: David Woohouse 
Signed-off-by: Linus Torvalds

Eliminate pointless casts from void* in a few driver irq handlers.

2007-10-23T23:53:16+00:00

Signed-off-by: Jeff Garzik

[MTD] [NOR] Fix deadlock in Intel chip driver caused by get_chip recursion

2007-10-23T11:07:52+00:00

This patch solves kernel deadlock issue seen on JFFF2 simultaneous 
operations. Detailed investigation of the issue showed that the kernel 
deadlock is caused by tons of recursive get_chip calls.

Signed-off-by: Alexey Korolev 
Acked-by: Nicolas Pitre 
Signed-off-by: David Woodhouse

[MTD] [OneNAND] Fix wrong free the static address in onenand_sim

2007-10-22T08:57:28+00:00

Reported-by: Randy Dunlap 
Signed-off-by: Kyungmin Park 
Signed-off-by: David Woodhouse

[MTD] [NAND] Replace -1 with -EBADMSG in nand error correction code

2007-10-20T21:30:54+00:00

Magic numerical values are just bad style.  Particularly so when
undocumented.

Signed-off-by: Jörn Engel 
Signed-off-by: David Woodhouse

[MTD] [NAND] treat any negative return value from correct() as an error

2007-10-20T21:27:22+00:00

Treat any negative return value from a NAND driver's correct() function
as a failure, rather than just -1.

Signed-off-by: Matt Reimer 
Signed-off-by: David Woodhouse

[MTD] [NAND] nandsim: bugfix in initialization

2007-10-20T14:00:29+00:00

NAND of > 32MiB in size use 4 bytes in address cycle, not 3.

Reported-by: bhsong 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

[MTD] Fix typo in Alauda config option help text.

2007-10-20T13:59:26+00:00

Signed-off-by: Dave Jones 
Signed-off-by: Joern Engel 
Signed-off-by: David Woodhouse