linux-stable.git/drivers/mtd/ubi, branch v4.16.2

ubi: block: Fix locking for idr_alloc/idr_remove

2018-01-18T15:48:31+00:00

This fixes a race with idr_alloc where gd->first_minor can be set to the
same value for two simultaneous calls to ubiblock_create.  Each instance
calls device_add_disk with the same first_minor.  device_add_disk calls
bdi_register_owner which generates several warnings.

WARNING: CPU: 1 PID: 179 at kernel-source/fs/sysfs/dir.c:31
sysfs_warn_dup+0x68/0x88
sysfs: cannot create duplicate filename '/devices/virtual/bdi/252:2'

WARNING: CPU: 1 PID: 179 at kernel-source/lib/kobject.c:240
kobject_add_internal+0x1ec/0x2f8
kobject_add_internal failed for 252:2 with -EEXIST, don't try to
register things with the same name in the same directory

WARNING: CPU: 1 PID: 179 at kernel-source/fs/sysfs/dir.c:31
sysfs_warn_dup+0x68/0x88
sysfs: cannot create duplicate filename '/dev/block/252:2'

However, device_add_disk does not error out when bdi_register_owner
returns an error.  Control continues until reaching blk_register_queue.
It then BUGs.

kernel BUG at kernel-source/fs/sysfs/group.c:113!
[] (internal_create_group) from []
(sysfs_create_group+0x20/0x24)
[] (sysfs_create_group) from []
(blk_trace_init_sysfs+0x18/0x20)
[] (blk_trace_init_sysfs) from []
(blk_register_queue+0xd8/0x154)
[] (blk_register_queue) from []
(device_add_disk+0x194/0x44c)
[] (device_add_disk) from []
(ubiblock_create+0x284/0x2e0)
[] (ubiblock_create) from []
(vol_cdev_ioctl+0x450/0x554)
[] (vol_cdev_ioctl) from [] (vfs_ioctl+0x30/0x44)
[] (vfs_ioctl) from [] (do_vfs_ioctl+0xa0/0x790)
[] (do_vfs_ioctl) from [] (SyS_ioctl+0x44/0x68)
[] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x34)

Locking idr_alloc/idr_remove removes the race and keeps gd->first_minor
unique.

Fixes: 2bf50d42f3a4 ("UBI: block: Dynamically allocate minor numbers")
Cc: stable@vger.kernel.org
Signed-off-by: Bradley Bolen 
Reviewed-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

mtd: ubi: wl: Fix error return code in ubi_wl_init()

2018-01-18T15:45:19+00:00

Fix to return error code -ENOMEM from the kmem_cache_alloc() error
handling case instead of 0, as done elsewhere in this function.

Fixes: f78e5623f45b ("ubi: fastmap: Erase outdated anchor PEBs during
attach")
Signed-off-by: Wei Yongjun 
Reviewed-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

ubi: Fix copy/paste error in function documentation

2018-01-17T23:18:51+00:00

The function documentation of leb_write_trylock is copied from
leb_write_lock. Replace the function name with the correct one.

Signed-off-by: Sascha Hauer 
Signed-off-by: Richard Weinberger

ubi: Fastmap: Fix typo

2018-01-17T23:18:50+00:00

Fix misspelling of 'available' in function name.

Signed-off-by: Sascha Hauer 
Signed-off-by: Richard Weinberger

ubi: fastmap: Erase outdated anchor PEBs during attach

2018-01-17T20:48:05+00:00

The fastmap update code might erase the current fastmap anchor PEB
in case it doesn't find any new free PEB. When a power cut happens
in this situation we must not have any outdated fastmap anchor PEB
on the device, because that would be used to attach during next
boot.
The easiest way to make that sure is to erase all outdated fastmap
anchor PEBs synchronously during attach.

Signed-off-by: Sascha Hauer 
Reviewed-by: Richard Weinberger 
Fixes: dbb7d2a88d2a ("UBI: Add fastmap core")
Cc: 
Signed-off-by: Richard Weinberger

ubi: fastmap: Clean up the initialization of pointer p

2018-01-17T20:48:02+00:00

The pointer p is being initialized with one value and a few lines
later being set to a newer replacement value. Clean up the code by
using the latter assignment to p as the initial value. Cleans up
clang warning:

drivers/mtd/ubi/fastmap.c:217:19: warning: Value stored to 'p'
during its initialization is never read

Signed-off-by: Colin Ian King 
Reviewed-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

ubi: fastmap: Use kmem_cache_free to deallocate memory

2018-01-17T20:48:02+00:00

Memory allocated by kmem_cache_alloc() should not be deallocated with
kfree(). Use kmem_cache_free() instead.

Signed-off-by: Pan Bian 
Reviewed-by: Boris Brezillon 
Signed-off-by: Richard Weinberger

ubi: Fix race condition between ubi volume creation and udev

2018-01-17T20:47:33+00:00

Similar to commit 714fb87e8bc0 ("ubi: Fix race condition between ubi
device creation and udev"), we should make the volume active before
registering it.

Signed-off-by: Clay McClure 
Cc: 
Signed-off-by: Richard Weinberger

mtd: ubi: Use 'max_bad_blocks' to compute bad_peb_limit if available

2018-01-17T18:28:54+00:00

If the user has not set max_beb_per1024 using either the cmdline or
Kconfig options for doing so, use the MTD function 'max_bad_blocks' to
compute the UBI bad_peb_limit.

Signed-off-by: Jeff Westfahl 
Signed-off-by: Zach Brown 
Acked-by: Boris Brezillon 
Acked-by: Richard Weinberger 
Signed-off-by: Richard Weinberger

Merge tag 'modules-for-v4.15' of git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux

2017-11-15T21:46:33+00:00

Pull module updates from Jessica Yu:
 "Summary of modules changes for the 4.15 merge window:

   - treewide module_param_call() cleanup, fix up set/get function
     prototype mismatches, from Kees Cook

   - minor code cleanups"

* tag 'modules-for-v4.15' of git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux:
  module: Do not paper over type mismatches in module_param_call()
  treewide: Fix function prototypes for module_param_call()
  module: Prepare to convert all module_param_call() prototypes
  kernel/module: Delete an error message for a failed memory allocation in add_module_usage()