linux-stable.git/drivers/mtd/ubi, branch v3.18.2

UBI: Fastmap: Calc fastmap size correctly

2014-10-03T14:33:28+00:00

We need to add fm_sb too.

Signed-off-by: Richard Weinberger 
Reviewed-by: Tanya Brokhman 
Signed-off-by: Artem Bityutskiy

UBI: Fix trivial typo in __schedule_ubi_work

2014-09-30T06:29:37+00:00

s/of/if/

Signed-off-by: Richard Weinberger 
Signed-off-by: Artem Bityutskiy

UBI: wl: Rename cancel flag to shutdown

2014-09-26T10:43:32+00:00

It confused me more than once that the cancel flag of the
work function does not indicate the cancellation of a single work.
In fact it indicates the WL sub-system shutdown and therefore
worker functions have to free their wl_entries too.
That's why you cannot cancel a single work, you can only shutdown
all works.

Signed-off-by: Richard Weinberger 
Signed-off-by: Artem Bityutskiy

UBI: ubi_eba_read_leb: Remove in vain variable assignment

2014-09-26T10:42:41+00:00

There is no need to set err, it will be overwritten in any case
later at:
        if (scrub)
                err = ubi_wl_scrub_peb(ubi, pnum);

Signed-off-by: Richard Weinberger 
Signed-off-by: Artem Bityutskiy

UBI: Fix livelock in produce_free_peb()

2014-09-24T12:36:16+00:00

The while loop in produce_free_peb() assumes that each work will produce a
free PEB. This is not true.
If ubi->works_count is 1 and the only scheduled work is the
wear_leveling_worker() produce_free_peb() can loop forever in case
nobody schedules an erase work.
Fix this issue by checking in the while loop whether work is scheduled.

Signed-off-by: Richard Weinberger 
Signed-off-by: Artem Bityutskiy

UBI: return on error in rename_volumes()

2014-09-19T15:12:00+00:00

I noticed this during a code review.  We are checking that the strlen()
of ->name is not less than the ->name_len which the user gave us.  I
believe this bug is harmless but clearly we meant to return here instead
of setting an error code and then not using it.

Signed-off-by: Dan Carpenter 
Signed-off-by: Artem Bityutskiy

UBI: Improve comment on work_sem

2014-09-19T15:11:57+00:00

Make clear what work_sem really does.

Suggested-by: Artem Bityutskiy 
Signed-off-by: Richard Weinberger 
Signed-off-by: Artem Bityutskiy

UBI: Dispatch update notification if the volume is updated

2014-09-16T16:02:05+00:00

The UBI_IOCVOLUP ioctl is used to start an update and also to
truncate a volume. In the first case, a "volume updated" notification
is dispatched when the update is done.

This commit adds the "volume updated" notification to be also sent when
the volume is truncated. This is required for UBI block and gluebi to get
notified about the new volume size.

Signed-off-by: Ezequiel Garcia 
Signed-off-by: Artem Bityutskiy 
Cc: stable@vger.kernel.org # v3.15+

UBI: block: Add support for the UBI_VOLUME_UPDATED notification

2014-09-16T16:02:04+00:00

Static volumes can change its 'used_bytes' when they get updated,
and so the block interface must listen to the UBI_VOLUME_UPDATED
notification to resize the block device accordingly.

Signed-off-by: Ezequiel Garcia 
Signed-off-by: Artem Bityutskiy 
Cc: stable@vger.kernel.org # v3.15+

UBI: block: Fix block device size setting

2014-09-16T16:02:04+00:00

We are currently taking the block device size from the ubi_volume_info.size
field. However, this is not the amount of data in the volume, but the
number of reserved physical eraseblocks, and hence leads to an incorrect
representation of the volume.

In particular, this produces I/O errors on static volumes as the block
interface may attempt to read unmapped PEBs:

$ cat /dev/ubiblock0_0 > /dev/null
UBI error: ubiblock_read_to_buf: ubiblock0_0 ubi_read error -22
end_request: I/O error, dev ubiblock0_0, sector 9536
Buffer I/O error on device ubiblock0_0, logical block 2384
[snip]

Fix this by using the ubi_volume_info.used_bytes field which is set to the
actual number of data bytes for both static and dynamic volumes.

While here, improve the error message to be less stupid and more useful:
UBI error: ubiblock_read_to_buf: ubiblock0_1 ubi_read error -9 on LEB=0, off=15872, len=512

It's worth noticing that the 512-byte sector representation of the volume
is only correct if the volume size is multiple of 512-bytes. This is true for
virtually any NAND device, given eraseblocks and pages are 512-byte multiple
and hence so is the LEB size.

Artem: tweak the error message and make it look more like other UBI error
messages.

Fixes: 9d54c8a33eec ("UBI: R/O block driver on top of UBI volumes")
Signed-off-by: Ezequiel Garcia 
Signed-off-by: Artem Bityutskiy 
Cc: stable@vger.kernel.org # v3.15+