linux-stable.git/drivers/mtd/ubi, branch linux-4.8.y

ubi: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()

2016-11-10T15:38:57+00:00

commit 40b6e61ac72e99672e47cdb99c8d7d226004169b upstream.

Commit e96a8a3bb671 ("UBI: Fastmap: Do not add vol if it already
exists") introduced a bug by changing the possible error codes returned
by add_vol():
- this function no longer returns NULL in case of allocation failure
  but return ERR_PTR(-ENOMEM)
- when a duplicate entry in the volume RB tree is found it returns
  ERR_PTR(-EEXIST) instead of ERR_PTR(-EINVAL)

Fix the tests done on add_vol() return val to match this new behavior.

Fixes: e96a8a3bb671 ("UBI: Fastmap: Do not add vol if it already exists")
Reported-by: Dan Carpenter 
Signed-off-by: Boris Brezillon 
Acked-by: Sheng Yong 
Signed-off-by: Richard Weinberger 
Signed-off-by: Greg Kroah-Hartman

UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header

2016-11-10T15:38:56+00:00

commit ecbfa8eabae9cd73522d1d3d15869703c263d859 upstream.

scan_pool() does not mark the PEB for scrubing when bitflips are
detected in the EC header of a free PEB (VID header region left to
0xff).
Make sure we scrub the PEB in this case.

Signed-off-by: Boris Brezillon 
Fixes: dbb7d2a88d2a ("UBI: Add fastmap core")
Signed-off-by: Richard Weinberger 
Signed-off-by: Greg Kroah-Hartman

ubi: Deal with interrupted erasures in WL

2016-10-28T07:45:22+00:00

commit 2365418879e9abf12ea9def7f9f3caf0dfa7ffb0 upstream.

When Fastmap is used we can face here an -EBADMSG
since Fastmap cannot know about unmaps.
If the erasure was interrupted the PEB may show ECC
errors and UBI would go to ro-mode as it assumes
that the PEB was check during attach time, which is
not the case with Fastmap.

Fixes: dbb7d2a88d ("UBI: Add fastmap core")
Signed-off-by: Richard Weinberger 
Signed-off-by: Greg Kroah-Hartman

ubi: Use bitmaps in Fastmap self-check code

2016-07-29T21:32:58+00:00

...don't waste memory by allocating one sizeof(int) per
PEB.

Signed-off-by: Richard Weinberger

ubi: Be more paranoid while seaching for the most recent Fastmap

2016-07-29T21:32:54+00:00

Since PEB erasure is asynchornous it can happen that there is
more than one Fastmap on the MTD. This is fine because the attach logic
will pick the Fastmap data structure with the highest sequence number.

On a not so well configured MTD stack spurious ECC errors are common.
Causes can be different, bad hardware, wrong operating modes, etc...
If the most current Fastmap renders bad due to ECC errors UBI might
pick an older Fastmap to attach from.
While this can only happen on an anyway broken setup it will show
completely different sympthoms and makes finding the root cause much
more difficult.
So, be debug friendly and fall back to scanning mode of we're facing
an ECC error while scanning for Fastmap.

Cc: 
Signed-off-by: Richard Weinberger

ubi: Check whether the Fastmap anchor matches the super block

2016-07-29T21:32:43+00:00

This helps to detect cases where an user copies an UBI image to
another target with different bad blocks.

Signed-off-by: Richard Weinberger

ubi: Rework Fastmap attach base code

2016-07-29T21:32:42+00:00

Introduce a new list to the UBI attach information
object to be able to deal better with old and corrupted
Fastmap eraseblocks.
Also move more Fastmap specific code into fastmap.c.

Signed-off-by: Richard Weinberger

ubi: Fix whitespace issue in count_fastmap_pebs()

2016-07-29T21:32:40+00:00

Signed-off-by: Richard Weinberger

ubi: Introduce vol_ignored()

2016-07-29T21:32:39+00:00

This makes the logic more easy to follow.

Signed-off-by: Richard Weinberger

ubi: Fix scan_fast() comment

2016-07-29T21:32:38+00:00

Signed-off-by: Richard Weinberger