linux-stable.git/drivers/mtd/ubi/scan.c, branch linux-3.2.y

UBI: account for bitflips in both the VID header and data

2015-08-06T23:32:01+00:00

commit 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 upstream.

We are completely discarding the earlier value of 'bitflips', which
could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the
bitwise OR of header and data 'bitflip' statuses instead.

Coverity CID #1226856

Signed-off-by: Brian Norris 
Signed-off-by: Richard Weinberger 
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings

UBI: erase free PEB with bitflip in EC header

2012-10-17T02:48:19+00:00

commit 193819cf2e6e395b1e1be2d36785dc5563a6edca upstream.

Without this patch, these PEB are not scrubbed until we put data in them.
Bitflip can accumulate latter and we can loose the EC header (but VID header
should be intact and allow to recover data).

Signed-off-by: Matthieu Castet 
Signed-off-by: Artem Bityutskiy 
[bwh: Backported to 3.2: adjust filename, context]
Signed-off-by: Ben Hutchings

UBI: fix error handling in ubi_scan()

2012-04-02T16:52:51+00:00

commit a29852be492d61001d86c6ebf5fff9b93d7b4be9 upstream.

Two bad things can happen in ubi_scan():
1. If kmem_cache_create() fails we jump to out_si and call
   ubi_scan_destroy_si() which calls kmem_cache_destroy().
   But si->scan_leb_slab is NULL.
2. If process_eb() fails we jump to out_vidh, call
   kmem_cache_destroy() and ubi_scan_destroy_si() which calls
   again kmem_cache_destroy().

Signed-off-by: Richard Weinberger 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: Greg Kroah-Hartman

mtd: utilize `mtd_is_*()' functions

2011-09-21T06:19:06+00:00

Signed-off-by: Brian Norris 
Signed-off-by: Artem Bityutskiy

UBI: use debugfs for the extra checks knobs

2011-06-01T08:21:47+00:00

This patch introduces debugfs support to UBI. All the UBI stuff is kept in the
"ubi" debugfs directory, which contains per-UBI device "ubi/ubiX"
sub-directories, containing debugging files. This file also creates
"ubi/ubiX/chk_gen" and "ubi/ubiX/chk_io" knobs for switching general and I/O
extra checks on and off. And it removes the 'debug_chks' UBI module parameters.

Signed-off-by: Artem Bityutskiy

UBI: fix minor stylistic issues

2011-04-14T08:34:41+00:00

Fix checkpatch.pl errors and warnings:

* space before tab
* line over 80 characters
* include linux/ioctl.h instead of asm/ioctl.h

Signed-off-by: Artem Bityutskiy

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

UBI: make self-checks dynamic

2011-03-16T11:50:16+00:00

This patch adds a possibility to dynamically switch UBI self-checks
on and off, instead of toggling them compile-time from the configuration
menu. This is much more flexible, and consistent with UBIFS, and this
also simplifies UBI Kconfig menu and the code.

This patch introduces two levels of self-checks - general, which
includes all self-checks which are relatively fast, and I/O, which
includes write-verify checks and erase-verify checks, which are
relatively slow and involve flash I/O.

Signed-off-by: Artem Bityutskiy

UBI: cleanup comments about corrupted PEBs

2011-02-06T17:19:41+00:00

Just make them a bit more readable and explanatory.

Signed-off-by: Artem Bityutskiy

UBI: add slab cache for ubi_scan_leb objects

2011-02-06T17:19:23+00:00

During scanning UBI allocates one struct ubi_scan_leb object for each PEB,
so it can end up allocating thousands of them. Use slab cache to reduce
memory consumption for these 48-byte objects, because currently used
'kmalloc()' ends up allocating 64 bytes per object, instead of 48.

Signed-off-by: Artem Bityutskiy