linux-stable.git/drivers/mtd/ubi/attach.c, branch linux-4.8.y Linux kernel stable tree ubi: Be more paranoid while seaching for the most recent Fastmap 2016-07-29T21:32:54+00:00 Richard Weinberger richard@nod.at 2016-06-14T08:12:17+00:00 74f2c6e9a47cf4e508198c8594626cc82906a13d Since PEB erasure is asynchornous it can happen that there is more than one Fastmap on the MTD. This is fine because the attach logic will pick the Fastmap data structure with the highest sequence number. On a not so well configured MTD stack spurious ECC errors are common. Causes can be different, bad hardware, wrong operating modes, etc... If the most current Fastmap renders bad due to ECC errors UBI might pick an older Fastmap to attach from. While this can only happen on an anyway broken setup it will show completely different sympthoms and makes finding the root cause much more difficult. So, be debug friendly and fall back to scanning mode of we're facing an ECC error while scanning for Fastmap. Cc: <stable@vger.kernel.org> Signed-off-by: Richard Weinberger <richard@nod.at> 
Since PEB erasure is asynchornous it can happen that there is
more than one Fastmap on the MTD. This is fine because the attach logic
will pick the Fastmap data structure with the highest sequence number.

On a not so well configured MTD stack spurious ECC errors are common.
Causes can be different, bad hardware, wrong operating modes, etc...
If the most current Fastmap renders bad due to ECC errors UBI might
pick an older Fastmap to attach from.
While this can only happen on an anyway broken setup it will show
completely different sympthoms and makes finding the root cause much
more difficult.
So, be debug friendly and fall back to scanning mode of we're facing
an ECC error while scanning for Fastmap.

Cc: <stable@vger.kernel.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
ubi: Rework Fastmap attach base code 2016-07-29T21:32:42+00:00 Richard Weinberger richard@nod.at 2016-06-14T08:12:15+00:00 fdf10ed710c0aa177e8dfcd84e65e4e5e8e0956b Introduce a new list to the UBI attach information object to be able to deal better with old and corrupted Fastmap eraseblocks. Also move more Fastmap specific code into fastmap.c. Signed-off-by: Richard Weinberger <richard@nod.at> 
Introduce a new list to the UBI attach information
object to be able to deal better with old and corrupted
Fastmap eraseblocks.
Also move more Fastmap specific code into fastmap.c.

Signed-off-by: Richard Weinberger <richard@nod.at>
ubi: Introduce vol_ignored() 2016-07-29T21:32:39+00:00 Richard Weinberger richard@nod.at 2016-06-14T08:12:13+00:00 243a4f8126fcf7facb04b324dbb7c85d10b11ce9 This makes the logic more easy to follow. Signed-off-by: Richard Weinberger <richard@nod.at> 
This makes the logic more easy to follow.

Signed-off-by: Richard Weinberger <richard@nod.at>
ubi: Fix scan_fast() comment 2016-07-29T21:32:38+00:00 Richard Weinberger richard@nod.at 2016-06-14T08:12:12+00:00 d139d300a9562fa6571ec95ac6fefd9b1a0a4fd7 Signed-off-by: Richard Weinberger <richard@nod.at> 
Signed-off-by: Richard Weinberger <richard@nod.at>
UBI: drop null test before destroy functions 2015-10-03T18:36:10+00:00 Julia Lawall julia.lawall@lip6.fr 2015-09-13T12:15:16+00:00 f9a113d65fa56d8e8e662e37ec2fbeac0d52aa01 Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Richard Weinberger <richard@nod.at> 
Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression x; @@
-if (x != NULL)
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Richard Weinberger <richard@nod.at>
UBI: Fastmap: Fall back to scanning mode after ECC error 2015-03-26T22:03:15+00:00 Richard Weinberger richard@nod.at 2015-03-09T09:04:09+00:00 180a53577b809026af744e99a35b3a3a0056520b If we encounter an uncorrectable ECC error while scanning for the fastmap UBI must not fail hard. Instead fall back to scanning mode. Reported-by: Alexander Block <Alexander.Block@continental-corporation.com> Signed-off-by: Richard Weinberger <richard@nod.at> 
If we encounter an uncorrectable ECC error while scanning for the fastmap
UBI must not fail hard. Instead fall back to scanning mode.

Reported-by: Alexander Block <Alexander.Block@continental-corporation.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
UBI: Fastmap: Make self_check_eba() depend on fastmap self checking 2015-03-26T21:46:05+00:00 Richard Weinberger richard@nod.at 2014-10-27T12:00:26+00:00 560d86a1a210000b33859cd66e051fcb516a3559 ...instead of generic self checking. Signed-off-by: Richard Weinberger <richard@nod.at> 
...instead of generic self checking.

Signed-off-by: Richard Weinberger <richard@nod.at>
UBI: Remove alloc_ai() slab name from parameter list 2015-03-26T21:45:57+00:00 Richard Weinberger richard@nod.at 2014-10-06T13:58:07+00:00 d2158f69a7d469c21c37f7028c18aa8c54707de3 There is always exactly one ubi_attach_info object allocated, therefore we don't have to care about the name. Signed-off-by: Richard Weinberger <richard@nod.at> 
There is always exactly one ubi_attach_info object allocated,
therefore we don't have to care about the name.

Signed-off-by: Richard Weinberger <richard@nod.at>
UBI: Fastmap: Fix memory leak while attaching 2015-03-26T21:45:57+00:00 Richard Weinberger richard@nod.at 2014-10-06T13:39:01+00:00 98105d0819daf569e741ddfba73cedcac371b9d8 Currently we leak a few ubi_ainf_pebs while attaching. Signed-off-by: Richard Weinberger <richard@nod.at> 
Currently we leak a few ubi_ainf_pebs while attaching.

Signed-off-by: Richard Weinberger <richard@nod.at>
UBI: account for bitflips in both the VID header and data 2015-03-26T11:07:17+00:00 Brian Norris computersforpeace@gmail.com 2015-02-28T10:23:25+00:00 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 We are completely discarding the earlier value of 'bitflips', which could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the bitwise OR of header and data 'bitflip' statuses instead. Coverity CID #1226856 Cc: stable <stable@vger.kernel.org> Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Richard Weinberger <richard@nod.at> 
We are completely discarding the earlier value of 'bitflips', which
could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the
bitwise OR of header and data 'bitflip' statuses instead.

Coverity CID #1226856

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>