linux-stable.git/drivers/mtd/ubi/attach.c, branch linux-3.13.y Linux kernel stable tree UBI: simplify image sequence test 2013-10-03T16:42:50+00:00 Richard Genoud richard.genoud@gmail.com 2013-09-28T13:55:14+00:00 55b80c409a1368b8dff3c78943101bccb0ea3aa1 The test: if (!a && b) a = b; can be symplified in: if (!a) a = b; And there's no need to test if ubi->image_seq is not null, because if it is, it is set to image_seq. So, we just test if image_seq is not null. Signed-off-by: Richard Genoud <richard.genoud@gmail.com> Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
The test:
if (!a && b)
  a = b;
can be symplified in:
if (!a)
  a = b;

And there's no need to test if ubi->image_seq is not null, because if it is,
it is set to image_seq.
So, we just test if image_seq is not null.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: Call scan_all() with correct offset in error case 2013-10-03T16:42:49+00:00 Richard Weinberger richard@nod.at 2013-09-28T13:55:12+00:00 4b3e0a25aa5518892ec8dbfafdd6a57789aa0c22 If we find an invalid fastmap we have to scan from the very beginning. Otherwise we leak the first 64 PEBs. Reported-and-tested-by: Richard Genoud <richard.genoud@gmail.com> Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
If we find an invalid fastmap we have to scan from the very beginning.
Otherwise we leak the first 64 PEBs.

Reported-and-tested-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: introduce helpers dbg_chk_{io, gen} 2012-12-10T11:38:59+00:00 Ezequiel Garcia elezegarcia@gmail.com 2012-11-28T12:18:29+00:00 64575574f26d7969713ede9bde750c979da4037e With this patch code is a bit more readable and there's no generated code or functionality impact. Furthermore, this abstracts implementation details and will allow to change ubi_debug_info in a less invasive way. Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
With this patch code is a bit more readable and there's no
generated code or functionality impact.
Furthermore, this abstracts implementation details and
will allow to change ubi_debug_info in a less invasive way.

Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: do not allocate the memory unnecessarily 2012-10-26T13:29:46+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2012-10-26T13:11:26+00:00 d125a753425b9de3c251df519e521024c79c663d UBI reserves an LEB sized buffer for various needs. We can use this buffer while scanning, instead of allocating another one. This patch was originally created by Jan Luebbe <jlu@pengutronix.de>, but then he dropped it and I picked up and tweaked a little bit. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
UBI reserves an LEB sized buffer for various needs. We can use this buffer
while scanning, instead of allocating another one. This patch was originally
created by Jan Luebbe <jlu@pengutronix.de>, but then he dropped it and I picked
up and tweaked a little bit.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: Add fastmap stuff to attach.c 2012-10-03T09:29:38+00:00 Richard Weinberger richard@nod.at 2012-09-26T15:51:47+00:00 dac6e2087a4143cfc3fc1017bf24b9d4be3055b7 - Export compare_lebs() as fastmap needs this function. - Implement fastmap scan logic. Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
- Export compare_lebs() as fastmap needs this function.
- Implement fastmap scan logic.

Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: fix trivial typo 'it' => 'is' 2012-09-26T10:22:50+00:00 Brian Norris computersforpeace@gmail.com 2012-08-31T21:43:41+00:00 55393ba1bdedc5ded79b34b4cc08898a7776cddb Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: print less 2012-09-04T06:39:02+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2012-08-27T14:14:58+00:00 719bb84017fcfc949a77e150dd5b045e90a4ebc9 UBI currently prints a lot of information when it mounts a volume, which bothers some people. Make it less chatty - print only important information by default. Get rid of 'dbg_msg()' macro completely. Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
UBI currently prints a lot of information when it mounts a volume, which
bothers some people. Make it less chatty - print only important information
by default.

Get rid of 'dbg_msg()' macro completely.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: use pr_ helper instead of printk 2012-09-04T06:39:02+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2012-08-27T12:13:05+00:00 e28453bbb76c290d67eb28b3ff6875a6519c3998 Use 'pr_err()' instead of 'printk(KERN_ERR', etc. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
Use 'pr_err()' instead of 'printk(KERN_ERR', etc.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: comply with coding style 2012-09-04T06:39:01+00:00 Artem Bityutskiy artem.bityutskiy@linux.intel.com 2012-08-27T11:43:54+00:00 049333cecbde11988c49ad4d7861eefbc3534422 Join all the split printk lines in order to stop checkpatch complaining. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
Join all the split printk lines in order to stop checkpatch complaining.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UBI: erase free PEB with bitflip in EC header 2012-09-04T06:39:01+00:00 Matthieu CASTET matthieu.castet@parrot.com 2012-08-22T14:03:46+00:00 193819cf2e6e395b1e1be2d36785dc5563a6edca Without this patch, these PEB are not scrubbed until we put data in them. Bitflip can accumulate latter and we can loose the EC header (but VID header should be intact and allow to recover data). Signed-off-by: Matthieu Castet <matthieu.castet@parrot.com> Cc: stable@vger.kernel.org Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> 
Without this patch, these PEB are not scrubbed until we put data in them.
Bitflip can accumulate latter and we can loose the EC header (but VID header
should be intact and allow to recover data).

Signed-off-by: Matthieu Castet <matthieu.castet@parrot.com>
Cc: stable@vger.kernel.org
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>