linux-stable.git/drivers/mtd/maps/physmap.c, branch linux-2.6.25.y

mtd: maps/physmap: fix oops in suspend/resume/shutdown ops

2008-03-28T21:45:22+00:00

# reboot
...
[   42.351266] Flash device refused suspend due to active operation (state 0)
[   42.358195] Unable to handle kernel NULL pointer dereference at virtual address 00000078
[   42.360060] pgd = c7d9c000
[   42.362769] [00000078] *pgd=a7d8d031, *pte=00000000, *ppte=00000000
[   42.372902] Internal error: Oops: 17 [#1]
[   42.376911] Modules linked in:
[   42.379980] CPU: 0    Not tainted  (2.6.25-rc2-10642-ge8f2594-dirty #73)
[   42.380000] PC is at physmap_flash_shutdown+0x28/0x54
...
[   42.380000] Backtrace:
[   42.380000] [] (physmap_flash_shutdown+0x0/0x54) from [] (platform_drv_shutdown+0x20/0x24)
[   42.380000]  r5:28121969 r4:c0229e08
[   42.380000] [] (platform_drv_shutdown+0x0/0x24) from [] (device_shutdown+0x60/0x88)
[   42.380000] [] (device_shutdown+0x0/0x88) from [] (kernel_restart_prepare+0x2c/0x3c)
[   42.380000]  r4:00000000
[   42.380000] [] (kernel_restart_prepare+0x0/0x3c) from [] (kernel_restart+0x14/0x48)
[   42.380000] [] (kernel_restart+0x0/0x48) from [] (sys_reboot+0xe8/0x1f8)
[   42.380000]  r4:01234567
[   42.380000] [] (sys_reboot+0x0/0x1f8) from [] (ret_fast_syscall+0x0/0x2c)
[   42.380000]  r7:00000058 r6:00000004 r5:00000001 r4:00000000
[   42.380000] Code: 0a000009 e7953004 e1a00003 e1a0e00f (e593f078)
[   42.650051] ---[ end trace 6d6c26a0fc3141de ]---
Segmentation fault
INIT: no more processes left in this runlevel

While looping for mtd[i]s, we should stop at the mtd[i] == NULL.

This patch also removes unnecessary "if (info)" checks:
suspend/resume/shutdown ops are executed only if probe() is succeeded, so info
is guaranteed to be !NULL.

Signed-off-by: Anton Vorontsov 
Cc: David Brownell 
Cc: David Woodhouse 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[MTD] Fix maps/physmap.c compilation with CONFIG_PM

2008-02-07T10:33:40+00:00

Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse

[MTD] physmap.c: Add support for multiple resources

2008-02-03T11:16:02+00:00

This patch extends the physmap mapping driver to support multiple
resources for non-identical NOR chips that will be concatenated together
when selected.

This is needed for example for Intel 48F4400 512MBit chips, since they
consist of 2 single different NOR chips with different geometries. The
first (lower) one has botton boot sectors and the 2nd (upper) has top
boot sectors. This currently isn't handled correctly by calling the
physmap driver once with only one resource covering both chips in one
memory region. The same geometrie is used for both chips.

With this patch the following resource structure can be used to
describe the 48F4400 chip correctly:

static struct resource board_nor_resource[] = {
	[0] = {
		.start = 0xf8000000,
		.end = 0xfbffffff,
		.flags = IORESOURCE_MEM,
	},
	[1] = {
		.start = 0xfc000000,
		.end = 0xffffffff,
		.flags = IORESOURCE_MEM,
	}
};

Signed-off-by: Stefan Roese 
Signed-off-by: David Woodhouse

[MTD] replace kmalloc+memset with kzalloc

2006-11-28T23:47:21+00:00

Signed-off-by: Yan Burman 
Signed-off-by: David Woodhouse

[MTD] Fix printk format warning in physmap. (resources again)

2006-11-28T23:40:46+00:00

Fix printk format warning:
drivers/mtd/maps/physmap.c:93: warning: long long unsigned int format, long unsigned int arg (arg 2)

Signed-off-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse

[PATCH] mtd: remove several bogus casts to void * in iounmap() argument

2006-10-10T22:37:22+00:00

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[MTD] physmap: add power management support

2006-09-22T09:26:56+00:00

Implement PM handling for physmap.  Idea from Steven Scholz, patch
by David Anders.

Signed-off-by: Lennert Buytenhek 
Signed-off-by: David Woodhouse

Remove obsolete #include

2006-06-30T17:25:36+00:00

Signed-off-by: Jörn Engel 
Signed-off-by: Adrian Bunk

[MTD] Fix off-by-one error in physmap.c

2006-06-27T13:38:15+00:00

This patch fixes a simple off-by-one error in the mtd physmap driver.

Signed-off-by: Sascha Hauer 
Signed-off-by: Lennert Buytenhek 
Signed-off-by: David Woodhouse

[MTD] Prepare physmap for 64-bit-resources

2006-06-09T14:12:34+00:00

Fallout from the incoming 64-bit-resource stuff:

drivers/mtd/maps/physmap.c: In function 'physmap_flash_probe':
drivers/mtd/maps/physmap.c:94: warning: format '%.8lx' expects type 'long
unsigned int', but argument 2 has type 'resource_size_t'
drivers/mtd/maps/physmap.c:94: warning: format '%.8lx' expects type 'long
unsigned int', but argument 3 has type 'resource_size_t'

Cc: Vivek Goyal 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse