linux-stable.git/drivers/mtd/cmdlinepart.c, branch linux-4.19.y

mtd: parser: cmdline: Fix parsing of part-names with colons

2020-12-30T10:26:15+00:00

commit 639a82434f16a6df0ce0e7c8595976f1293940fd upstream.

Some devices (especially QCA ones) are already using hardcoded partition
names with colons in it. The OpenMesh A62 for example provides following
mtd relevant information via cmdline:

  root=31:11 mtdparts=spi0.0:256k(0:SBL1),128k(0:MIBIB),384k(0:QSEE),64k(0:CDT),64k(0:DDRPARAMS),64k(0:APPSBLENV),512k(0:APPSBL),64k(0:ART),64k(custom),64k(0:KEYS),0x002b0000(kernel),0x00c80000(rootfs),15552k(inactive) rootfsname=rootfs rootwait

The change to split only on the last colon between mtd-id and partitions
will cause newpart to see following string for the first partition:

  KEYS),0x002b0000(kernel),0x00c80000(rootfs),15552k(inactive)

Such a partition list cannot be parsed and thus the device fails to boot.

Avoid this behavior by making sure that the start of the first part-name
("(") will also be the last byte the mtd-id split algorithm is using for
its colon search.

Fixes: eb13fa022741 ("mtd: parser: cmdline: Support MTD names containing one or more colons")
Cc: stable@vger.kernel.org
Cc: Ron Minnich 
Signed-off-by: Sven Eckelmann 
Signed-off-by: Miquel Raynal 
Link: https://lore.kernel.org/linux-mtd/20201124062506.185392-1-sven@narfation.org
Signed-off-by: Greg Kroah-Hartman

mtd: parser: cmdline: Support MTD names containing one or more colons

2020-10-01T11:14:48+00:00

[ Upstream commit eb13fa0227417e84aecc3bd9c029d376e33474d3 ]

Looks like some drivers define MTD names with a colon in it, thus
making mtdpart= parsing impossible. Let's fix the parser to gracefully
handle that case: the last ':' in a partition definition sequence is
considered instead of the first one.

Signed-off-by: Boris Brezillon 
Signed-off-by: Ron Minnich 
Tested-by: Ron Minnich 
Signed-off-by: Richard Weinberger 
Signed-off-by: Sasha Levin

mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

2018-05-23T08:08:48+00:00

The comment about offset zero was not updated when changing behavior:
  - Automatic offset calculation is indicated by OFFSET_CONTINUOUS,
  - Zero really means offset zero.

Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: allow zero offset value")
Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Boris Brezillon

mtd: partitions: make parsers return 'const' partition arrays

2015-12-09T18:21:57+00:00

We only want to modify these arrays inside the parser "drivers", so the
drivers should construct them however they like, then return them as
immutable arrays.

This will make other refactorings easier.

Signed-off-by: Brian Norris 
Reviewed-by: Boris Brezillon

mtd: kill off MTD partition parser boilerplate

2015-11-20T02:46:29+00:00

Most parsers can be handled with our new boilerplate-reducing macro.
There are a few that can't be (cmdlineparts and ofpart).

Also kill off the owner assignments, since register_mtd_parser() now
takes care of that.

Signed-off-by: Brian Norris

mtd: cmdlinepart: convert printk() to pr_*()

2015-09-29T01:37:32+00:00

This driver uses some custom macros for printing. Let's use the standard
pr_fmt()/pr_{err,warn}().

Signed-off-by: Brian Norris

mtd: cmdlinepart: allow small partitions

2015-09-29T01:37:31+00:00

I'm not sure why we have a PAGE_SIZE restriction on this partition
parser.

If we really wanted the restriction, I would expect it to be a
restriction for *all* parsers, so we'd move it to the MTD core

At any rate, while small partitions may not be useful (they'll often be
smaller than the eraseblock size and therefore can only be used
read-only), they still have use as a read-only partition.

This restriction is especially annoying because it aborts the entire
MTD's cmdline parsing, leaving it unpartitioned.

So, let's kill the restriction and only check for zero-sized partitions,
which I expect we don't want to allow.

Signed-off-by: Brian Norris

mtd: cmdlinepart: Spelling s/trucate/truncate/

2014-07-02T22:17:15+00:00

Signed-off-by: Geert Uytterhoeven 
Cc: Brian Norris 
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Brian Norris

mtd: make register_mtd_parser return void

2014-01-03T19:22:22+00:00

register_mtd_parser never fails; hence make it return void.

Signed-off-by: Axel Lin 
Signed-off-by: Brian Norris

mtd: Allow removal of partitioning modules

2013-02-04T07:27:33+00:00

Signed-off-by: Lubomir Rintel 
Signed-off-by: Artem Bityutskiy